All of lore.kernel.org
 help / color / mirror / Atom feed
From: chrubis-AlSwsSmVLrQ@public.gmane.org
To: "Michael Kerrisk (man-pages)"
	<mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Richard Hansen <rhansen-A08e6c8yq/Q@public.gmane.org>,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Greg Troxel <gdt-2FjktZCtrC/QT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] mm: msync: require either MS_ASYNC or MS_SYNC
Date: Wed, 2 Apr 2014 12:45:17 +0200	[thread overview]
Message-ID: <20140402104517.GA20656@rei> (raw)
In-Reply-To: <533B1439.3010403-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Hi!
> > and there's no good
> > reason to believe that this behavior would have persisted
> > indefinitely.
> > 
> > The msync(2) man page (as currently written in man-pages.git) is
> > silent on the behavior if both flags are unset, so this change should
> > not break an application written by somone who carefully reads the
> > Linux man pages or the POSIX spec.
> 
> Sadly, people do not always carefully read man pages, so there
> remains the chance that a change like this will break applications.
> Aside from standards conformance, what do you see as the benefit
> of the change?

I've looked around Linux Test Project and this change will break a few
testcases, but nothing that couldn't be easily fixed.

The rest of the world may be more problematic though.

-- 
Cyril Hrubis
chrubis-AlSwsSmVLrQ@public.gmane.org

WARNING: multiple messages have this Message-ID (diff)
From: chrubis@suse.cz
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: Richard Hansen <rhansen@bbn.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-api@vger.kernel.org, Greg Troxel <gdt@ir.bbn.com>
Subject: Re: [PATCH] mm: msync: require either MS_ASYNC or MS_SYNC
Date: Wed, 2 Apr 2014 12:45:17 +0200	[thread overview]
Message-ID: <20140402104517.GA20656@rei> (raw)
In-Reply-To: <533B1439.3010403@gmail.com>

Hi!
> > and there's no good
> > reason to believe that this behavior would have persisted
> > indefinitely.
> > 
> > The msync(2) man page (as currently written in man-pages.git) is
> > silent on the behavior if both flags are unset, so this change should
> > not break an application written by somone who carefully reads the
> > Linux man pages or the POSIX spec.
> 
> Sadly, people do not always carefully read man pages, so there
> remains the chance that a change like this will break applications.
> Aside from standards conformance, what do you see as the benefit
> of the change?

I've looked around Linux Test Project and this change will break a few
testcases, but nothing that couldn't be easily fixed.

The rest of the world may be more problematic though.

-- 
Cyril Hrubis
chrubis@suse.cz

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: chrubis@suse.cz
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: Richard Hansen <rhansen@bbn.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-api@vger.kernel.org, Greg Troxel <gdt@ir.bbn.com>
Subject: Re: [PATCH] mm: msync: require either MS_ASYNC or MS_SYNC
Date: Wed, 2 Apr 2014 12:45:17 +0200	[thread overview]
Message-ID: <20140402104517.GA20656@rei> (raw)
In-Reply-To: <533B1439.3010403@gmail.com>

Hi!
> > and there's no good
> > reason to believe that this behavior would have persisted
> > indefinitely.
> > 
> > The msync(2) man page (as currently written in man-pages.git) is
> > silent on the behavior if both flags are unset, so this change should
> > not break an application written by somone who carefully reads the
> > Linux man pages or the POSIX spec.
> 
> Sadly, people do not always carefully read man pages, so there
> remains the chance that a change like this will break applications.
> Aside from standards conformance, what do you see as the benefit
> of the change?

I've looked around Linux Test Project and this change will break a few
testcases, but nothing that couldn't be easily fixed.

The rest of the world may be more problematic though.

-- 
Cyril Hrubis
chrubis@suse.cz

  parent reply	other threads:[~2014-04-02 10:45 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-01 18:25 [PATCH] mm: msync: require either MS_ASYNC or MS_SYNC Richard Hansen
2014-04-01 18:25 ` Richard Hansen
     [not found] ` <533B04A9.6090405-A08e6c8yq/Q@public.gmane.org>
2014-04-01 19:32   ` Michael Kerrisk (man-pages)
2014-04-01 19:32     ` Michael Kerrisk (man-pages)
2014-04-01 19:32     ` Michael Kerrisk (man-pages)
2014-04-02  0:53     ` Richard Hansen
2014-04-02  0:53       ` Richard Hansen
     [not found]     ` <533B1439.3010403-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-04-02 10:45       ` chrubis-AlSwsSmVLrQ [this message]
2014-04-02 10:45         ` chrubis
2014-04-02 10:45         ` chrubis
2014-04-02 11:10   ` Christoph Hellwig
2014-04-02 11:10     ` Christoph Hellwig
2014-04-02 11:10     ` Christoph Hellwig
     [not found]     ` <20140402111032.GA27551-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-04-02 11:45       ` Steven Whitehouse
2014-04-02 11:45         ` Steven Whitehouse
2014-04-02 11:45         ` Steven Whitehouse
2014-04-02 23:44         ` Richard Hansen
2014-04-02 23:44           ` Richard Hansen
2014-04-02 23:44           ` Richard Hansen
2014-04-03  8:25           ` Michael Kerrisk (man-pages)
2014-04-03  8:25             ` Michael Kerrisk (man-pages)
2014-04-03 11:51             ` Christopher Covington
2014-04-03 11:51               ` Christopher Covington
2014-04-04  6:54               ` Michael Kerrisk (man-pages)
2014-04-04  6:54                 ` Michael Kerrisk (man-pages)
2014-04-04  6:54                 ` Michael Kerrisk (man-pages)
2014-04-03 12:57             ` Greg Troxel
2014-04-03 12:57               ` Greg Troxel
2014-04-04  7:11               ` Michael Kerrisk (man-pages)
2014-04-04  7:11                 ` Michael Kerrisk (man-pages)
2014-04-04  7:11                 ` Michael Kerrisk (man-pages)
2014-04-03 20:23             ` Richard Hansen
2014-04-03 20:23               ` Richard Hansen
2014-04-04  6:53               ` Christoph Hellwig
2014-04-04  6:53                 ` Christoph Hellwig
2014-04-04  7:12           ` [PATCH] mm: msync: require either MS_ASYNC or MS_SYNC [resend] Michael Kerrisk (man-pages)
2014-04-04  7:12             ` Michael Kerrisk (man-pages)
2014-04-04  7:12             ` Michael Kerrisk (man-pages)
2014-04-04 14:07             ` Peter Zijlstra
2014-04-04 14:07               ` Peter Zijlstra
  -- strict thread matches above, loose matches on Subject: below --
2013-09-01 19:58 [PATCH] mm: msync: require either MS_ASYNC or MS_SYNC Richard Hansen
2013-09-01 19:58 ` Richard Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140402104517.GA20656@rei \
    --to=chrubis-alswssmvlrq@public.gmane.org \
    --cc=gdt-2FjktZCtrC/QT0dZR+AlfA@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=rhansen-A08e6c8yq/Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.