From: Bjorn Helgaas <bhelgaas@google.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
Jingoo Han <jg1.han@samsung.com>,
Simon Horman <horms@verge.net.au>,
Shawn Guo <shawn.guo@linaro.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
kernel@pengutronix.de
Subject: Re: [PATCH v2 3/6] PCI: rcar: use new OF interrupt mapping when possible
Date: Fri, 4 Apr 2014 11:01:03 -0600 [thread overview]
Message-ID: <20140404170103.GF9007@google.com> (raw)
In-Reply-To: <1394025951-32438-4-git-send-email-l.stach@pengutronix.de>
On Wed, Mar 05, 2014 at 02:25:48PM +0100, Lucas Stach wrote:
> This is the recommended method of doing the IRQ
> mapping. Still fall back to the old method in order
> to not break the just submitted board files.
Hi Lucas, can you rebase this to Linus' current tree? This doesn't apply
anymore because of conflicts with 546cadda3575 ("PCI: rcar: Register each
instance independently"). Thanks!
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> v2: pass in parent device to pci_common_init(), to
> make DT parsing work.
> ---
> drivers/pci/host/pci-rcar-gen2.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c
> index ceec147baec3..3a0914163ad0 100644
> --- a/drivers/pci/host/pci-rcar-gen2.c
> +++ b/drivers/pci/host/pci-rcar-gen2.c
> @@ -15,6 +15,7 @@
> #include <linux/io.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/of_pci.h>
> #include <linux/pci.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> @@ -160,8 +161,13 @@ static int __init rcar_pci_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)
> {
> struct pci_sys_data *sys = dev->bus->sysdata;
> struct rcar_pci_priv *priv = sys->private_data;
> + int irq;
> +
> + irq = of_irq_parse_and_map_pci(dev, slot, pin);
> + if (!irq)
> + irq = priv->irq;
>
> - return priv->irq;
> + return irq;
> }
>
> /* PCI host controller setup */
> @@ -249,6 +255,8 @@ static int __init rcar_pci_add_controller(struct rcar_pci_priv *priv)
> void **private_data;
> int count;
>
> + pci_common_init_dev(priv->dev, &rcar_hw_pci);
> +
> if (rcar_hw_pci.nr_controllers < rcar_pci_count)
> goto add_priv;
>
> @@ -322,8 +330,6 @@ static int __init rcar_pci_init(void)
> int retval;
>
> retval = platform_driver_probe(&rcar_pci_driver, rcar_pci_probe);
> - if (!retval)
> - pci_common_init(&rcar_hw_pci);
>
> /* Private data pointer array is not needed any more */
> kfree(rcar_hw_pci.private_data);
> --
> 1.9.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
To: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCH v2 3/6] PCI: rcar: use new OF interrupt mapping when possible
Date: Fri, 4 Apr 2014 11:01:03 -0600 [thread overview]
Message-ID: <20140404170103.GF9007@google.com> (raw)
In-Reply-To: <1394025951-32438-4-git-send-email-l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Wed, Mar 05, 2014 at 02:25:48PM +0100, Lucas Stach wrote:
> This is the recommended method of doing the IRQ
> mapping. Still fall back to the old method in order
> to not break the just submitted board files.
Hi Lucas, can you rebase this to Linus' current tree? This doesn't apply
anymore because of conflicts with 546cadda3575 ("PCI: rcar: Register each
instance independently"). Thanks!
> Signed-off-by: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> ---
> v2: pass in parent device to pci_common_init(), to
> make DT parsing work.
> ---
> drivers/pci/host/pci-rcar-gen2.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c
> index ceec147baec3..3a0914163ad0 100644
> --- a/drivers/pci/host/pci-rcar-gen2.c
> +++ b/drivers/pci/host/pci-rcar-gen2.c
> @@ -15,6 +15,7 @@
> #include <linux/io.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/of_pci.h>
> #include <linux/pci.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> @@ -160,8 +161,13 @@ static int __init rcar_pci_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)
> {
> struct pci_sys_data *sys = dev->bus->sysdata;
> struct rcar_pci_priv *priv = sys->private_data;
> + int irq;
> +
> + irq = of_irq_parse_and_map_pci(dev, slot, pin);
> + if (!irq)
> + irq = priv->irq;
>
> - return priv->irq;
> + return irq;
> }
>
> /* PCI host controller setup */
> @@ -249,6 +255,8 @@ static int __init rcar_pci_add_controller(struct rcar_pci_priv *priv)
> void **private_data;
> int count;
>
> + pci_common_init_dev(priv->dev, &rcar_hw_pci);
> +
> if (rcar_hw_pci.nr_controllers < rcar_pci_count)
> goto add_priv;
>
> @@ -322,8 +330,6 @@ static int __init rcar_pci_init(void)
> int retval;
>
> retval = platform_driver_probe(&rcar_pci_driver, rcar_pci_probe);
> - if (!retval)
> - pci_common_init(&rcar_hw_pci);
>
> /* Private data pointer array is not needed any more */
> kfree(rcar_hw_pci.private_data);
> --
> 1.9.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <bhelgaas@google.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/6] PCI: rcar: use new OF interrupt mapping when possible
Date: Fri, 04 Apr 2014 17:01:03 +0000 [thread overview]
Message-ID: <20140404170103.GF9007@google.com> (raw)
In-Reply-To: <1394025951-32438-4-git-send-email-l.stach@pengutronix.de>
On Wed, Mar 05, 2014 at 02:25:48PM +0100, Lucas Stach wrote:
> This is the recommended method of doing the IRQ
> mapping. Still fall back to the old method in order
> to not break the just submitted board files.
Hi Lucas, can you rebase this to Linus' current tree? This doesn't apply
anymore because of conflicts with 546cadda3575 ("PCI: rcar: Register each
instance independently"). Thanks!
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> v2: pass in parent device to pci_common_init(), to
> make DT parsing work.
> ---
> drivers/pci/host/pci-rcar-gen2.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c
> index ceec147baec3..3a0914163ad0 100644
> --- a/drivers/pci/host/pci-rcar-gen2.c
> +++ b/drivers/pci/host/pci-rcar-gen2.c
> @@ -15,6 +15,7 @@
> #include <linux/io.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/of_pci.h>
> #include <linux/pci.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> @@ -160,8 +161,13 @@ static int __init rcar_pci_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)
> {
> struct pci_sys_data *sys = dev->bus->sysdata;
> struct rcar_pci_priv *priv = sys->private_data;
> + int irq;
> +
> + irq = of_irq_parse_and_map_pci(dev, slot, pin);
> + if (!irq)
> + irq = priv->irq;
>
> - return priv->irq;
> + return irq;
> }
>
> /* PCI host controller setup */
> @@ -249,6 +255,8 @@ static int __init rcar_pci_add_controller(struct rcar_pci_priv *priv)
> void **private_data;
> int count;
>
> + pci_common_init_dev(priv->dev, &rcar_hw_pci);
> +
> if (rcar_hw_pci.nr_controllers < rcar_pci_count)
> goto add_priv;
>
> @@ -322,8 +330,6 @@ static int __init rcar_pci_init(void)
> int retval;
>
> retval = platform_driver_probe(&rcar_pci_driver, rcar_pci_probe);
> - if (!retval)
> - pci_common_init(&rcar_hw_pci);
>
> /* Private data pointer array is not needed any more */
> kfree(rcar_hw_pci.private_data);
> --
> 1.9.0
>
WARNING: multiple messages have this Message-ID (diff)
From: bhelgaas@google.com (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/6] PCI: rcar: use new OF interrupt mapping when possible
Date: Fri, 4 Apr 2014 11:01:03 -0600 [thread overview]
Message-ID: <20140404170103.GF9007@google.com> (raw)
In-Reply-To: <1394025951-32438-4-git-send-email-l.stach@pengutronix.de>
On Wed, Mar 05, 2014 at 02:25:48PM +0100, Lucas Stach wrote:
> This is the recommended method of doing the IRQ
> mapping. Still fall back to the old method in order
> to not break the just submitted board files.
Hi Lucas, can you rebase this to Linus' current tree? This doesn't apply
anymore because of conflicts with 546cadda3575 ("PCI: rcar: Register each
instance independently"). Thanks!
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> v2: pass in parent device to pci_common_init(), to
> make DT parsing work.
> ---
> drivers/pci/host/pci-rcar-gen2.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c
> index ceec147baec3..3a0914163ad0 100644
> --- a/drivers/pci/host/pci-rcar-gen2.c
> +++ b/drivers/pci/host/pci-rcar-gen2.c
> @@ -15,6 +15,7 @@
> #include <linux/io.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/of_pci.h>
> #include <linux/pci.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> @@ -160,8 +161,13 @@ static int __init rcar_pci_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)
> {
> struct pci_sys_data *sys = dev->bus->sysdata;
> struct rcar_pci_priv *priv = sys->private_data;
> + int irq;
> +
> + irq = of_irq_parse_and_map_pci(dev, slot, pin);
> + if (!irq)
> + irq = priv->irq;
>
> - return priv->irq;
> + return irq;
> }
>
> /* PCI host controller setup */
> @@ -249,6 +255,8 @@ static int __init rcar_pci_add_controller(struct rcar_pci_priv *priv)
> void **private_data;
> int count;
>
> + pci_common_init_dev(priv->dev, &rcar_hw_pci);
> +
> if (rcar_hw_pci.nr_controllers < rcar_pci_count)
> goto add_priv;
>
> @@ -322,8 +330,6 @@ static int __init rcar_pci_init(void)
> int retval;
>
> retval = platform_driver_probe(&rcar_pci_driver, rcar_pci_probe);
> - if (!retval)
> - pci_common_init(&rcar_hw_pci);
>
> /* Private data pointer array is not needed any more */
> kfree(rcar_hw_pci.private_data);
> --
> 1.9.0
>
next prev parent reply other threads:[~2014-04-04 17:01 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 13:25 [PATCH v2 0/6] PCI irq mapping fixes and cleanups Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` [PATCH v2 1/6] ARM: dts: tegra: add PCIe interrupt mapping properties Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 21:55 ` Stephen Warren
2014-03-05 21:55 ` Stephen Warren
2014-03-05 21:55 ` Stephen Warren
2014-03-05 21:55 ` Stephen Warren
2014-03-06 9:33 ` Lucas Stach
2014-03-06 9:33 ` Lucas Stach
2014-03-06 9:33 ` Lucas Stach
2014-03-06 17:41 ` Stephen Warren
2014-03-06 17:41 ` Stephen Warren
2014-03-06 17:41 ` Stephen Warren
2014-03-05 13:25 ` [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-06 17:36 ` Stephen Warren
2014-03-06 17:36 ` Stephen Warren
2014-03-06 17:36 ` Stephen Warren
2014-03-06 17:39 ` Lucas Stach
2014-03-06 17:39 ` Lucas Stach
2014-03-06 17:39 ` Lucas Stach
2014-03-07 0:25 ` Arnd Bergmann
2014-03-07 0:25 ` Arnd Bergmann
2014-03-07 0:25 ` Arnd Bergmann
2014-03-07 0:25 ` Arnd Bergmann
2014-03-07 3:31 ` Jingoo Han
2014-03-07 3:31 ` Jingoo Han
2014-03-07 3:31 ` Jingoo Han
2014-04-11 17:40 ` Srikanth Thokala
2014-04-11 17:52 ` Srikanth Thokala
2014-04-11 17:40 ` Srikanth Thokala
2014-04-11 17:40 ` Srikanth Thokala
2014-04-11 20:41 ` Jason Gunthorpe
2014-04-11 20:41 ` Jason Gunthorpe
2014-04-11 20:41 ` Jason Gunthorpe
2014-04-14 10:56 ` Srikanth Thokala
2014-04-14 10:56 ` Srikanth Thokala
2014-04-14 10:56 ` Srikanth Thokala
2014-04-14 10:56 ` Srikanth Thokala
2014-04-04 16:55 ` Bjorn Helgaas
2014-04-04 16:55 ` Bjorn Helgaas
2014-04-04 16:55 ` Bjorn Helgaas
2014-04-15 10:07 ` Lucas Stach
2014-04-15 10:07 ` Lucas Stach
2014-04-15 10:07 ` Lucas Stach
2014-04-15 18:30 ` Bjorn Helgaas
2014-04-15 18:30 ` Bjorn Helgaas
2014-04-15 18:30 ` Bjorn Helgaas
2014-04-16 8:20 ` Lucas Stach
2014-04-16 8:20 ` Lucas Stach
2014-04-16 8:20 ` Lucas Stach
2014-04-16 16:29 ` Bjorn Helgaas
2014-04-16 16:29 ` Bjorn Helgaas
2014-04-16 16:29 ` Bjorn Helgaas
2014-03-05 13:25 ` [PATCH v2 3/6] PCI: rcar: " Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-06 4:12 ` Simon Horman
2014-03-06 4:12 ` Simon Horman
2014-03-06 4:12 ` Simon Horman
2014-04-04 17:01 ` Bjorn Helgaas [this message]
2014-04-04 17:01 ` Bjorn Helgaas
2014-04-04 17:01 ` Bjorn Helgaas
2014-04-04 17:01 ` Bjorn Helgaas
2014-04-07 9:30 ` [PATCH v2 rebased] " Lucas Stach
2014-04-07 9:30 ` Lucas Stach
2014-04-07 9:30 ` Lucas Stach
2014-03-05 13:25 ` [PATCH v2 4/6] ARM: dts: exynos5440: fix PCIe interrupt mapping Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-06 2:38 ` Jingoo Han
2014-03-06 2:38 ` Jingoo Han
2014-03-06 2:38 ` Jingoo Han
2014-03-05 13:25 ` [PATCH v2 5/6] ARM: dts: imx6: add PCIe interrupt mapping properties Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-10 3:09 ` Shawn Guo
2014-03-10 3:09 ` Shawn Guo
2014-03-10 3:09 ` Shawn Guo
2014-03-10 3:09 ` Shawn Guo
2014-03-05 13:25 ` [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 18:42 ` Jason Gunthorpe
2014-03-05 18:42 ` Jason Gunthorpe
2014-03-05 18:42 ` Jason Gunthorpe
2014-04-04 17:03 ` Bjorn Helgaas
2014-04-04 17:03 ` Bjorn Helgaas
2014-04-04 17:03 ` Bjorn Helgaas
2014-04-04 17:05 ` Bjorn Helgaas
2014-04-04 17:05 ` Bjorn Helgaas
2014-04-04 17:05 ` Bjorn Helgaas
2014-04-04 17:05 ` Bjorn Helgaas
2014-04-07 8:38 ` Lucas Stach
2014-04-07 8:38 ` Lucas Stach
2014-04-07 8:38 ` Lucas Stach
2014-04-07 9:13 ` Jingoo Han
2014-04-07 9:13 ` Jingoo Han
2014-04-07 9:13 ` Jingoo Han
2014-03-06 2:47 ` Jingoo Han
2014-03-06 2:47 ` Jingoo Han
2014-03-06 2:47 ` Jingoo Han
2014-03-06 15:33 ` Marek Vasut
2014-03-06 15:33 ` Marek Vasut
2014-03-06 15:33 ` Marek Vasut
2014-03-06 15:33 ` Marek Vasut
2014-03-13 17:41 ` Tim Harvey
2014-03-13 17:41 ` Tim Harvey
2014-03-13 17:41 ` Tim Harvey
2014-03-13 17:41 ` Tim Harvey
2014-03-28 15:47 ` [PATCH v2 0/6] PCI irq mapping fixes and cleanups Lucas Stach
2014-03-28 15:47 ` Lucas Stach
2014-03-28 15:47 ` Lucas Stach
2014-03-28 15:47 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404170103.GF9007@google.com \
--to=bhelgaas@google.com \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=jg1.han@samsung.com \
--cc=kernel@pengutronix.de \
--cc=kgene.kim@samsung.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.