From: Bjorn Helgaas <bhelgaas@google.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Lucas Stach <l.stach@pengutronix.de>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Stephen Warren <swarren@wwwdotorg.org>,
linux-sh@vger.kernel.org, linux-pci@vger.kernel.org,
Jingoo Han <jg1.han@samsung.com>,
Simon Horman <horms@verge.net.au>,
Thierry Reding <thierry.reding@gmail.com>,
Ben Dooks <ben-linux@fluff.org>,
linux-tegra@vger.kernel.org, Kukjin Kim <kgene.kim@samsung.com>,
Shawn Guo <shawn.guo@linaro.org>,
kernel@pengutronix.de
Subject: Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible
Date: Fri, 4 Apr 2014 11:03:41 -0600 [thread overview]
Message-ID: <20140404170341.GG9007@google.com> (raw)
In-Reply-To: <20140305184219.GA29903@obsidianresearch.com>
On Wed, Mar 05, 2014 at 11:42:19AM -0700, Jason Gunthorpe wrote:
> On Wed, Mar 05, 2014 at 02:25:51PM +0100, Lucas Stach wrote:
> > - return pp->irq;
> > + irq = of_irq_parse_and_map_pci(dev, slot, pin);
> > + if (!irq)
> > + irq = pp->irq;
>
> In light of the two bugs that Tim found, it might be wise to throw a
> 'dev_warn(FW_BUG "Missing DT interrupt mapping")' in the fall back
> path, so it doesn't continue to silently cover up errors on the OF/DT
> side..
This sounds like a reasonable thing to do, but I didn't see a response to
this comment. Should I merge it as-is, or do you want to add the message?
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <bhelgaas@google.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible
Date: Fri, 04 Apr 2014 17:03:41 +0000 [thread overview]
Message-ID: <20140404170341.GG9007@google.com> (raw)
In-Reply-To: <20140305184219.GA29903@obsidianresearch.com>
On Wed, Mar 05, 2014 at 11:42:19AM -0700, Jason Gunthorpe wrote:
> On Wed, Mar 05, 2014 at 02:25:51PM +0100, Lucas Stach wrote:
> > - return pp->irq;
> > + irq = of_irq_parse_and_map_pci(dev, slot, pin);
> > + if (!irq)
> > + irq = pp->irq;
>
> In light of the two bugs that Tim found, it might be wise to throw a
> 'dev_warn(FW_BUG "Missing DT interrupt mapping")' in the fall back
> path, so it doesn't continue to silently cover up errors on the OF/DT
> side..
This sounds like a reasonable thing to do, but I didn't see a response to
this comment. Should I merge it as-is, or do you want to add the message?
WARNING: multiple messages have this Message-ID (diff)
From: bhelgaas@google.com (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible
Date: Fri, 4 Apr 2014 11:03:41 -0600 [thread overview]
Message-ID: <20140404170341.GG9007@google.com> (raw)
In-Reply-To: <20140305184219.GA29903@obsidianresearch.com>
On Wed, Mar 05, 2014 at 11:42:19AM -0700, Jason Gunthorpe wrote:
> On Wed, Mar 05, 2014 at 02:25:51PM +0100, Lucas Stach wrote:
> > - return pp->irq;
> > + irq = of_irq_parse_and_map_pci(dev, slot, pin);
> > + if (!irq)
> > + irq = pp->irq;
>
> In light of the two bugs that Tim found, it might be wise to throw a
> 'dev_warn(FW_BUG "Missing DT interrupt mapping")' in the fall back
> path, so it doesn't continue to silently cover up errors on the OF/DT
> side..
This sounds like a reasonable thing to do, but I didn't see a response to
this comment. Should I merge it as-is, or do you want to add the message?
next prev parent reply other threads:[~2014-04-04 17:03 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 13:25 [PATCH v2 0/6] PCI irq mapping fixes and cleanups Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` [PATCH v2 1/6] ARM: dts: tegra: add PCIe interrupt mapping properties Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 21:55 ` Stephen Warren
2014-03-05 21:55 ` Stephen Warren
2014-03-05 21:55 ` Stephen Warren
2014-03-05 21:55 ` Stephen Warren
2014-03-06 9:33 ` Lucas Stach
2014-03-06 9:33 ` Lucas Stach
2014-03-06 9:33 ` Lucas Stach
2014-03-06 17:41 ` Stephen Warren
2014-03-06 17:41 ` Stephen Warren
2014-03-06 17:41 ` Stephen Warren
2014-03-05 13:25 ` [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-06 17:36 ` Stephen Warren
2014-03-06 17:36 ` Stephen Warren
2014-03-06 17:36 ` Stephen Warren
2014-03-06 17:39 ` Lucas Stach
2014-03-06 17:39 ` Lucas Stach
2014-03-06 17:39 ` Lucas Stach
2014-03-07 0:25 ` Arnd Bergmann
2014-03-07 0:25 ` Arnd Bergmann
2014-03-07 0:25 ` Arnd Bergmann
2014-03-07 0:25 ` Arnd Bergmann
2014-03-07 3:31 ` Jingoo Han
2014-03-07 3:31 ` Jingoo Han
2014-03-07 3:31 ` Jingoo Han
2014-04-11 17:40 ` Srikanth Thokala
2014-04-11 17:52 ` Srikanth Thokala
2014-04-11 17:40 ` Srikanth Thokala
2014-04-11 17:40 ` Srikanth Thokala
2014-04-11 20:41 ` Jason Gunthorpe
2014-04-11 20:41 ` Jason Gunthorpe
2014-04-11 20:41 ` Jason Gunthorpe
2014-04-14 10:56 ` Srikanth Thokala
2014-04-14 10:56 ` Srikanth Thokala
2014-04-14 10:56 ` Srikanth Thokala
2014-04-14 10:56 ` Srikanth Thokala
2014-04-04 16:55 ` Bjorn Helgaas
2014-04-04 16:55 ` Bjorn Helgaas
2014-04-04 16:55 ` Bjorn Helgaas
2014-04-15 10:07 ` Lucas Stach
2014-04-15 10:07 ` Lucas Stach
2014-04-15 10:07 ` Lucas Stach
2014-04-15 18:30 ` Bjorn Helgaas
2014-04-15 18:30 ` Bjorn Helgaas
2014-04-15 18:30 ` Bjorn Helgaas
2014-04-16 8:20 ` Lucas Stach
2014-04-16 8:20 ` Lucas Stach
2014-04-16 8:20 ` Lucas Stach
2014-04-16 16:29 ` Bjorn Helgaas
2014-04-16 16:29 ` Bjorn Helgaas
2014-04-16 16:29 ` Bjorn Helgaas
2014-03-05 13:25 ` [PATCH v2 3/6] PCI: rcar: " Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-06 4:12 ` Simon Horman
2014-03-06 4:12 ` Simon Horman
2014-03-06 4:12 ` Simon Horman
2014-04-04 17:01 ` Bjorn Helgaas
2014-04-04 17:01 ` Bjorn Helgaas
2014-04-04 17:01 ` Bjorn Helgaas
2014-04-04 17:01 ` Bjorn Helgaas
2014-04-07 9:30 ` [PATCH v2 rebased] " Lucas Stach
2014-04-07 9:30 ` Lucas Stach
2014-04-07 9:30 ` Lucas Stach
2014-03-05 13:25 ` [PATCH v2 4/6] ARM: dts: exynos5440: fix PCIe interrupt mapping Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-06 2:38 ` Jingoo Han
2014-03-06 2:38 ` Jingoo Han
2014-03-06 2:38 ` Jingoo Han
2014-03-05 13:25 ` [PATCH v2 5/6] ARM: dts: imx6: add PCIe interrupt mapping properties Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-10 3:09 ` Shawn Guo
2014-03-10 3:09 ` Shawn Guo
2014-03-10 3:09 ` Shawn Guo
2014-03-10 3:09 ` Shawn Guo
2014-03-05 13:25 ` [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 18:42 ` Jason Gunthorpe
2014-03-05 18:42 ` Jason Gunthorpe
2014-03-05 18:42 ` Jason Gunthorpe
2014-04-04 17:03 ` Bjorn Helgaas [this message]
2014-04-04 17:03 ` Bjorn Helgaas
2014-04-04 17:03 ` Bjorn Helgaas
2014-04-04 17:05 ` Bjorn Helgaas
2014-04-04 17:05 ` Bjorn Helgaas
2014-04-04 17:05 ` Bjorn Helgaas
2014-04-04 17:05 ` Bjorn Helgaas
2014-04-07 8:38 ` Lucas Stach
2014-04-07 8:38 ` Lucas Stach
2014-04-07 8:38 ` Lucas Stach
2014-04-07 9:13 ` Jingoo Han
2014-04-07 9:13 ` Jingoo Han
2014-04-07 9:13 ` Jingoo Han
2014-03-06 2:47 ` Jingoo Han
2014-03-06 2:47 ` Jingoo Han
2014-03-06 2:47 ` Jingoo Han
2014-03-06 15:33 ` Marek Vasut
2014-03-06 15:33 ` Marek Vasut
2014-03-06 15:33 ` Marek Vasut
2014-03-06 15:33 ` Marek Vasut
2014-03-13 17:41 ` Tim Harvey
2014-03-13 17:41 ` Tim Harvey
2014-03-13 17:41 ` Tim Harvey
2014-03-13 17:41 ` Tim Harvey
2014-03-28 15:47 ` [PATCH v2 0/6] PCI irq mapping fixes and cleanups Lucas Stach
2014-03-28 15:47 ` Lucas Stach
2014-03-28 15:47 ` Lucas Stach
2014-03-28 15:47 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404170341.GG9007@google.com \
--to=bhelgaas@google.com \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=jg1.han@samsung.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kernel@pengutronix.de \
--cc=kgene.kim@samsung.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.