From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Srikanth Thokala <sriku.linux@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>,
Tanmay Inamdar <tinamdar@apm.com>,
devicetree@vger.kernel.org, Jingoo Han <jg1.han@samsung.com>,
linux-samsung-soc@vger.kernel.org, kernel@pengutronix.de,
Arnd Bergmann <arnd@arndb.de>,
linux-sh@vger.kernel.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Simon Horman <horms@verge.net.au>,
Thierry Reding <thierry.reding@gmail.com>,
Ben Dooks <ben-linux@fluff.org>,
linux-tegra@vger.kernel.org, Kukjin Kim <kgene.kim@samsung.com>,
Shawn Guo <shawn.guo@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible
Date: Fri, 11 Apr 2014 14:41:41 -0600 [thread overview]
Message-ID: <20140411204140.GA8967@obsidianresearch.com> (raw)
In-Reply-To: <CA+mB=1JCjDMzTuctvSQgjNhBnkyUPC2ooAzJOX_PC5L1gAau8w@mail.gmail.com>
On Fri, Apr 11, 2014 at 11:10:59PM +0530, Srikanth Thokala wrote:
> I see this error too on my setup (Xilinx PCIe Root Complex Driver),
> https://lkml.org/lkml/2014/3/3/183
> After digging into it, I see I need to override the API
> pcibios_get_phb_of_node()
No, as I pointed out before, the DT node comes in through
pci_scan_root_bus:
+static struct pci_bus __init *xilinx_pcie_scan_bus(int nr,
+ struct pci_sys_data *sys)
+{
+ struct xilinx_pcie_port *port = sys_to_pcie(sys);
+ struct pci_bus *bus;
+
+ if (port) {
+ port->root_busno = sys->busnr;
+ bus = pci_scan_root_bus(NULL, sys->busnr, &xilinx_pcie_ops,
^^^^^^
You can't pass NULL here and have DT work properly.
See http://www.spinics.net/lists/arm-kernel/msg312392.html
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible
Date: Fri, 11 Apr 2014 20:41:41 +0000 [thread overview]
Message-ID: <20140411204140.GA8967@obsidianresearch.com> (raw)
In-Reply-To: <CA+mB=1JCjDMzTuctvSQgjNhBnkyUPC2ooAzJOX_PC5L1gAau8w@mail.gmail.com>
On Fri, Apr 11, 2014 at 11:10:59PM +0530, Srikanth Thokala wrote:
> I see this error too on my setup (Xilinx PCIe Root Complex Driver),
> https://lkml.org/lkml/2014/3/3/183
> After digging into it, I see I need to override the API
> pcibios_get_phb_of_node()
No, as I pointed out before, the DT node comes in through
pci_scan_root_bus:
+static struct pci_bus __init *xilinx_pcie_scan_bus(int nr,
+ struct pci_sys_data *sys)
+{
+ struct xilinx_pcie_port *port = sys_to_pcie(sys);
+ struct pci_bus *bus;
+
+ if (port) {
+ port->root_busno = sys->busnr;
+ bus = pci_scan_root_bus(NULL, sys->busnr, &xilinx_pcie_ops,
^^^^^^
You can't pass NULL here and have DT work properly.
See http://www.spinics.net/lists/arm-kernel/msg312392.html
Jason
WARNING: multiple messages have this Message-ID (diff)
From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible
Date: Fri, 11 Apr 2014 14:41:41 -0600 [thread overview]
Message-ID: <20140411204140.GA8967@obsidianresearch.com> (raw)
In-Reply-To: <CA+mB=1JCjDMzTuctvSQgjNhBnkyUPC2ooAzJOX_PC5L1gAau8w@mail.gmail.com>
On Fri, Apr 11, 2014 at 11:10:59PM +0530, Srikanth Thokala wrote:
> I see this error too on my setup (Xilinx PCIe Root Complex Driver),
> https://lkml.org/lkml/2014/3/3/183
> After digging into it, I see I need to override the API
> pcibios_get_phb_of_node()
No, as I pointed out before, the DT node comes in through
pci_scan_root_bus:
+static struct pci_bus __init *xilinx_pcie_scan_bus(int nr,
+ struct pci_sys_data *sys)
+{
+ struct xilinx_pcie_port *port = sys_to_pcie(sys);
+ struct pci_bus *bus;
+
+ if (port) {
+ port->root_busno = sys->busnr;
+ bus = pci_scan_root_bus(NULL, sys->busnr, &xilinx_pcie_ops,
^^^^^^
You can't pass NULL here and have DT work properly.
See http://www.spinics.net/lists/arm-kernel/msg312392.html
Jason
next prev parent reply other threads:[~2014-04-11 20:42 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 13:25 [PATCH v2 0/6] PCI irq mapping fixes and cleanups Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` [PATCH v2 1/6] ARM: dts: tegra: add PCIe interrupt mapping properties Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 21:55 ` Stephen Warren
2014-03-05 21:55 ` Stephen Warren
2014-03-05 21:55 ` Stephen Warren
2014-03-05 21:55 ` Stephen Warren
2014-03-06 9:33 ` Lucas Stach
2014-03-06 9:33 ` Lucas Stach
2014-03-06 9:33 ` Lucas Stach
2014-03-06 17:41 ` Stephen Warren
2014-03-06 17:41 ` Stephen Warren
2014-03-06 17:41 ` Stephen Warren
2014-03-05 13:25 ` [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-06 17:36 ` Stephen Warren
2014-03-06 17:36 ` Stephen Warren
2014-03-06 17:36 ` Stephen Warren
2014-03-06 17:39 ` Lucas Stach
2014-03-06 17:39 ` Lucas Stach
2014-03-06 17:39 ` Lucas Stach
2014-03-07 0:25 ` Arnd Bergmann
2014-03-07 0:25 ` Arnd Bergmann
2014-03-07 0:25 ` Arnd Bergmann
2014-03-07 0:25 ` Arnd Bergmann
2014-03-07 3:31 ` Jingoo Han
2014-03-07 3:31 ` Jingoo Han
2014-03-07 3:31 ` Jingoo Han
2014-04-11 17:40 ` Srikanth Thokala
2014-04-11 17:52 ` Srikanth Thokala
2014-04-11 17:40 ` Srikanth Thokala
2014-04-11 17:40 ` Srikanth Thokala
2014-04-11 20:41 ` Jason Gunthorpe [this message]
2014-04-11 20:41 ` Jason Gunthorpe
2014-04-11 20:41 ` Jason Gunthorpe
2014-04-14 10:56 ` Srikanth Thokala
2014-04-14 10:56 ` Srikanth Thokala
2014-04-14 10:56 ` Srikanth Thokala
2014-04-14 10:56 ` Srikanth Thokala
2014-04-04 16:55 ` Bjorn Helgaas
2014-04-04 16:55 ` Bjorn Helgaas
2014-04-04 16:55 ` Bjorn Helgaas
2014-04-15 10:07 ` Lucas Stach
2014-04-15 10:07 ` Lucas Stach
2014-04-15 10:07 ` Lucas Stach
2014-04-15 18:30 ` Bjorn Helgaas
2014-04-15 18:30 ` Bjorn Helgaas
2014-04-15 18:30 ` Bjorn Helgaas
2014-04-16 8:20 ` Lucas Stach
2014-04-16 8:20 ` Lucas Stach
2014-04-16 8:20 ` Lucas Stach
2014-04-16 16:29 ` Bjorn Helgaas
2014-04-16 16:29 ` Bjorn Helgaas
2014-04-16 16:29 ` Bjorn Helgaas
2014-03-05 13:25 ` [PATCH v2 3/6] PCI: rcar: " Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-06 4:12 ` Simon Horman
2014-03-06 4:12 ` Simon Horman
2014-03-06 4:12 ` Simon Horman
2014-04-04 17:01 ` Bjorn Helgaas
2014-04-04 17:01 ` Bjorn Helgaas
2014-04-04 17:01 ` Bjorn Helgaas
2014-04-04 17:01 ` Bjorn Helgaas
2014-04-07 9:30 ` [PATCH v2 rebased] " Lucas Stach
2014-04-07 9:30 ` Lucas Stach
2014-04-07 9:30 ` Lucas Stach
2014-03-05 13:25 ` [PATCH v2 4/6] ARM: dts: exynos5440: fix PCIe interrupt mapping Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-06 2:38 ` Jingoo Han
2014-03-06 2:38 ` Jingoo Han
2014-03-06 2:38 ` Jingoo Han
2014-03-05 13:25 ` [PATCH v2 5/6] ARM: dts: imx6: add PCIe interrupt mapping properties Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-10 3:09 ` Shawn Guo
2014-03-10 3:09 ` Shawn Guo
2014-03-10 3:09 ` Shawn Guo
2014-03-10 3:09 ` Shawn Guo
2014-03-05 13:25 ` [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 13:25 ` Lucas Stach
2014-03-05 18:42 ` Jason Gunthorpe
2014-03-05 18:42 ` Jason Gunthorpe
2014-03-05 18:42 ` Jason Gunthorpe
2014-04-04 17:03 ` Bjorn Helgaas
2014-04-04 17:03 ` Bjorn Helgaas
2014-04-04 17:03 ` Bjorn Helgaas
2014-04-04 17:05 ` Bjorn Helgaas
2014-04-04 17:05 ` Bjorn Helgaas
2014-04-04 17:05 ` Bjorn Helgaas
2014-04-04 17:05 ` Bjorn Helgaas
2014-04-07 8:38 ` Lucas Stach
2014-04-07 8:38 ` Lucas Stach
2014-04-07 8:38 ` Lucas Stach
2014-04-07 9:13 ` Jingoo Han
2014-04-07 9:13 ` Jingoo Han
2014-04-07 9:13 ` Jingoo Han
2014-03-06 2:47 ` Jingoo Han
2014-03-06 2:47 ` Jingoo Han
2014-03-06 2:47 ` Jingoo Han
2014-03-06 15:33 ` Marek Vasut
2014-03-06 15:33 ` Marek Vasut
2014-03-06 15:33 ` Marek Vasut
2014-03-06 15:33 ` Marek Vasut
2014-03-13 17:41 ` Tim Harvey
2014-03-13 17:41 ` Tim Harvey
2014-03-13 17:41 ` Tim Harvey
2014-03-13 17:41 ` Tim Harvey
2014-03-28 15:47 ` [PATCH v2 0/6] PCI irq mapping fixes and cleanups Lucas Stach
2014-03-28 15:47 ` Lucas Stach
2014-03-28 15:47 ` Lucas Stach
2014-03-28 15:47 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140411204140.GA8967@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=jg1.han@samsung.com \
--cc=kernel@pengutronix.de \
--cc=kgene.kim@samsung.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=sriku.linux@gmail.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.