All of lore.kernel.org
 help / color / mirror / Atom feed
From: peterz@infradead.org (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/5] sched: rework of sched_domain topology definition
Date: Fri, 18 Apr 2014 12:56:01 +0200	[thread overview]
Message-ID: <20140418105601.GU11182@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1397209481-28542-2-git-send-email-vincent.guittot@linaro.org>

On Fri, Apr 11, 2014 at 11:44:37AM +0200, Vincent Guittot wrote:
> We replace the old way to configure the scheduler topology with a new method
> which enables a platform to declare additionnal level (if needed).
> 
> We still have a default topology table definition that can be used by platform
> that don't want more level than the SMT, MC, CPU and NUMA ones. This table can
> be overwritten by an arch which either wants to add new level where a load
> balance make sense like BOOK or powergating level or wants to change the flags
> configuration of some levels.
> 
> For each level, we need a function pointer that returns cpumask for each cpu,
> a function pointer that returns the flags for the level and a name. Only flags
> that describe topology, can be set by an architecture. The current topology
> flags are:
>  SD_SHARE_CPUPOWER
>  SD_SHARE_PKG_RESOURCES
>  SD_NUMA
>  SD_ASYM_PACKING
> 
> Then, each level must be a subset on the next one. The build sequence of the
> sched_domain will take care of removing useless levels like those with 1 CPU
> and those with the same CPU span and no more relevant information for
> load balancing than its childs.
> 
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> Reviewed-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>

On x86_64 defconfig this gets me:

kernel/sched/core.c: In function 'sched_init_numa':
kernel/sched/core.c:6197:4: warning: initialization makes pointer from integer without a cast [enabled by default]
kernel/sched/core.c:6197:4: warning: (near initialization for '(anonymous).sd_flags') [enabled by default]

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
	tony.luck@intel.com, fenghua.yu@intel.com,
	schwidefsky@de.ibm.com, cmetcalf@tilera.com,
	benh@kernel.crashing.org, linux@arm.linux.org.uk,
	linux-arm-kernel@lists.infradead.org, dietmar.eggemann@arm.com,
	preeti@linux.vnet.ibm.com, linaro-kernel@lists.linaro.org
Subject: Re: [PATCH v4 1/5] sched: rework of sched_domain topology definition
Date: Fri, 18 Apr 2014 12:56:01 +0200	[thread overview]
Message-ID: <20140418105601.GU11182@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1397209481-28542-2-git-send-email-vincent.guittot@linaro.org>

On Fri, Apr 11, 2014 at 11:44:37AM +0200, Vincent Guittot wrote:
> We replace the old way to configure the scheduler topology with a new method
> which enables a platform to declare additionnal level (if needed).
> 
> We still have a default topology table definition that can be used by platform
> that don't want more level than the SMT, MC, CPU and NUMA ones. This table can
> be overwritten by an arch which either wants to add new level where a load
> balance make sense like BOOK or powergating level or wants to change the flags
> configuration of some levels.
> 
> For each level, we need a function pointer that returns cpumask for each cpu,
> a function pointer that returns the flags for the level and a name. Only flags
> that describe topology, can be set by an architecture. The current topology
> flags are:
>  SD_SHARE_CPUPOWER
>  SD_SHARE_PKG_RESOURCES
>  SD_NUMA
>  SD_ASYM_PACKING
> 
> Then, each level must be a subset on the next one. The build sequence of the
> sched_domain will take care of removing useless levels like those with 1 CPU
> and those with the same CPU span and no more relevant information for
> load balancing than its childs.
> 
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> Reviewed-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>

On x86_64 defconfig this gets me:

kernel/sched/core.c: In function 'sched_init_numa':
kernel/sched/core.c:6197:4: warning: initialization makes pointer from integer without a cast [enabled by default]
kernel/sched/core.c:6197:4: warning: (near initialization for '(anonymous).sd_flags') [enabled by default]


  reply	other threads:[~2014-04-18 10:56 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-11  9:44 [PATCH v4 0/5] rework sched_domain topology description Vincent Guittot
2014-04-11  9:44 ` Vincent Guittot
2014-04-11  9:44 ` [PATCH v4 1/5] sched: rework of sched_domain topology definition Vincent Guittot
2014-04-11  9:44   ` Vincent Guittot
2014-04-18 10:56   ` Peter Zijlstra [this message]
2014-04-18 10:56     ` Peter Zijlstra
2014-04-18 11:34     ` [PATCH] fix: " Vincent Guittot
2014-04-18 11:34       ` Vincent Guittot
2014-04-18 11:39       ` Peter Zijlstra
2014-04-18 11:39         ` Peter Zijlstra
2014-04-18 11:34     ` [PATCH v4 1/5] " Vincent Guittot
2014-04-18 11:34       ` Vincent Guittot
2014-05-08 10:43   ` [tip:sched/core] sched: Rework " tip-bot for Vincent Guittot
2014-05-16  9:57     ` James Hogan
2014-05-18  8:04       ` Vincent Guittot
2014-05-18  8:04         ` Vincent Guittot
2014-04-11  9:44 ` [PATCH v4 2/5] sched: s390: create a dedicated topology table Vincent Guittot
2014-04-11  9:44   ` Vincent Guittot
2014-05-08 10:43   ` [tip:sched/core] sched, s390: Create " tip-bot for Vincent Guittot
2014-04-11  9:44 ` [PATCH v4 3/5] sched: powerpc: create " Vincent Guittot
2014-04-11  9:44   ` Vincent Guittot
2014-05-08 10:43   ` [tip:sched/core] sched, powerpc: Create " tip-bot for Vincent Guittot
2014-04-11  9:44 ` [PATCH v4 4/5] sched: add a new SD_SHARE_POWERDOMAIN for sched_domain Vincent Guittot
2014-04-11  9:44   ` Vincent Guittot
2014-04-18 10:58   ` Peter Zijlstra
2014-04-18 10:58     ` Peter Zijlstra
2014-04-18 11:54     ` [PATCH] fix: sched: rework of sched_domain topology definition Vincent Guittot
2014-04-18 11:54       ` Vincent Guittot
2014-04-18 11:54     ` [PATCH v4 4/5] sched: add a new SD_SHARE_POWERDOMAIN for sched_domain Vincent Guittot
2014-04-18 11:54       ` Vincent Guittot
2014-05-08 10:44   ` [tip:sched/core] sched: Add " tip-bot for Vincent Guittot
2014-04-11  9:44 ` [PATCH v4 5/5] sched: ARM: create a dedicated scheduler topology table Vincent Guittot
2014-04-11  9:44   ` Vincent Guittot
2014-04-23 11:46   ` Dietmar Eggemann
2014-04-23 11:46     ` Dietmar Eggemann
2014-04-23 14:46     ` Vincent Guittot
2014-04-23 14:46       ` Vincent Guittot
2014-04-23 15:26       ` Dietmar Eggemann
2014-04-23 15:26         ` Dietmar Eggemann
2014-04-24  7:30         ` Vincent Guittot
2014-04-24  7:30           ` Vincent Guittot
2014-04-24 12:48           ` Dietmar Eggemann
2014-04-24 12:48             ` Dietmar Eggemann
2014-04-25  7:45             ` Vincent Guittot
2014-04-25  7:45               ` Vincent Guittot
2014-04-25 15:55               ` Dietmar Eggemann
2014-04-25 15:55                 ` Dietmar Eggemann
2014-04-25 16:04               ` Peter Zijlstra
2014-04-25 16:04                 ` Peter Zijlstra
2014-04-25 16:05                 ` Peter Zijlstra
2014-04-25 16:05                   ` Peter Zijlstra
2014-05-08 10:44   ` [tip:sched/core] sched, ARM: Create " tip-bot for Vincent Guittot
2014-04-12 12:56 ` [PATCH v4 0/5] rework sched_domain topology description Dietmar Eggemann
2014-04-12 12:56   ` Dietmar Eggemann
2014-04-14  7:29   ` Vincent Guittot
2014-04-14  7:29     ` Vincent Guittot
2014-04-15  7:53   ` Peter Zijlstra
2014-04-15  7:53     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140418105601.GU11182@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.