All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Michal Simek <monstr@monstr.eu>
Cc: Christopher Covington <cov@codeaurora.org>,
	Nicolas Pitre <nicolas.pitre@linaro.org>,
	Peter Maydell <peter.maydell@linaro.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Joel Fernandes <joelf@ti.com>,
	linux-arm-msm@vger.kernel.org,
	Stephen Boyd <sboyd@codeaurora.org>,
	Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [Qemu-devel] Change of TEXT_OFFSET for multi_v7_defconfig
Date: Tue, 22 Apr 2014 11:00:19 -0600	[thread overview]
Message-ID: <20140422170019.GA23955@obsidianresearch.com> (raw)
In-Reply-To: <535681A4.1080402@monstr.eu>

> > index 8756e4b..551e971 100644
> > +++ b/arch/arm/include/asm/memory.h
> > @@ -350,7 +350,7 @@ static inline __deprecated void *bus_to_virt(unsigned long x)
> >  #define virt_addr_valid(kaddr)	(((unsigned long)(kaddr) >= PAGE_OFFSET && (unsigned long)(kaddr) < (unsigned long)high_memory) \
> >  					&& pfn_valid(__pa(kaddr) >> PAGE_SHIFT) )
> >  
> > -#endif
> > +#endif /* __ASSEMBLY__ */

> This is unrelated change.

Right, as I said it needs some cleanup :) This is left overs from
rebasing to 3.14 - the original had to carry some small changes to
memory.h as well, but now that we have PLAT_PHYS_OFFSET that isn't
necessary.
 
> > @@ -43,7 +50,7 @@
> >  #endif
> >  
> >  OUTPUT_ARCH(arm)
> > -ENTRY(stext)
> > +ENTRY(phys_start)
> >  
> >  #ifndef __ARMEB__
> >  jiffies = jiffies_64;
> > @@ -86,11 +93,13 @@ SECTIONS
> >  #else
> >  	. = PAGE_OFFSET + TEXT_OFFSET;
> >  #endif
> > -	.head.text : {
> > +	.head.text : AT(ADDR(.head.text) - LOAD_OFFSET) {
> >  		_text = .;
> > +		phys_start = . - LOAD_OFFSET;
> >  		HEAD_TEXT
> >  	}
> 
> I am not quite about these changes above but Russell can comment it.

This is adjusting the entry point address in the ELF.

I have copied what other arch's are doing and used the physical
address as the entry address (see x86, ia64).

Jason

WARNING: multiple messages have this Message-ID (diff)
From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe)
To: linux-arm-kernel@lists.infradead.org
Subject: [Qemu-devel] Change of TEXT_OFFSET for multi_v7_defconfig
Date: Tue, 22 Apr 2014 11:00:19 -0600	[thread overview]
Message-ID: <20140422170019.GA23955@obsidianresearch.com> (raw)
In-Reply-To: <535681A4.1080402@monstr.eu>

> > index 8756e4b..551e971 100644
> > +++ b/arch/arm/include/asm/memory.h
> > @@ -350,7 +350,7 @@ static inline __deprecated void *bus_to_virt(unsigned long x)
> >  #define virt_addr_valid(kaddr)	(((unsigned long)(kaddr) >= PAGE_OFFSET && (unsigned long)(kaddr) < (unsigned long)high_memory) \
> >  					&& pfn_valid(__pa(kaddr) >> PAGE_SHIFT) )
> >  
> > -#endif
> > +#endif /* __ASSEMBLY__ */

> This is unrelated change.

Right, as I said it needs some cleanup :) This is left overs from
rebasing to 3.14 - the original had to carry some small changes to
memory.h as well, but now that we have PLAT_PHYS_OFFSET that isn't
necessary.
 
> > @@ -43,7 +50,7 @@
> >  #endif
> >  
> >  OUTPUT_ARCH(arm)
> > -ENTRY(stext)
> > +ENTRY(phys_start)
> >  
> >  #ifndef __ARMEB__
> >  jiffies = jiffies_64;
> > @@ -86,11 +93,13 @@ SECTIONS
> >  #else
> >  	. = PAGE_OFFSET + TEXT_OFFSET;
> >  #endif
> > -	.head.text : {
> > +	.head.text : AT(ADDR(.head.text) - LOAD_OFFSET) {
> >  		_text = .;
> > +		phys_start = . - LOAD_OFFSET;
> >  		HEAD_TEXT
> >  	}
> 
> I am not quite about these changes above but Russell can comment it.

This is adjusting the entry point address in the ELF.

I have copied what other arch's are doing and used the physical
address as the entry address (see x86, ia64).

Jason

  reply	other threads:[~2014-04-22 17:00 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15 10:44 Change of TEXT_OFFSET for multi_v7_defconfig Daniel Thompson
2014-04-15 10:44 ` Daniel Thompson
2014-04-15 17:53 ` Stephen Boyd
2014-04-15 17:53   ` Stephen Boyd
2014-04-16 16:18 ` Christopher Covington
2014-04-16 16:18   ` Christopher Covington
2014-04-16 19:14   ` Nicolas Pitre
2014-04-16 19:14     ` Nicolas Pitre
2014-04-16 21:08     ` Christopher Covington
2014-04-16 21:08       ` Christopher Covington
2014-04-16 21:36       ` Peter Maydell
2014-04-16 21:36         ` Peter Maydell
2014-04-16 22:34         ` Russell King - ARM Linux
2014-04-16 22:34           ` Russell King - ARM Linux
2014-04-16 22:33       ` Russell King - ARM Linux
2014-04-16 22:33         ` Russell King - ARM Linux
2014-04-16 23:21       ` Nicolas Pitre
2014-04-16 23:21         ` Nicolas Pitre
2014-04-17 18:33         ` Christopher Covington
2014-04-17 18:33           ` Christopher Covington
2014-04-17 19:48           ` Nicolas Pitre
2014-04-17 19:48             ` Nicolas Pitre
2014-04-17 20:49             ` Christopher Covington
2014-04-17 20:49               ` Christopher Covington
2014-04-17 20:54               ` Peter Maydell
2014-04-17 20:54                 ` Peter Maydell
2014-04-17 20:35           ` Jason Gunthorpe
2014-04-17 20:35             ` Jason Gunthorpe
2014-04-22  9:44             ` Daniel Thompson
2014-04-22  9:44               ` Daniel Thompson
2014-04-22 17:05               ` Jason Gunthorpe
2014-04-22 17:05                 ` Jason Gunthorpe
2014-04-22 17:55                 ` Nicolas Pitre
2014-04-22 17:55                   ` Nicolas Pitre
2014-04-22 18:36                   ` Russell King - ARM Linux
2014-04-22 18:36                     ` Russell King - ARM Linux
2014-04-22 14:50             ` Michal Simek
2014-04-22 14:50               ` [Qemu-devel] " Michal Simek
2014-04-22 17:00               ` Jason Gunthorpe [this message]
2014-04-22 17:00                 ` Jason Gunthorpe
2014-04-22 17:11               ` Russell King - ARM Linux
2014-04-22 17:11                 ` Russell King - ARM Linux
2014-04-22 17:53                 ` Jason Gunthorpe
2014-04-22 17:53                   ` Jason Gunthorpe
2014-04-22 18:12                   ` Russell King - ARM Linux
2014-04-22 18:12                     ` Russell King - ARM Linux
2014-04-22 18:32                   ` Arnd Bergmann
2014-04-22 18:32                     ` Arnd Bergmann
2014-04-22 18:38                     ` Russell King - ARM Linux
2014-04-22 18:38                       ` Russell King - ARM Linux
2014-04-22 18:45                       ` Arnd Bergmann
2014-04-22 18:45                         ` Arnd Bergmann
2014-04-17 17:11     ` Rob Herring
2014-04-17 17:11       ` Rob Herring
2014-04-17 20:06       ` Nicolas Pitre
2014-04-17 20:06         ` Nicolas Pitre
2014-04-17 20:16         ` Russell King - ARM Linux
2014-04-17 20:16           ` Russell King - ARM Linux
2014-04-17 21:18           ` Rob Herring
2014-04-17 21:18             ` Rob Herring
2014-04-17 21:35             ` Russell King - ARM Linux
2014-04-17 21:35               ` Russell King - ARM Linux
2014-04-18  2:53               ` Rob Herring
2014-04-18  2:53                 ` Rob Herring
2014-04-18  4:34                 ` Nicolas Pitre
2014-04-18  4:34                   ` Nicolas Pitre
2014-04-22 10:26                   ` Daniel Thompson
2014-04-22 10:26                     ` Daniel Thompson
2014-04-22 10:40                     ` Russell King - ARM Linux
2014-04-22 10:40                       ` Russell King - ARM Linux
2014-04-22 11:41                       ` Daniel Thompson
2014-04-22 11:41                         ` Daniel Thompson
2014-04-18  8:41                 ` Russell King - ARM Linux
2014-04-18  8:41                   ` Russell King - ARM Linux
2014-04-22  9:53               ` Daniel Thompson
2014-04-22  9:53                 ` Daniel Thompson
2014-04-22 10:07                 ` Russell King - ARM Linux
2014-04-22 10:07                   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140422170019.GA23955@obsidianresearch.com \
    --to=jgunthorpe@obsidianresearch.com \
    --cc=cov@codeaurora.org \
    --cc=daniel.thompson@linaro.org \
    --cc=joelf@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=monstr@monstr.eu \
    --cc=nicolas.pitre@linaro.org \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.