From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Vasily Averin <vvs@parallels.com>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>,
Patrick McHardy <kaber@trash.net>,
Saikiran Madugula <hummerbliss@gmail.com>
Subject: Re: [PATCH] bridge: Superfluous skb->nfct check in br_nf_dev_queue_xmit
Date: Wed, 30 Apr 2014 12:02:28 +0200 [thread overview]
Message-ID: <20140430100228.GR31953@breakpoint.cc> (raw)
In-Reply-To: <20140430093905.GA4318@localhost>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Wed, Apr 30, 2014 at 12:54:50PM +0400, Vasily Averin wrote:
> > Currently bridge can silently drop ipv4 fragments.
> > If node have loaded nf_defrag_ipv4 module but have no nf_conntrack_ipv4,
> > br_nf_pre_routing defragments incoming ipv4 fragments
> > but nfct check in br_nf_dev_queue_xmit does not allow re-fragment combined packet back,
> > and therefore it is dropped in br_dev_queue_push_xmit without incrementing of any failcounters
>
> Patrick already mentioned that bridges should not defragment unless
> conntrack is enabled.
>
> Please, see: http://marc.info/?l=netfilter-devel&m=139878065822267&w=2
>
> I think we have to consider some alternative way to fix what you
> report.
Could you explain how br_nf_dev_queue_xmit could encouter
an IP packet that doesn't fit link MTU without netfilter
defrag?
Because I do not see any way of this happening, all bridge
ports must have the same MTU?
next prev parent reply other threads:[~2014-04-30 10:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 11:15 [Bridge] [PATCH 1/1] superfluous skb->nfct check in br_nf_dev_queue_xmit Vasily Averin
2014-04-20 5:33 ` Vasily Averin
2014-04-20 5:33 ` Vasily Averin
2014-04-24 16:32 ` Florian Westphal
2014-04-24 17:05 ` [Bridge] " Florian Westphal
2014-04-28 12:37 ` Vasily Averin
2014-04-28 12:37 ` Vasily Averin
2014-04-28 13:16 ` Florian Westphal
2014-04-28 13:16 ` [Bridge] " Florian Westphal
2014-04-28 14:25 ` Vasily Averin
2014-04-28 14:25 ` Vasily Averin
2014-04-28 14:32 ` [Bridge] " Pablo Neira Ayuso
2014-04-28 14:32 ` Pablo Neira Ayuso
2014-04-30 9:06 ` [Bridge] " Vasily Averin
2014-04-30 9:06 ` Vasily Averin
2014-04-30 8:54 ` [PATCH] bridge: Superfluous " Vasily Averin
2014-04-30 9:39 ` Pablo Neira Ayuso
2014-04-30 10:02 ` Florian Westphal [this message]
2014-05-04 12:54 ` Pablo Neira Ayuso
2014-05-04 19:04 ` Vasily Averin
2014-05-04 19:25 ` Pablo Neira Ayuso
2014-05-04 20:17 ` [PATCH v2] bridge: superfluous " Vasily Averin
2014-05-05 14:07 ` Pablo Neira Ayuso
2014-04-29 14:10 ` [PATCH 1/1] " Patrick McHardy
2014-04-29 14:17 ` [Bridge] " Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140430100228.GR31953@breakpoint.cc \
--to=fw@strlen.de \
--cc=hummerbliss@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=stephen@networkplumber.org \
--cc=vvs@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.