From: Florian Westphal <fw@strlen.de>
To: Vasily Averin <vvs@parallels.com>
Cc: bridge@lists.linux-foundation.org,
Patrick McHardy <kaber@trash.net>,
Stephen Hemminger <stephen@networkplumber.org>,
netfilter-devel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH 1/1] superfluous skb->nfct check in br_nf_dev_queue_xmit
Date: Thu, 24 Apr 2014 17:05:36 -0000 [thread overview]
Message-ID: <20140424163243.GN31953@breakpoint.cc> (raw)
In-Reply-To: <53535C35.7070108@parallels.com>
Vasily Averin <vvs@parallels.com> wrote:
> Please do not apply my patch, probably it breaks processing of VLAN packets.
Why would it break VLAN?
In fact, the same dicussion came up couple of days back and I think the
nfct test is wrong. There is no guarantee that skb->nfct == NULL means
that packet was not defragmented via nf_defrag (e.g. rror in l4 protocol
tracker, nf_defrag_ipv4 loaded but no nf_conntrack_ipv4)
For ipv6 its even worse since we toss all ipv6 defragmented packets...
WARNING: multiple messages have this Message-ID (diff)
From: Florian Westphal <fw@strlen.de>
To: Vasily Averin <vvs@parallels.com>
Cc: Patrick McHardy <kaber@trash.net>,
bridge@lists.linux-foundation.org,
Stephen Hemminger <stephen@networkplumber.org>,
Saikiran Madugula <hummerbliss@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/1] superfluous skb->nfct check in br_nf_dev_queue_xmit
Date: Thu, 24 Apr 2014 18:32:43 +0200 [thread overview]
Message-ID: <20140424163243.GN31953@breakpoint.cc> (raw)
In-Reply-To: <53535C35.7070108@parallels.com>
Vasily Averin <vvs@parallels.com> wrote:
> Please do not apply my patch, probably it breaks processing of VLAN packets.
Why would it break VLAN?
In fact, the same dicussion came up couple of days back and I think the
nfct test is wrong. There is no guarantee that skb->nfct == NULL means
that packet was not defragmented via nf_defrag (e.g. rror in l4 protocol
tracker, nf_defrag_ipv4 loaded but no nf_conntrack_ipv4)
For ipv6 its even worse since we toss all ipv6 defragmented packets...
next prev parent reply other threads:[~2014-04-24 17:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 11:15 [Bridge] [PATCH 1/1] superfluous skb->nfct check in br_nf_dev_queue_xmit Vasily Averin
2014-04-20 5:33 ` Vasily Averin
2014-04-20 5:33 ` Vasily Averin
2014-04-24 16:32 ` Florian Westphal [this message]
2014-04-24 17:05 ` [Bridge] " Florian Westphal
2014-04-28 12:37 ` Vasily Averin
2014-04-28 12:37 ` Vasily Averin
2014-04-28 13:16 ` Florian Westphal
2014-04-28 13:16 ` [Bridge] " Florian Westphal
2014-04-28 14:25 ` Vasily Averin
2014-04-28 14:25 ` Vasily Averin
2014-04-28 14:32 ` [Bridge] " Pablo Neira Ayuso
2014-04-28 14:32 ` Pablo Neira Ayuso
2014-04-30 9:06 ` [Bridge] " Vasily Averin
2014-04-30 9:06 ` Vasily Averin
2014-04-30 8:54 ` [PATCH] bridge: Superfluous " Vasily Averin
2014-04-30 9:39 ` Pablo Neira Ayuso
2014-04-30 10:02 ` Florian Westphal
2014-05-04 12:54 ` Pablo Neira Ayuso
2014-05-04 19:04 ` Vasily Averin
2014-05-04 19:25 ` Pablo Neira Ayuso
2014-05-04 20:17 ` [PATCH v2] bridge: superfluous " Vasily Averin
2014-05-05 14:07 ` Pablo Neira Ayuso
2014-04-29 14:10 ` [PATCH 1/1] " Patrick McHardy
2014-04-29 14:17 ` [Bridge] " Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424163243.GN31953@breakpoint.cc \
--to=fw@strlen.de \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vvs@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.