* [PATCH] MIPS: Kconfig: microMIPS and SmartMIPS are mutually exclusive
@ 2014-06-03 8:46 ` Markos Chandras
0 siblings, 0 replies; 13+ messages in thread
From: Markos Chandras @ 2014-06-03 8:46 UTC (permalink / raw)
To: linux-mips; +Cc: Markos Chandras
Fixes the following build problem on randconfig:
Warning: the 32-bit microMIPS architecture does not support the `smartmips'
extension
arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24'
[...]
arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24'
Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021
Reviewed-by: Steven J. Hill <Steven.Hill@imgtec.com>
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
arch/mips/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 2fe8e60..ffde3d6 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2063,7 +2063,7 @@ config ARCH_PHYS_ADDR_T_64BIT
def_bool 64BIT_PHYS_ADDR
config CPU_HAS_SMARTMIPS
- depends on SYS_SUPPORTS_SMARTMIPS
+ depends on SYS_SUPPORTS_SMARTMIPS && !CPU_MICROMIPS
bool "Support for the SmartMIPS ASE"
help
SmartMIPS is a extension of the MIPS32 architecture aimed at
--
1.9.3
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH] MIPS: Kconfig: microMIPS and SmartMIPS are mutually exclusive
@ 2014-06-03 8:46 ` Markos Chandras
0 siblings, 0 replies; 13+ messages in thread
From: Markos Chandras @ 2014-06-03 8:46 UTC (permalink / raw)
To: linux-mips; +Cc: Markos Chandras
Fixes the following build problem on randconfig:
Warning: the 32-bit microMIPS architecture does not support the `smartmips'
extension
arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24'
[...]
arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24'
Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021
Reviewed-by: Steven J. Hill <Steven.Hill@imgtec.com>
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
arch/mips/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 2fe8e60..ffde3d6 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2063,7 +2063,7 @@ config ARCH_PHYS_ADDR_T_64BIT
def_bool 64BIT_PHYS_ADDR
config CPU_HAS_SMARTMIPS
- depends on SYS_SUPPORTS_SMARTMIPS
+ depends on SYS_SUPPORTS_SMARTMIPS && !CPU_MICROMIPS
bool "Support for the SmartMIPS ASE"
help
SmartMIPS is a extension of the MIPS32 architecture aimed at
--
1.9.3
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH] MIPS: Kconfig: microMIPS and SmartMIPS are mutually exclusive
@ 2014-06-03 9:34 ` Ralf Baechle
0 siblings, 0 replies; 13+ messages in thread
From: Ralf Baechle @ 2014-06-03 9:34 UTC (permalink / raw)
To: Markos Chandras; +Cc: linux-mips
On Tue, Jun 03, 2014 at 09:46:17AM +0100, Markos Chandras wrote:
> Warning: the 32-bit microMIPS architecture does not support the `smartmips'
> extension
> arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24'
> [...]
> arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24'
>
> Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021
> Reviewed-by: Steven J. Hill <Steven.Hill@imgtec.com>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
> arch/mips/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 2fe8e60..ffde3d6 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2063,7 +2063,7 @@ config ARCH_PHYS_ADDR_T_64BIT
> def_bool 64BIT_PHYS_ADDR
>
> config CPU_HAS_SMARTMIPS
> - depends on SYS_SUPPORTS_SMARTMIPS
> + depends on SYS_SUPPORTS_SMARTMIPS && !CPU_MICROMIPS
> bool "Support for the SmartMIPS ASE"
> help
> SmartMIPS is a extension of the MIPS32 architecture aimed at
From a user's perspective that's a bit quirky; a user has to first
disable CPU_MICROMIPS before he can enable CPU_HAS_SMARTMIPS. So I
think this should become a choice statement.
Ralf
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] MIPS: Kconfig: microMIPS and SmartMIPS are mutually exclusive
@ 2014-06-03 9:34 ` Ralf Baechle
0 siblings, 0 replies; 13+ messages in thread
From: Ralf Baechle @ 2014-06-03 9:34 UTC (permalink / raw)
To: Markos Chandras; +Cc: linux-mips
On Tue, Jun 03, 2014 at 09:46:17AM +0100, Markos Chandras wrote:
> Warning: the 32-bit microMIPS architecture does not support the `smartmips'
> extension
> arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24'
> [...]
> arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24'
>
> Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021
> Reviewed-by: Steven J. Hill <Steven.Hill@imgtec.com>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
> arch/mips/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 2fe8e60..ffde3d6 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2063,7 +2063,7 @@ config ARCH_PHYS_ADDR_T_64BIT
> def_bool 64BIT_PHYS_ADDR
>
> config CPU_HAS_SMARTMIPS
> - depends on SYS_SUPPORTS_SMARTMIPS
> + depends on SYS_SUPPORTS_SMARTMIPS && !CPU_MICROMIPS
> bool "Support for the SmartMIPS ASE"
> help
> SmartMIPS is a extension of the MIPS32 architecture aimed at
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] MIPS: Kconfig: microMIPS and SmartMIPS are mutually exclusive
@ 2014-06-03 9:45 ` Markos Chandras
0 siblings, 0 replies; 13+ messages in thread
From: Markos Chandras @ 2014-06-03 9:45 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, James Hogan
On 06/03/2014 10:34 AM, Ralf Baechle wrote:
> On Tue, Jun 03, 2014 at 09:46:17AM +0100, Markos Chandras wrote:
>
>> Warning: the 32-bit microMIPS architecture does not support the `smartmips'
>> extension
>> arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24'
>> [...]
>> arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24'
>>
>> Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021
>> Reviewed-by: Steven J. Hill <Steven.Hill@imgtec.com>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> ---
>> arch/mips/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
>> index 2fe8e60..ffde3d6 100644
>> --- a/arch/mips/Kconfig
>> +++ b/arch/mips/Kconfig
>> @@ -2063,7 +2063,7 @@ config ARCH_PHYS_ADDR_T_64BIT
>> def_bool 64BIT_PHYS_ADDR
>>
>> config CPU_HAS_SMARTMIPS
>> - depends on SYS_SUPPORTS_SMARTMIPS
>> + depends on SYS_SUPPORTS_SMARTMIPS && !CPU_MICROMIPS
>> bool "Support for the SmartMIPS ASE"
>> help
>> SmartMIPS is a extension of the MIPS32 architecture aimed at
>
> From a user's perspective that's a bit quirky; a user has to first
> disable CPU_MICROMIPS before he can enable CPU_HAS_SMARTMIPS. So I
> think this should become a choice statement.
>
> Ralf
>
James (now on CC) suggested the same thing and I told him that choice
statements make sense for symbols that are somehow related. For example
SMVP or SMTC or no-MT. In this case, these symbols totally different so
in my opinion a choice symbol will be rather confusing. But I will not
object. Whatever works best.
--
markos
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] MIPS: Kconfig: microMIPS and SmartMIPS are mutually exclusive
@ 2014-06-03 9:45 ` Markos Chandras
0 siblings, 0 replies; 13+ messages in thread
From: Markos Chandras @ 2014-06-03 9:45 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, James Hogan
On 06/03/2014 10:34 AM, Ralf Baechle wrote:
> On Tue, Jun 03, 2014 at 09:46:17AM +0100, Markos Chandras wrote:
>
>> Warning: the 32-bit microMIPS architecture does not support the `smartmips'
>> extension
>> arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24'
>> [...]
>> arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24'
>>
>> Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021
>> Reviewed-by: Steven J. Hill <Steven.Hill@imgtec.com>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> ---
>> arch/mips/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
>> index 2fe8e60..ffde3d6 100644
>> --- a/arch/mips/Kconfig
>> +++ b/arch/mips/Kconfig
>> @@ -2063,7 +2063,7 @@ config ARCH_PHYS_ADDR_T_64BIT
>> def_bool 64BIT_PHYS_ADDR
>>
>> config CPU_HAS_SMARTMIPS
>> - depends on SYS_SUPPORTS_SMARTMIPS
>> + depends on SYS_SUPPORTS_SMARTMIPS && !CPU_MICROMIPS
>> bool "Support for the SmartMIPS ASE"
>> help
>> SmartMIPS is a extension of the MIPS32 architecture aimed at
>
> From a user's perspective that's a bit quirky; a user has to first
> disable CPU_MICROMIPS before he can enable CPU_HAS_SMARTMIPS. So I
> think this should become a choice statement.
>
> Ralf
>
James (now on CC) suggested the same thing and I told him that choice
statements make sense for symbols that are somehow related. For example
SMVP or SMTC or no-MT. In this case, these symbols totally different so
in my opinion a choice symbol will be rather confusing. But I will not
object. Whatever works best.
--
markos
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] MIPS: Kconfig: microMIPS and SmartMIPS are mutually exclusive
2014-06-03 9:34 ` Ralf Baechle
(?)
(?)
@ 2014-06-03 11:18 ` Maciej W. Rozycki
2014-06-03 12:24 ` Ralf Baechle
-1 siblings, 1 reply; 13+ messages in thread
From: Maciej W. Rozycki @ 2014-06-03 11:18 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Markos Chandras, linux-mips
On Tue, 3 Jun 2014, Ralf Baechle wrote:
> > Warning: the 32-bit microMIPS architecture does not support the `smartmips'
> > extension
> > arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24'
> > [...]
> > arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24'
> >
> > Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021
> > Reviewed-by: Steven J. Hill <Steven.Hill@imgtec.com>
> > Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> > ---
> > arch/mips/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > index 2fe8e60..ffde3d6 100644
> > --- a/arch/mips/Kconfig
> > +++ b/arch/mips/Kconfig
> > @@ -2063,7 +2063,7 @@ config ARCH_PHYS_ADDR_T_64BIT
> > def_bool 64BIT_PHYS_ADDR
> >
> > config CPU_HAS_SMARTMIPS
> > - depends on SYS_SUPPORTS_SMARTMIPS
> > + depends on SYS_SUPPORTS_SMARTMIPS && !CPU_MICROMIPS
> > bool "Support for the SmartMIPS ASE"
> > help
> > SmartMIPS is a extension of the MIPS32 architecture aimed at
>
> >From a user's perspective that's a bit quirky; a user has to first
> disable CPU_MICROMIPS before he can enable CPU_HAS_SMARTMIPS. So I
> think this should become a choice statement.
Do we need this CPU_HAS_SMARTMIPS setting at all? Can't we just
save/restore this SmartMIPS ACX register on context switches where
available (straightforward to detect at the run time) and have the
relevant pieces of code excluded (#ifdef-ed out or suchlike) on
non-supported configurations such as microMIPS or MIPS64?
Maciej
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] MIPS: Kconfig: microMIPS and SmartMIPS are mutually exclusive
2014-06-03 11:18 ` Maciej W. Rozycki
@ 2014-06-03 12:24 ` Ralf Baechle
2014-06-03 13:56 ` Maciej W. Rozycki
0 siblings, 1 reply; 13+ messages in thread
From: Ralf Baechle @ 2014-06-03 12:24 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: Markos Chandras, linux-mips
On Tue, Jun 03, 2014 at 12:18:43PM +0100, Maciej W. Rozycki wrote:
> Do we need this CPU_HAS_SMARTMIPS setting at all? Can't we just
> save/restore this SmartMIPS ACX register on context switches where
> available (straightforward to detect at the run time) and have the
> relevant pieces of code excluded (#ifdef-ed out or suchlike) on
> non-supported configurations such as microMIPS or MIPS64?
SmartMIPS has new instructions which are hardcoded in various assembler
fragments, where something like if (cpu_has_smartmips) won't work.
So until a more complex solution is implemented CPU_HAS_SMARTMIPS is
what there is.
Ralf
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] MIPS: Kconfig: microMIPS and SmartMIPS are mutually exclusive
2014-06-03 12:24 ` Ralf Baechle
@ 2014-06-03 13:56 ` Maciej W. Rozycki
0 siblings, 0 replies; 13+ messages in thread
From: Maciej W. Rozycki @ 2014-06-03 13:56 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Markos Chandras, linux-mips
On Tue, 3 Jun 2014, Ralf Baechle wrote:
> > Do we need this CPU_HAS_SMARTMIPS setting at all? Can't we just
> > save/restore this SmartMIPS ACX register on context switches where
> > available (straightforward to detect at the run time) and have the
> > relevant pieces of code excluded (#ifdef-ed out or suchlike) on
> > non-supported configurations such as microMIPS or MIPS64?
>
> SmartMIPS has new instructions which are hardcoded in various assembler
> fragments, where something like if (cpu_has_smartmips) won't work.
> So until a more complex solution is implemented CPU_HAS_SMARTMIPS is
> what there is.
Well:
.set push
.set smartmips
# Whatever SmartMIPS stuff.
.set pop
should do. It has been supported by GAS since forever (well, since it has
included SmartMIPS instructions that is, which is 2.18; to support older
versions we can use $(call as-instr,...) and some #ifdef-ry that we have
anyway). It's <asm/stackframe.h> only BTW for six instructions total.
So I think that is straightforward to implement and much more reasonable
than the hacks we have now. A SmartMIPS-enabled kernel doesn't even check
if the CPU it's run on implements the ASE so it'll just crash at some
point trying to execute MFLHXU or MTLHX if it does not -- and obviously if
two SmartMIPS user programs are run concurrently on a SmartMIPS-disabled
kernel and use the ACX register, then they will yield random results.
Maciej
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] MIPS: Kconfig: Add choice symbol to select microMIPS or SmartMIPS
@ 2014-07-21 7:46 ` Markos Chandras
0 siblings, 0 replies; 13+ messages in thread
From: Markos Chandras @ 2014-07-21 7:46 UTC (permalink / raw)
To: linux-mips; +Cc: Markos Chandras
microMIPS and SmartMIPS can't be used together. This fixes the
following build problem:
Warning: the 32-bit microMIPS architecture does not support the `smartmips'
extension
arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24'
[...]
arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24'
Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
Hi Ralf,
Here is v2 of that patch, making SmartMIPS and microMIPS a
choice symbol as you requested in
http://www.linux-mips.org/archives/linux-mips/2014-06/msg00011.html
However, I still feel this is wrong since these two ASEs are completely
unrelated. The v1 of the patch is probably better in my opinion.
If the user fails to find the 'smartmips' option due to having 'micromips'
enabled, he/she can always search for the 'smartmips' symbol in the
menuconfig and he/she will notice the dependency on !micromips.
And if the user knows what he is doing he will probably never want to
use 'smartmips' and 'micromips' together.
---
arch/mips/Kconfig | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 4e238e6e661c..f30a43a52a09 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2090,9 +2090,17 @@ config 64BIT_PHYS_ADDR
config ARCH_PHYS_ADDR_T_64BIT
def_bool 64BIT_PHYS_ADDR
+choice
+ prompt "SmartMIPS or microMIPS ASE support"
+
+config CPU_NEEDS_NO_SMARTMIPS_OR_MICROMIPS
+ bool "None"
+ help
+ Select this if you want neither microMIPS nor SmartMIPS support
+
config CPU_HAS_SMARTMIPS
depends on SYS_SUPPORTS_SMARTMIPS
- bool "Support for the SmartMIPS ASE"
+ bool "SmartMIPS"
help
SmartMIPS is a extension of the MIPS32 architecture aimed at
increased security at both hardware and software level for
@@ -2104,11 +2112,13 @@ config CPU_HAS_SMARTMIPS
config CPU_MICROMIPS
depends on SYS_SUPPORTS_MICROMIPS
- bool "Build kernel using microMIPS ISA"
+ bool "microMIPS"
help
When this option is enabled the kernel will be built using the
microMIPS ISA
+endchoice
+
config CPU_HAS_MSA
bool "Support for the MIPS SIMD Architecture"
depends on CPU_SUPPORTS_MSA
--
2.0.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2] MIPS: Kconfig: Add choice symbol to select microMIPS or SmartMIPS
@ 2014-07-21 7:46 ` Markos Chandras
0 siblings, 0 replies; 13+ messages in thread
From: Markos Chandras @ 2014-07-21 7:46 UTC (permalink / raw)
To: linux-mips; +Cc: Markos Chandras
microMIPS and SmartMIPS can't be used together. This fixes the
following build problem:
Warning: the 32-bit microMIPS architecture does not support the `smartmips'
extension
arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24'
[...]
arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24'
Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
Hi Ralf,
Here is v2 of that patch, making SmartMIPS and microMIPS a
choice symbol as you requested in
http://www.linux-mips.org/archives/linux-mips/2014-06/msg00011.html
However, I still feel this is wrong since these two ASEs are completely
unrelated. The v1 of the patch is probably better in my opinion.
If the user fails to find the 'smartmips' option due to having 'micromips'
enabled, he/she can always search for the 'smartmips' symbol in the
menuconfig and he/she will notice the dependency on !micromips.
And if the user knows what he is doing he will probably never want to
use 'smartmips' and 'micromips' together.
---
arch/mips/Kconfig | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 4e238e6e661c..f30a43a52a09 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2090,9 +2090,17 @@ config 64BIT_PHYS_ADDR
config ARCH_PHYS_ADDR_T_64BIT
def_bool 64BIT_PHYS_ADDR
+choice
+ prompt "SmartMIPS or microMIPS ASE support"
+
+config CPU_NEEDS_NO_SMARTMIPS_OR_MICROMIPS
+ bool "None"
+ help
+ Select this if you want neither microMIPS nor SmartMIPS support
+
config CPU_HAS_SMARTMIPS
depends on SYS_SUPPORTS_SMARTMIPS
- bool "Support for the SmartMIPS ASE"
+ bool "SmartMIPS"
help
SmartMIPS is a extension of the MIPS32 architecture aimed at
increased security at both hardware and software level for
@@ -2104,11 +2112,13 @@ config CPU_HAS_SMARTMIPS
config CPU_MICROMIPS
depends on SYS_SUPPORTS_MICROMIPS
- bool "Build kernel using microMIPS ISA"
+ bool "microMIPS"
help
When this option is enabled the kernel will be built using the
microMIPS ISA
+endchoice
+
config CPU_HAS_MSA
bool "Support for the MIPS SIMD Architecture"
depends on CPU_SUPPORTS_MSA
--
2.0.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v2] MIPS: Kconfig: Add choice symbol to select microMIPS or SmartMIPS
@ 2014-10-08 13:28 ` Markos Chandras
0 siblings, 0 replies; 13+ messages in thread
From: Markos Chandras @ 2014-10-08 13:28 UTC (permalink / raw)
To: linux-mips
On 07/21/2014 08:46 AM, Markos Chandras wrote:
> microMIPS and SmartMIPS can't be used together. This fixes the
> following build problem:
>
> Warning: the 32-bit microMIPS architecture does not support the `smartmips'
> extension
> arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24'
> [...]
> arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24'
>
> Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
> Hi Ralf,
>
> Here is v2 of that patch, making SmartMIPS and microMIPS a
> choice symbol as you requested in
> http://www.linux-mips.org/archives/linux-mips/2014-06/msg00011.html
>
> However, I still feel this is wrong since these two ASEs are completely
> unrelated. The v1 of the patch is probably better in my opinion.
> If the user fails to find the 'smartmips' option due to having 'micromips'
> enabled, he/she can always search for the 'smartmips' symbol in the
> menuconfig and he/she will notice the dependency on !micromips.
> And if the user knows what he is doing he will probably never want to
> use 'smartmips' and 'micromips' together.
> ---
>
Hi,
Any comments on that one?
--
markos
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] MIPS: Kconfig: Add choice symbol to select microMIPS or SmartMIPS
@ 2014-10-08 13:28 ` Markos Chandras
0 siblings, 0 replies; 13+ messages in thread
From: Markos Chandras @ 2014-10-08 13:28 UTC (permalink / raw)
To: linux-mips
On 07/21/2014 08:46 AM, Markos Chandras wrote:
> microMIPS and SmartMIPS can't be used together. This fixes the
> following build problem:
>
> Warning: the 32-bit microMIPS architecture does not support the `smartmips'
> extension
> arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24'
> [...]
> arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24'
>
> Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
> Hi Ralf,
>
> Here is v2 of that patch, making SmartMIPS and microMIPS a
> choice symbol as you requested in
> http://www.linux-mips.org/archives/linux-mips/2014-06/msg00011.html
>
> However, I still feel this is wrong since these two ASEs are completely
> unrelated. The v1 of the patch is probably better in my opinion.
> If the user fails to find the 'smartmips' option due to having 'micromips'
> enabled, he/she can always search for the 'smartmips' symbol in the
> menuconfig and he/she will notice the dependency on !micromips.
> And if the user knows what he is doing he will probably never want to
> use 'smartmips' and 'micromips' together.
> ---
>
Hi,
Any comments on that one?
--
markos
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2014-10-08 13:28 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-03 8:46 [PATCH] MIPS: Kconfig: microMIPS and SmartMIPS are mutually exclusive Markos Chandras
2014-06-03 8:46 ` Markos Chandras
2014-06-03 9:34 ` Ralf Baechle
2014-06-03 9:34 ` Ralf Baechle
2014-06-03 9:45 ` Markos Chandras
2014-06-03 9:45 ` Markos Chandras
2014-06-03 11:18 ` Maciej W. Rozycki
2014-06-03 12:24 ` Ralf Baechle
2014-06-03 13:56 ` Maciej W. Rozycki
2014-07-21 7:46 ` [PATCH v2] MIPS: Kconfig: Add choice symbol to select microMIPS or SmartMIPS Markos Chandras
2014-07-21 7:46 ` Markos Chandras
2014-10-08 13:28 ` Markos Chandras
2014-10-08 13:28 ` Markos Chandras
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.