From: Tony Lindgren <tony@atomide.com>
To: Nick Krause <xerofoify@gmail.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: FIX ME in function ocpi_enable in file arch/arm/mach-omap1/opci.c
Date: Tue, 1 Jul 2014 23:55:32 -0700 [thread overview]
Message-ID: <20140702065531.GS28884@atomide.com> (raw)
In-Reply-To: <CAPDOMVgP83G4-znp=9kB-pBrfd2MUK+xvw1-_cRMXqi9P8hrww@mail.gmail.com>
* Nick Krause <xerofoify@gmail.com> [140701 15:51]:
> Hey Tony and Russel ,
> There is a FIX ME message in this function of the file stated in my
> subject line.
> I was wondering what locking is needed here due to not having experience with
> omap subsystem(s).
Looks like the locking for ocpi_enable would be needed if
it was called from multiple drivers. We are just enabling all
access, so no locking neeed for the current usage.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: FIX ME in function ocpi_enable in file arch/arm/mach-omap1/opci.c
Date: Tue, 1 Jul 2014 23:55:32 -0700 [thread overview]
Message-ID: <20140702065531.GS28884@atomide.com> (raw)
In-Reply-To: <CAPDOMVgP83G4-znp=9kB-pBrfd2MUK+xvw1-_cRMXqi9P8hrww@mail.gmail.com>
* Nick Krause <xerofoify@gmail.com> [140701 15:51]:
> Hey Tony and Russel ,
> There is a FIX ME message in this function of the file stated in my
> subject line.
> I was wondering what locking is needed here due to not having experience with
> omap subsystem(s).
Looks like the locking for ocpi_enable would be needed if
it was called from multiple drivers. We are just enabling all
access, so no locking neeed for the current usage.
Regards,
Tony
next prev parent reply other threads:[~2014-07-02 6:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 22:49 FIX ME in function ocpi_enable in file arch/arm/mach-omap1/opci.c Nick Krause
2014-07-01 22:49 ` Nick Krause
2014-07-02 6:55 ` Tony Lindgren [this message]
2014-07-02 6:55 ` Tony Lindgren
2014-07-03 1:04 ` Nick Krause
2014-07-03 1:04 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702065531.GS28884@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.