* FIX ME in function ocpi_enable in file arch/arm/mach-omap1/opci.c
@ 2014-07-01 22:49 ` Nick Krause
0 siblings, 0 replies; 6+ messages in thread
From: Nick Krause @ 2014-07-01 22:49 UTC (permalink / raw)
To: tony
Cc: Russell King - ARM Linux, linux-arm-kernel, linux-omap,
linux-kernel@vger.kernel.org
Hey Tony and Russel ,
There is a FIX ME message in this function of the file stated in my
subject line.
I was wondering what locking is needed here due to not having experience with
omap subsystem(s).
Cheers Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
* FIX ME in function ocpi_enable in file arch/arm/mach-omap1/opci.c
@ 2014-07-01 22:49 ` Nick Krause
0 siblings, 0 replies; 6+ messages in thread
From: Nick Krause @ 2014-07-01 22:49 UTC (permalink / raw)
To: linux-arm-kernel
Hey Tony and Russel ,
There is a FIX ME message in this function of the file stated in my
subject line.
I was wondering what locking is needed here due to not having experience with
omap subsystem(s).
Cheers Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: FIX ME in function ocpi_enable in file arch/arm/mach-omap1/opci.c
2014-07-01 22:49 ` Nick Krause
@ 2014-07-02 6:55 ` Tony Lindgren
-1 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2014-07-02 6:55 UTC (permalink / raw)
To: Nick Krause
Cc: Russell King - ARM Linux, linux-arm-kernel, linux-omap,
linux-kernel@vger.kernel.org
* Nick Krause <xerofoify@gmail.com> [140701 15:51]:
> Hey Tony and Russel ,
> There is a FIX ME message in this function of the file stated in my
> subject line.
> I was wondering what locking is needed here due to not having experience with
> omap subsystem(s).
Looks like the locking for ocpi_enable would be needed if
it was called from multiple drivers. We are just enabling all
access, so no locking neeed for the current usage.
Regards,
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
* FIX ME in function ocpi_enable in file arch/arm/mach-omap1/opci.c
@ 2014-07-02 6:55 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2014-07-02 6:55 UTC (permalink / raw)
To: linux-arm-kernel
* Nick Krause <xerofoify@gmail.com> [140701 15:51]:
> Hey Tony and Russel ,
> There is a FIX ME message in this function of the file stated in my
> subject line.
> I was wondering what locking is needed here due to not having experience with
> omap subsystem(s).
Looks like the locking for ocpi_enable would be needed if
it was called from multiple drivers. We are just enabling all
access, so no locking neeed for the current usage.
Regards,
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: FIX ME in function ocpi_enable in file arch/arm/mach-omap1/opci.c
2014-07-02 6:55 ` Tony Lindgren
@ 2014-07-03 1:04 ` Nick Krause
-1 siblings, 0 replies; 6+ messages in thread
From: Nick Krause @ 2014-07-03 1:04 UTC (permalink / raw)
To: Tony Lindgren
Cc: Russell King - ARM Linux, linux-arm-kernel, linux-omap,
linux-kernel@vger.kernel.org
Therefore I will send it a patch removing this FIXME.
Cheers Nick
On Wed, Jul 2, 2014 at 2:55 AM, Tony Lindgren <tony@atomide.com> wrote:
> * Nick Krause <xerofoify@gmail.com> [140701 15:51]:
>> Hey Tony and Russel ,
>> There is a FIX ME message in this function of the file stated in my
>> subject line.
>> I was wondering what locking is needed here due to not having experience with
>> omap subsystem(s).
>
> Looks like the locking for ocpi_enable would be needed if
> it was called from multiple drivers. We are just enabling all
> access, so no locking neeed for the current usage.
>
> Regards,
>
> Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
* FIX ME in function ocpi_enable in file arch/arm/mach-omap1/opci.c
@ 2014-07-03 1:04 ` Nick Krause
0 siblings, 0 replies; 6+ messages in thread
From: Nick Krause @ 2014-07-03 1:04 UTC (permalink / raw)
To: linux-arm-kernel
Therefore I will send it a patch removing this FIXME.
Cheers Nick
On Wed, Jul 2, 2014 at 2:55 AM, Tony Lindgren <tony@atomide.com> wrote:
> * Nick Krause <xerofoify@gmail.com> [140701 15:51]:
>> Hey Tony and Russel ,
>> There is a FIX ME message in this function of the file stated in my
>> subject line.
>> I was wondering what locking is needed here due to not having experience with
>> omap subsystem(s).
>
> Looks like the locking for ocpi_enable would be needed if
> it was called from multiple drivers. We are just enabling all
> access, so no locking neeed for the current usage.
>
> Regards,
>
> Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-03 1:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-01 22:49 FIX ME in function ocpi_enable in file arch/arm/mach-omap1/opci.c Nick Krause
2014-07-01 22:49 ` Nick Krause
2014-07-02 6:55 ` Tony Lindgren
2014-07-02 6:55 ` Tony Lindgren
2014-07-03 1:04 ` Nick Krause
2014-07-03 1:04 ` Nick Krause
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.