From: Theodore Ts'o <tytso@mit.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/sl[aou]b: make kfree() aware of error pointers
Date: Wed, 10 Sep 2014 15:40:10 -0400 [thread overview]
Message-ID: <20140910194010.GE31903@thunk.org> (raw)
In-Reply-To: <20140910155356.GT6549@mwanda>
On Wed, Sep 10, 2014 at 06:53:56PM +0300, Dan Carpenter wrote:
> On Wed, Sep 10, 2014 at 05:28:11PM +0200, Jiri Kosina wrote:
> >
> > Too late for this now, yes.
>
> We could still introduce a __kfree_fast_path() which doesn't have
> checking.
Well, there certainly is precedence for that sort of thing. There is
a bunch of code which uses __brelse(bh) instead of brelse(bh) when the
caller is sure that bh is a valid non-NULL pointer.
- Ted
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Ts'o" <tytso@mit.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/sl[aou]b: make kfree() aware of error pointers
Date: Wed, 10 Sep 2014 15:40:10 -0400 [thread overview]
Message-ID: <20140910194010.GE31903@thunk.org> (raw)
In-Reply-To: <20140910155356.GT6549@mwanda>
On Wed, Sep 10, 2014 at 06:53:56PM +0300, Dan Carpenter wrote:
> On Wed, Sep 10, 2014 at 05:28:11PM +0200, Jiri Kosina wrote:
> >
> > Too late for this now, yes.
>
> We could still introduce a __kfree_fast_path() which doesn't have
> checking.
Well, there certainly is precedence for that sort of thing. There is
a bunch of code which uses __brelse(bh) instead of brelse(bh) when the
caller is sure that bh is a valid non-NULL pointer.
- Ted
next prev parent reply other threads:[~2014-09-10 19:40 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 21:25 [PATCH] mm/sl[aou]b: make kfree() aware of error pointers Jiri Kosina
2014-09-09 21:25 ` Jiri Kosina
2014-09-09 23:21 ` Andrew Morton
2014-09-09 23:21 ` Andrew Morton
2014-09-10 5:05 ` Jiri Kosina
2014-09-10 5:05 ` Jiri Kosina
2014-09-10 5:11 ` Andrew Morton
2014-09-10 5:11 ` Andrew Morton
2014-09-10 6:36 ` Dan Carpenter
2014-09-10 6:36 ` Dan Carpenter
2014-09-10 13:56 ` Theodore Ts'o
2014-09-10 13:56 ` Theodore Ts'o
2014-09-10 14:27 ` Dave Jones
2014-09-10 14:27 ` Dave Jones
2014-09-10 14:07 ` Theodore Ts'o
2014-09-10 14:07 ` Theodore Ts'o
2014-09-10 14:24 ` Jiri Kosina
2014-09-10 14:24 ` Jiri Kosina
2014-09-10 14:33 ` Andrey Ryabinin
2014-09-10 14:33 ` Andrey Ryabinin
2014-09-10 14:42 ` Jiri Kosina
2014-09-10 14:42 ` Jiri Kosina
2014-09-10 15:43 ` Christoph Lameter
2014-09-10 15:43 ` Christoph Lameter
2014-09-10 14:26 ` Jiri Kosina
2014-09-10 14:26 ` Jiri Kosina
2014-09-10 15:21 ` Dan Carpenter
2014-09-10 15:21 ` Dan Carpenter
2014-09-10 15:28 ` Jiri Kosina
2014-09-10 15:28 ` Jiri Kosina
2014-09-10 15:53 ` Dan Carpenter
2014-09-10 15:53 ` Dan Carpenter
2014-09-10 19:40 ` Theodore Ts'o [this message]
2014-09-10 19:40 ` Theodore Ts'o
2014-09-11 14:14 ` Rasmus Villemoes
2014-09-11 14:14 ` Rasmus Villemoes
2014-09-10 14:22 ` Christoph Lameter
2014-09-10 14:22 ` Christoph Lameter
2014-09-10 5:15 ` Valdis.Kletnieks
2014-09-10 6:51 ` Dan Carpenter
2014-09-10 6:51 ` Dan Carpenter
2014-09-10 13:59 ` Christoph Lameter
2014-09-10 13:59 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910194010.GE31903@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dan.carpenter@oracle.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.