All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Johannes Stezenbach <js@linuxtv.org>
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
	Shuah Khan <shuah.kh@samsung.com>,
	linux-media@vger.kernel.org
Subject: Re: em28xx breaks after hibernate
Date: Fri, 26 Sep 2014 07:14:11 -0300	[thread overview]
Message-ID: <20140926071411.61a011bd@recife.lan> (raw)
In-Reply-To: <20140926080824.GA8382@linuxtv.org>

Hi Johannes/Shuah,

Em Fri, 26 Sep 2014 10:08:24 +0200
Johannes Stezenbach <js@linuxtv.org> escreveu:

> On Fri, Sep 26, 2014 at 10:00:30AM +0200, Johannes Stezenbach wrote:
> > On Thu, Sep 25, 2014 at 12:45:24PM -0600, Shuah Khan wrote:
> > > 
> > > Revert is good. Just checked 3.16 and we are good
> > > on that. It needs to be reverted from 3.17 for sure.
> > > 
> > > ok now I know why the second path didn't
> > > apply. It depends on another change that added resume
> > > function
> > > 
> > > 7ab1c07614b984778a808dc22f84b682fedefea1
> > > 
> > > You don't need the second patch. The first patch applied
> > > to 3.17 and fails on 3.16
> > > 
> > > http://patchwork.linuxtv.org/patch/26073/
> > 
> > I'm not sure I understand correctly.  I applied the
> > b89193e0b06f revert plus the 26073 patchwork patch
> > on top of yesterday's git master (v3.17-rc6-247-g005f800),
> > the xc5000 request_firmware issue still happens, additionally
> > a drxk_attach request_firmware warning is printed after resume.

I just pushed the pending patched and added a reverted patch for
b89193e0b06f at the media_tree.git. Could you please use it to compile
or, if you prefer to keep using 3.16, you can use the media_build.git[1]
tree to just use the newest media stack on the top of 3.16.

[1] http://linuxtv.org/wiki/index.php/How_to_Obtain,_Build_and_Install_V4L-DVB_Device_Drivers

I updated the today's tarball for it to have all the patches there.

> > I should mention I just test "boot -> hibernate -> resume",
> > the device is not opened before hibernate.
> 
> If I run dvb-fe-tool to load the xc5000 firmware before
> hibernate then the xc5000 issue seems fixed, but the
> drxk firmware issue still happens.

Please check if the xc5000 issue disappears with the current patches.

The drxk issue will likely need a similar fix to the one that Shuah
did to drxj.

Shuah,

Could you please take a look at the drx-k driver? It is not that different
from the drx-j.

Regards,
Mauro

  reply	other threads:[~2014-09-26 10:14 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25 12:53 em28xx breaks after hibernate Johannes Stezenbach
2014-09-25 13:45 ` Shuah Khan
2014-09-25 14:10   ` Mauro Carvalho Chehab
2014-09-25 15:07     ` Shuah Khan
2014-09-25 16:01   ` Johannes Stezenbach
2014-09-25 17:36     ` Johannes Stezenbach
2014-09-25 18:01       ` Shuah Khan
2014-09-25 17:40     ` Shuah Khan
2014-09-25 18:17       ` Johannes Stezenbach
2014-09-25 18:45         ` Shuah Khan
2014-09-25 19:03           ` Shuah Khan
2014-09-26  7:41             ` Johannes Stezenbach
2014-09-26  8:00           ` Johannes Stezenbach
2014-09-26  8:08             ` Johannes Stezenbach
2014-09-26 10:14               ` Mauro Carvalho Chehab [this message]
2014-09-26 11:07                 ` Johannes Stezenbach
2014-09-26 11:42                   ` Mauro Carvalho Chehab
2014-09-26 12:02                     ` Johannes Stezenbach
2014-09-26 12:11                       ` Mauro Carvalho Chehab
2014-09-26 12:03                     ` Mauro Carvalho Chehab
2014-09-26 12:27                       ` Johannes Stezenbach
2014-09-26 13:12                         ` Mauro Carvalho Chehab
2014-09-26 13:25                           ` Johannes Stezenbach
2014-09-26 14:25                             ` Shuah Khan
2014-09-26 14:25                             ` Johannes Stezenbach
2014-09-26 14:30                               ` Shuah Khan
2014-09-26 15:06                                 ` Johannes Stezenbach
2014-09-26 15:22                                   ` Johannes Stezenbach
2014-09-26 15:43                                     ` Mauro Carvalho Chehab
2014-09-28 10:55                                       ` Johannes Stezenbach
2014-09-28 11:12                                         ` Mauro Carvalho Chehab
2014-09-28 11:54                                           ` Johannes Stezenbach
2014-09-28 12:35                                             ` Mauro Carvalho Chehab
2014-09-28 12:57                                             ` Mauro Carvalho Chehab
2014-09-29  2:38                                             ` Mauro Carvalho Chehab
2014-09-26 15:22                                   ` Shuah Khan
2014-09-26 15:35                                     ` Mauro Carvalho Chehab
2014-09-26 15:40                                     ` Mauro Carvalho Chehab
2014-09-26 15:42                                     ` Johannes Stezenbach
2014-09-26 15:48                                       ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140926071411.61a011bd@recife.lan \
    --to=mchehab@osg.samsung.com \
    --cc=js@linuxtv.org \
    --cc=linux-media@vger.kernel.org \
    --cc=shuah.kh@samsung.com \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.