All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Johannes Stezenbach <js@linuxtv.org>
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
	Shuah Khan <shuah.kh@samsung.com>,
	linux-media@vger.kernel.org
Subject: Re: em28xx breaks after hibernate
Date: Sun, 28 Sep 2014 09:57:31 -0300	[thread overview]
Message-ID: <20140928095731.6eb384cb@recife.lan> (raw)
In-Reply-To: <20140928115405.GA30490@linuxtv.org>

Em Sun, 28 Sep 2014 13:54:05 +0200
Johannes Stezenbach <js@linuxtv.org> escreveu:

> On Sun, Sep 28, 2014 at 08:12:11AM -0300, Mauro Carvalho Chehab wrote:
> > Em Sun, 28 Sep 2014 12:55:40 +0200
> > Johannes Stezenbach <js@linuxtv.org> escreveu:
> > 
> > > I tried again both with and without the patch.  The issue above
> > > odesn't reproduce, but after hibernate it fails to tune
> > > (while it works after suspend-to-ram).  Restarting dvbv5-zap
> > > does not fix it.  All I get is:
> > > 
> > > [  500.299216] drxk: Error -22 on dvbt_sc_command
> > > [  500.301012] drxk: Error -22 on set_dvbt
> > > [  500.301967] drxk: Error -22 on start

I suspect that this is probably because em28xx didn't initialize the GPIOs
after power down. Please try the enclosed (untested) hack.

Regards,
Mauro


diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c
index 9682c52d67d1..3403e775bf43 100644
--- a/drivers/media/usb/em28xx/em28xx-dvb.c
+++ b/drivers/media/usb/em28xx/em28xx-dvb.c
@@ -1745,6 +1745,10 @@ static int em28xx_dvb_resume(struct em28xx *dev)
 	if (!dev->board.has_dvb)
 		return 0;
 
+
+/* HACK */
+hauppauge_hvr930c_init(dev);
+
 	em28xx_info("Resuming DVB extension");
 	if (dev->dvb) {
 		struct em28xx_dvb *dvb = dev->dvb;

  parent reply	other threads:[~2014-09-28 12:57 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25 12:53 em28xx breaks after hibernate Johannes Stezenbach
2014-09-25 13:45 ` Shuah Khan
2014-09-25 14:10   ` Mauro Carvalho Chehab
2014-09-25 15:07     ` Shuah Khan
2014-09-25 16:01   ` Johannes Stezenbach
2014-09-25 17:36     ` Johannes Stezenbach
2014-09-25 18:01       ` Shuah Khan
2014-09-25 17:40     ` Shuah Khan
2014-09-25 18:17       ` Johannes Stezenbach
2014-09-25 18:45         ` Shuah Khan
2014-09-25 19:03           ` Shuah Khan
2014-09-26  7:41             ` Johannes Stezenbach
2014-09-26  8:00           ` Johannes Stezenbach
2014-09-26  8:08             ` Johannes Stezenbach
2014-09-26 10:14               ` Mauro Carvalho Chehab
2014-09-26 11:07                 ` Johannes Stezenbach
2014-09-26 11:42                   ` Mauro Carvalho Chehab
2014-09-26 12:02                     ` Johannes Stezenbach
2014-09-26 12:11                       ` Mauro Carvalho Chehab
2014-09-26 12:03                     ` Mauro Carvalho Chehab
2014-09-26 12:27                       ` Johannes Stezenbach
2014-09-26 13:12                         ` Mauro Carvalho Chehab
2014-09-26 13:25                           ` Johannes Stezenbach
2014-09-26 14:25                             ` Shuah Khan
2014-09-26 14:25                             ` Johannes Stezenbach
2014-09-26 14:30                               ` Shuah Khan
2014-09-26 15:06                                 ` Johannes Stezenbach
2014-09-26 15:22                                   ` Johannes Stezenbach
2014-09-26 15:43                                     ` Mauro Carvalho Chehab
2014-09-28 10:55                                       ` Johannes Stezenbach
2014-09-28 11:12                                         ` Mauro Carvalho Chehab
2014-09-28 11:54                                           ` Johannes Stezenbach
2014-09-28 12:35                                             ` Mauro Carvalho Chehab
2014-09-28 12:57                                             ` Mauro Carvalho Chehab [this message]
2014-09-29  2:38                                             ` Mauro Carvalho Chehab
2014-09-26 15:22                                   ` Shuah Khan
2014-09-26 15:35                                     ` Mauro Carvalho Chehab
2014-09-26 15:40                                     ` Mauro Carvalho Chehab
2014-09-26 15:42                                     ` Johannes Stezenbach
2014-09-26 15:48                                       ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140928095731.6eb384cb@recife.lan \
    --to=mchehab@osg.samsung.com \
    --cc=js@linuxtv.org \
    --cc=linux-media@vger.kernel.org \
    --cc=shuah.kh@samsung.com \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.