From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Johannes Stezenbach <js@linuxtv.org>
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
Shuah Khan <shuah.kh@samsung.com>,
linux-media@vger.kernel.org
Subject: Re: em28xx breaks after hibernate
Date: Fri, 26 Sep 2014 10:12:22 -0300 [thread overview]
Message-ID: <20140926101222.778ebcaf@recife.lan> (raw)
In-Reply-To: <20140926122721.GA11597@linuxtv.org>
Em Fri, 26 Sep 2014 14:27:21 +0200
Johannes Stezenbach <js@linuxtv.org> escreveu:
> On Fri, Sep 26, 2014 at 09:03:16AM -0300, Mauro Carvalho Chehab wrote:
> >
> > The patch I sent you (or some fixed version of it) is part of the
> > solution, but this still bothers me:
> >
> > > > [ 3.776854] [<ffffffff813f974f>] drxk_attach+0x546/0x656
> > > > [ 3.777675] [<ffffffff814c22a3>] em28xx_dvb_init.part.3+0xa3e/0x1cdf
> > > > [ 3.778652] [<ffffffff8106555c>] ? trace_hardirqs_on_caller+0x183/0x19f
> > > > [ 3.779690] [<ffffffff81065585>] ? trace_hardirqs_on+0xd/0xf
> > > > [ 3.780615] [<ffffffff814c5b45>] ? mutex_unlock+0x9/0xb
> > > > [ 3.781428] [<ffffffff814c0f50>] ? em28xx_v4l2_init.part.11+0xcbd/0xd04
> > > > [ 3.782487] [<ffffffff814230cf>] em28xx_dvb_init+0x1d/0x1f
> >
> > Why em28xx_dvb_init() is being called?
> >
> > That should only happen if the device is re-probed again, but
> > the reset_resume code should have been preventing it.
>
> Well, I stuck a WARN_ON(1) into drxk_release(), it is not called
> during hibernate+resume.
Well, it shouldn't be called at hibernate, but, at resume, the
reset_resume callback at em28xx should have been called, but I'm
not seeing any message indicating it.
Try to add a WARN_ON or printk at em28xx_usb_resume().
> Do you have a better suggestion to debug it?
>
> Johannes
next prev parent reply other threads:[~2014-09-26 13:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 12:53 em28xx breaks after hibernate Johannes Stezenbach
2014-09-25 13:45 ` Shuah Khan
2014-09-25 14:10 ` Mauro Carvalho Chehab
2014-09-25 15:07 ` Shuah Khan
2014-09-25 16:01 ` Johannes Stezenbach
2014-09-25 17:36 ` Johannes Stezenbach
2014-09-25 18:01 ` Shuah Khan
2014-09-25 17:40 ` Shuah Khan
2014-09-25 18:17 ` Johannes Stezenbach
2014-09-25 18:45 ` Shuah Khan
2014-09-25 19:03 ` Shuah Khan
2014-09-26 7:41 ` Johannes Stezenbach
2014-09-26 8:00 ` Johannes Stezenbach
2014-09-26 8:08 ` Johannes Stezenbach
2014-09-26 10:14 ` Mauro Carvalho Chehab
2014-09-26 11:07 ` Johannes Stezenbach
2014-09-26 11:42 ` Mauro Carvalho Chehab
2014-09-26 12:02 ` Johannes Stezenbach
2014-09-26 12:11 ` Mauro Carvalho Chehab
2014-09-26 12:03 ` Mauro Carvalho Chehab
2014-09-26 12:27 ` Johannes Stezenbach
2014-09-26 13:12 ` Mauro Carvalho Chehab [this message]
2014-09-26 13:25 ` Johannes Stezenbach
2014-09-26 14:25 ` Shuah Khan
2014-09-26 14:25 ` Johannes Stezenbach
2014-09-26 14:30 ` Shuah Khan
2014-09-26 15:06 ` Johannes Stezenbach
2014-09-26 15:22 ` Johannes Stezenbach
2014-09-26 15:43 ` Mauro Carvalho Chehab
2014-09-28 10:55 ` Johannes Stezenbach
2014-09-28 11:12 ` Mauro Carvalho Chehab
2014-09-28 11:54 ` Johannes Stezenbach
2014-09-28 12:35 ` Mauro Carvalho Chehab
2014-09-28 12:57 ` Mauro Carvalho Chehab
2014-09-29 2:38 ` Mauro Carvalho Chehab
2014-09-26 15:22 ` Shuah Khan
2014-09-26 15:35 ` Mauro Carvalho Chehab
2014-09-26 15:40 ` Mauro Carvalho Chehab
2014-09-26 15:42 ` Johannes Stezenbach
2014-09-26 15:48 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926101222.778ebcaf@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=js@linuxtv.org \
--cc=linux-media@vger.kernel.org \
--cc=shuah.kh@samsung.com \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.