All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Geoff Levand <geoff@infradead.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	Eric Biederman <ebiederm@xmission.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V25/5] powerpc/kexec: Use global IND_FLAGS macro
Date: Tue, 7 Oct 2014 13:52:48 -0400	[thread overview]
Message-ID: <20141007175248.GG27464@redhat.com> (raw)
In-Reply-To: <adf97d602657c72f6ee59aefe5d51149159a3e99.1412640584.git.geoff@infradead.org>

On Tue, Oct 07, 2014 at 12:21:30AM +0000, Geoff Levand wrote:
> linux/kexec.h now defines an IND_FLAGS macro.  Remove the local powerpc
> definition and use the generic one.
> 
> Signed-off-by: Geoff Levand <geoff@infradead.org>

I think this patch should be merged in previous patch. I guess after
applying patch4, series might not be compilable as there are two
definitions of IND_FLAGS now.

Thanks
Vivek

> ---
>  arch/powerpc/kernel/machine_kexec_64.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/machine_kexec_64.c b/arch/powerpc/kernel/machine_kexec_64.c
> index 879b3aa..75652a32 100644
> --- a/arch/powerpc/kernel/machine_kexec_64.c
> +++ b/arch/powerpc/kernel/machine_kexec_64.c
> @@ -96,8 +96,6 @@ int default_machine_kexec_prepare(struct kimage *image)
>  	return 0;
>  }
>  
> -#define IND_FLAGS (IND_DESTINATION | IND_INDIRECTION | IND_DONE | IND_SOURCE)
> -
>  static void copy_segments(unsigned long ind)
>  {
>  	unsigned long entry;
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Geoff Levand <geoff@infradead.org>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	Eric Biederman <ebiederm@xmission.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V25/5] powerpc/kexec: Use global IND_FLAGS macro
Date: Tue, 7 Oct 2014 13:52:48 -0400	[thread overview]
Message-ID: <20141007175248.GG27464@redhat.com> (raw)
In-Reply-To: <adf97d602657c72f6ee59aefe5d51149159a3e99.1412640584.git.geoff@infradead.org>

On Tue, Oct 07, 2014 at 12:21:30AM +0000, Geoff Levand wrote:
> linux/kexec.h now defines an IND_FLAGS macro.  Remove the local powerpc
> definition and use the generic one.
> 
> Signed-off-by: Geoff Levand <geoff@infradead.org>

I think this patch should be merged in previous patch. I guess after
applying patch4, series might not be compilable as there are two
definitions of IND_FLAGS now.

Thanks
Vivek

> ---
>  arch/powerpc/kernel/machine_kexec_64.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/machine_kexec_64.c b/arch/powerpc/kernel/machine_kexec_64.c
> index 879b3aa..75652a32 100644
> --- a/arch/powerpc/kernel/machine_kexec_64.c
> +++ b/arch/powerpc/kernel/machine_kexec_64.c
> @@ -96,8 +96,6 @@ int default_machine_kexec_prepare(struct kimage *image)
>  	return 0;
>  }
>  
> -#define IND_FLAGS (IND_DESTINATION | IND_INDIRECTION | IND_DONE | IND_SOURCE)
> -
>  static void copy_segments(unsigned long ind)
>  {
>  	unsigned long entry;
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Geoff Levand <geoff@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org,
	Eric Biederman <ebiederm@xmission.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V25/5] powerpc/kexec: Use global IND_FLAGS macro
Date: Tue, 7 Oct 2014 13:52:48 -0400	[thread overview]
Message-ID: <20141007175248.GG27464@redhat.com> (raw)
In-Reply-To: <adf97d602657c72f6ee59aefe5d51149159a3e99.1412640584.git.geoff@infradead.org>

On Tue, Oct 07, 2014 at 12:21:30AM +0000, Geoff Levand wrote:
> linux/kexec.h now defines an IND_FLAGS macro.  Remove the local powerpc
> definition and use the generic one.
> 
> Signed-off-by: Geoff Levand <geoff@infradead.org>

I think this patch should be merged in previous patch. I guess after
applying patch4, series might not be compilable as there are two
definitions of IND_FLAGS now.

Thanks
Vivek

> ---
>  arch/powerpc/kernel/machine_kexec_64.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/machine_kexec_64.c b/arch/powerpc/kernel/machine_kexec_64.c
> index 879b3aa..75652a32 100644
> --- a/arch/powerpc/kernel/machine_kexec_64.c
> +++ b/arch/powerpc/kernel/machine_kexec_64.c
> @@ -96,8 +96,6 @@ int default_machine_kexec_prepare(struct kimage *image)
>  	return 0;
>  }
>  
> -#define IND_FLAGS (IND_DESTINATION | IND_INDIRECTION | IND_DONE | IND_SOURCE)
> -
>  static void copy_segments(unsigned long ind)
>  {
>  	unsigned long entry;
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2014-10-07 17:53 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 18:39 [PATCH 0/5] kexec: minor fixups and enhancements Geoff Levand
2014-08-22 18:39 ` Geoff Levand
2014-08-22 18:39 ` Geoff Levand
2014-08-22 18:39 ` [PATCH 3/5] kexec: Add bit definitions for kimage entry flags Geoff Levand
2014-08-22 18:39   ` Geoff Levand
2014-08-22 18:39   ` Geoff Levand
2014-08-25 17:52   ` Vivek Goyal
2014-08-25 17:52     ` Vivek Goyal
2014-08-25 17:52     ` Vivek Goyal
2014-08-22 18:39 ` [PATCH 2/5] kexec: Simplify conditional Geoff Levand
2014-08-22 18:39   ` Geoff Levand
2014-08-22 18:39   ` Geoff Levand
2014-08-25 17:42   ` Vivek Goyal
2014-08-25 17:42     ` Vivek Goyal
2014-08-25 17:42     ` Vivek Goyal
2014-08-22 18:39 ` [PATCH 1/5] kexec: Fix make headers_check Geoff Levand
2014-08-22 18:39   ` Geoff Levand
2014-08-22 18:39   ` Geoff Levand
2014-08-25 17:22   ` Vivek Goyal
2014-08-25 17:22     ` Vivek Goyal
2014-08-25 17:22     ` Vivek Goyal
2014-08-30 12:47     ` Paul Bolle
2014-08-30 12:47       ` Paul Bolle
2014-08-30 12:47       ` Paul Bolle
2014-10-06 14:12       ` Paul Bolle
2014-10-06 14:12         ` Paul Bolle
2014-10-06 14:12         ` Paul Bolle
2014-10-06 17:34         ` Geoff Levand
2014-10-06 17:34           ` Geoff Levand
2014-10-06 17:34           ` Geoff Levand
2014-10-06 18:21           ` Paul Bolle
2014-10-06 18:21             ` Paul Bolle
2014-10-06 18:21             ` Paul Bolle
2014-10-06 19:28             ` Geoff Levand
2014-10-06 19:28               ` Geoff Levand
2014-10-06 19:28               ` Geoff Levand
2014-10-06 17:44       ` H. Peter Anvin
2014-10-06 17:44         ` H. Peter Anvin
2014-10-06 17:44         ` H. Peter Anvin
2014-08-22 18:39 ` [PATCH 5/5] powerpc/kexec: Use global IND_FLAGS macro Geoff Levand
2014-08-22 18:39   ` Geoff Levand
2014-08-22 18:39   ` Geoff Levand
2014-08-22 18:39 ` [PATCH 4/5] kexec: Add " Geoff Levand
2014-08-22 18:39   ` Geoff Levand
2014-08-22 18:39   ` Geoff Levand
2014-08-25 17:54   ` Vivek Goyal
2014-08-25 17:54     ` Vivek Goyal
2014-08-25 17:54     ` Vivek Goyal
2014-08-25 16:59 ` [PATCH 0/5] kexec: minor fixups and enhancements Vivek Goyal
2014-08-25 16:59   ` Vivek Goyal
2014-08-25 16:59   ` Vivek Goyal
2014-08-26  7:41   ` Dave Young
2014-08-26  7:41     ` Dave Young
2014-08-26  7:41     ` Dave Young
2014-08-27  0:33   ` Geoff Levand
2014-08-27  0:33     ` Geoff Levand
2014-08-27  0:33     ` Geoff Levand
2014-08-27  0:42     ` Vivek Goyal
2014-08-27  0:42       ` Vivek Goyal
2014-08-27  0:42       ` Vivek Goyal
2014-10-07  0:21 ` [PATCH V2 0/5] kexec: Minor " Geoff Levand
2014-10-07  0:21   ` Geoff Levand
2014-10-07  0:21   ` Geoff Levand
2014-10-07  0:21   ` [PATCH V22/5] kexec: Simplify conditional Geoff Levand
2014-10-07  0:21     ` Geoff Levand
2014-10-07  0:21     ` Geoff Levand
2014-10-07  0:21   ` [PATCH V24/5] kexec: Add IND_FLAGS macro Geoff Levand
2014-10-07  0:21     ` Geoff Levand
2014-10-07  0:21     ` Geoff Levand
2014-10-07 20:26     ` [PATCH V3 4/5] " Geoff Levand
2014-10-07 20:26       ` Geoff Levand
2014-10-07 20:26       ` Geoff Levand
2014-10-07  0:21   ` [PATCH V21/5] kexec: Fix make headers_check Geoff Levand
2014-10-07  0:21     ` Geoff Levand
2014-10-07  0:21     ` Geoff Levand
2014-10-07  0:21   ` [PATCH V25/5] powerpc/kexec: Use global IND_FLAGS macro Geoff Levand
2014-10-07  0:21     ` Geoff Levand
2014-10-07  0:21     ` Geoff Levand
2014-10-07 17:52     ` Vivek Goyal [this message]
2014-10-07 17:52       ` Vivek Goyal
2014-10-07 17:52       ` Vivek Goyal
2014-11-12 19:29       ` [PATCH V3] kexec: Add " Geoff Levand
2014-11-12 19:29         ` Geoff Levand
2014-11-12 19:29         ` Geoff Levand
2014-11-12 23:06         ` Benjamin Herrenschmidt
2014-11-12 23:06           ` Benjamin Herrenschmidt
2014-11-12 23:06           ` Benjamin Herrenschmidt
2014-10-07  0:21   ` [PATCH V23/5] kexec: Add bit definitions for kimage entry flags Geoff Levand
2014-10-07  0:21     ` Geoff Levand
2014-10-07  0:21     ` Geoff Levand
2014-11-13  0:19 ` [PATCH V3 0/4] kexec: minor fixups and enhancements Geoff Levand
2014-11-13  0:19   ` Geoff Levand
2014-11-13  0:19   ` Geoff Levand
2014-11-13  0:19   ` [PATCH V3 2/4] kexec: Simplify conditional Geoff Levand
2014-11-13  0:19     ` Geoff Levand
2014-11-13  0:19     ` Geoff Levand
2014-11-13  0:19   ` [PATCH V3 1/4] kexec: Fix make headers_check Geoff Levand
2014-11-13  0:19     ` Geoff Levand
2014-11-13  0:19     ` Geoff Levand
2014-11-13  0:19   ` [PATCH V3 4/4] kexec: Add IND_FLAGS macro Geoff Levand
2014-11-13  0:19     ` Geoff Levand
2014-11-13  0:19     ` Geoff Levand
2014-11-13  0:19   ` [PATCH V3 3/4] kexec: Add bit definitions for kimage entry flags Geoff Levand
2014-11-13  0:19     ` Geoff Levand
2014-11-13  0:19     ` Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141007175248.GG27464@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=ebiederm@xmission.com \
    --cc=geoff@infradead.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.