From: gregkh@linuxfoundation.org (Greg KH)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [RFC] drop owner assignment from platform_drivers
Date: Sun, 12 Oct 2014 16:24:55 +0200 [thread overview]
Message-ID: <20141012142455.GC21479@kroah.com> (raw)
In-Reply-To: <20141012055146.GA1310@katana>
On Sun, Oct 12, 2014 at 07:51:46AM +0200, Wolfram Sang wrote:
>
> > I missed the one code path you pointed out, and that should be fixed,
> > but that doesn't mean that the original patch should be reverted, as it
> > is the way we want things to be, let's just fix up the bug and move on.
>
> OK, that is a clear statement.
>
> So, what is your opinion on the original cleanup series removing
> unnecessary '.owner = THIS_MODULE' lines in drivers? Helpful? Noise?
Helpful, please do it. I can take it all through my driver-core tree if
you want, that might make things easier for others.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: cocci@systeme.lip6.fr
Subject: Re: [RFC] drop owner assignment from platform_drivers
Date: Sun, 12 Oct 2014 14:24:55 +0000 [thread overview]
Message-ID: <20141012142455.GC21479@kroah.com> (raw)
In-Reply-To: <20141012055146.GA1310@katana>
On Sun, Oct 12, 2014 at 07:51:46AM +0200, Wolfram Sang wrote:
>
> > I missed the one code path you pointed out, and that should be fixed,
> > but that doesn't mean that the original patch should be reverted, as it
> > is the way we want things to be, let's just fix up the bug and move on.
>
> OK, that is a clear statement.
>
> So, what is your opinion on the original cleanup series removing
> unnecessary '.owner = THIS_MODULE' lines in drivers? Helpful? Noise?
Helpful, please do it. I can take it all through my driver-core tree if
you want, that might make things easier for others.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] drop owner assignment from platform_drivers
Date: Sun, 12 Oct 2014 16:24:55 +0200 [thread overview]
Message-ID: <20141012142455.GC21479@kroah.com> (raw)
In-Reply-To: <20141012055146.GA1310@katana>
On Sun, Oct 12, 2014 at 07:51:46AM +0200, Wolfram Sang wrote:
>
> > I missed the one code path you pointed out, and that should be fixed,
> > but that doesn't mean that the original patch should be reverted, as it
> > is the way we want things to be, let's just fix up the bug and move on.
>
> OK, that is a clear statement.
>
> So, what is your opinion on the original cleanup series removing
> unnecessary '.owner = THIS_MODULE' lines in drivers? Helpful? Noise?
Helpful, please do it. I can take it all through my driver-core tree if
you want, that might make things easier for others.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
cocci@systeme.lip6.fr
Subject: Re: [RFC] drop owner assignment from platform_drivers
Date: Sun, 12 Oct 2014 16:24:55 +0200 [thread overview]
Message-ID: <20141012142455.GC21479@kroah.com> (raw)
In-Reply-To: <20141012055146.GA1310@katana>
On Sun, Oct 12, 2014 at 07:51:46AM +0200, Wolfram Sang wrote:
>
> > I missed the one code path you pointed out, and that should be fixed,
> > but that doesn't mean that the original patch should be reverted, as it
> > is the way we want things to be, let's just fix up the bug and move on.
>
> OK, that is a clear statement.
>
> So, what is your opinion on the original cleanup series removing
> unnecessary '.owner = THIS_MODULE' lines in drivers? Helpful? Noise?
Helpful, please do it. I can take it all through my driver-core tree if
you want, that might make things easier for others.
greg k-h
next prev parent reply other threads:[~2014-10-12 14:24 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 7:24 [Cocci] [RFC] drop owner assignment from platform_drivers Wolfram Sang
2014-10-10 7:24 ` Wolfram Sang
2014-10-10 7:24 ` Wolfram Sang
2014-10-10 7:24 ` Wolfram Sang
2014-10-10 7:54 ` [Cocci] " Julia Lawall
2014-10-10 7:54 ` Julia Lawall
2014-10-10 7:54 ` Julia Lawall
2014-10-10 7:54 ` Julia Lawall
2014-10-10 18:04 ` Wolfram Sang
2014-10-10 18:04 ` Wolfram Sang
2014-10-10 18:04 ` Wolfram Sang
2014-10-10 18:04 ` Wolfram Sang
2014-10-10 8:30 ` Arnd Bergmann
2014-10-10 8:30 ` Arnd Bergmann
2014-10-10 8:30 ` Arnd Bergmann
2014-10-10 8:30 ` Arnd Bergmann
2014-10-10 18:12 ` [Cocci] " Wolfram Sang
2014-10-10 18:12 ` Wolfram Sang
2014-10-10 18:12 ` Wolfram Sang
2014-10-10 18:12 ` Wolfram Sang
2014-10-10 19:39 ` [Cocci] " Arnd Bergmann
2014-10-10 19:39 ` Arnd Bergmann
2014-10-10 19:39 ` Arnd Bergmann
2014-10-10 19:39 ` Arnd Bergmann
2014-10-10 8:36 ` [Cocci] " Russell King - ARM Linux
2014-10-10 8:36 ` Russell King - ARM Linux
2014-10-10 8:36 ` Russell King - ARM Linux
2014-10-10 8:36 ` Russell King - ARM Linux
2014-10-10 18:26 ` [Cocci] " Wolfram Sang
2014-10-10 18:26 ` Wolfram Sang
2014-10-10 18:26 ` Wolfram Sang
2014-10-10 18:26 ` Wolfram Sang
2014-10-10 19:42 ` [Cocci] " Arnd Bergmann
2014-10-10 19:42 ` Arnd Bergmann
2014-10-10 19:42 ` Arnd Bergmann
2014-10-10 19:42 ` Arnd Bergmann
2014-10-11 16:56 ` [Cocci] " Wolfram Sang
2014-10-11 16:56 ` Wolfram Sang
2014-10-11 16:56 ` Wolfram Sang
2014-10-11 16:56 ` Wolfram Sang
2014-10-11 17:15 ` [Cocci] " Russell King - ARM Linux
2014-10-11 17:15 ` Russell King - ARM Linux
2014-10-11 17:15 ` Russell King - ARM Linux
2014-10-11 17:15 ` Russell King - ARM Linux
2014-10-11 20:55 ` [Cocci] " Greg KH
2014-10-11 20:55 ` Greg KH
2014-10-11 20:55 ` Greg KH
2014-10-11 20:55 ` Greg KH
2014-10-12 5:51 ` [Cocci] " Wolfram Sang
2014-10-12 5:51 ` Wolfram Sang
2014-10-12 5:51 ` Wolfram Sang
2014-10-12 5:51 ` Wolfram Sang
2014-10-12 14:24 ` Greg KH [this message]
2014-10-12 14:24 ` Greg KH
2014-10-12 14:24 ` Greg KH
2014-10-12 14:24 ` Greg KH
2014-10-12 17:01 ` [Cocci] " Wolfram Sang
2014-10-12 17:01 ` Wolfram Sang
2014-10-12 17:01 ` Wolfram Sang
2014-10-12 17:01 ` Wolfram Sang
2014-10-10 21:34 ` [Cocci] " Russell King - ARM Linux
2014-10-10 21:34 ` Russell King - ARM Linux
2014-10-10 21:34 ` Russell King - ARM Linux
2014-10-10 21:34 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141012142455.GC21479@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.