From: arnd@arndb.de (Arnd Bergmann)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [RFC] drop owner assignment from platform_drivers
Date: Fri, 10 Oct 2014 21:42:21 +0200 [thread overview]
Message-ID: <2769473.KEN6DZKnT7@wuerfel> (raw)
In-Reply-To: <20141010182604.GC6075@katana>
On Friday 10 October 2014 20:26:05 Wolfram Sang wrote:
>
> You got me wondering, though, that it could not be correct to call
> platform_driver_register() from the platform core instead of module
> init. I will check tomorrow. Still, this would be a bug independent of
> my series. Although I'd need to respin it if platform_driver_probe()
> needed a fix.
Right, this seems to be a preexisting bug. platform_create_bundle
and platform_driver_probe will both overwrite the .owner field with
NULL since they live in builtin code. They need to be replaced with
__platform_driver_probe and __platform_driver_register that both
take an extra owner argument passed down from the caller in the driver
module.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: cocci@systeme.lip6.fr
Subject: Re: [RFC] drop owner assignment from platform_drivers
Date: Fri, 10 Oct 2014 19:42:21 +0000 [thread overview]
Message-ID: <2769473.KEN6DZKnT7@wuerfel> (raw)
In-Reply-To: <20141010182604.GC6075@katana>
On Friday 10 October 2014 20:26:05 Wolfram Sang wrote:
>
> You got me wondering, though, that it could not be correct to call
> platform_driver_register() from the platform core instead of module
> init. I will check tomorrow. Still, this would be a bug independent of
> my series. Although I'd need to respin it if platform_driver_probe()
> needed a fix.
Right, this seems to be a preexisting bug. platform_create_bundle
and platform_driver_probe will both overwrite the .owner field with
NULL since they live in builtin code. They need to be replaced with
__platform_driver_probe and __platform_driver_register that both
take an extra owner argument passed down from the caller in the driver
module.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] drop owner assignment from platform_drivers
Date: Fri, 10 Oct 2014 21:42:21 +0200 [thread overview]
Message-ID: <2769473.KEN6DZKnT7@wuerfel> (raw)
In-Reply-To: <20141010182604.GC6075@katana>
On Friday 10 October 2014 20:26:05 Wolfram Sang wrote:
>
> You got me wondering, though, that it could not be correct to call
> platform_driver_register() from the platform core instead of module
> init. I will check tomorrow. Still, this would be a bug independent of
> my series. Although I'd need to respin it if platform_driver_probe()
> needed a fix.
Right, this seems to be a preexisting bug. platform_create_bundle
and platform_driver_probe will both overwrite the .owner field with
NULL since they live in builtin code. They need to be replaced with
__platform_driver_probe and __platform_driver_register that both
take an extra owner argument passed down from the caller in the driver
module.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Wolfram Sang <wsa@the-dreams.de>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Greg KH <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
cocci@systeme.lip6.fr
Subject: Re: [RFC] drop owner assignment from platform_drivers
Date: Fri, 10 Oct 2014 21:42:21 +0200 [thread overview]
Message-ID: <2769473.KEN6DZKnT7@wuerfel> (raw)
In-Reply-To: <20141010182604.GC6075@katana>
On Friday 10 October 2014 20:26:05 Wolfram Sang wrote:
>
> You got me wondering, though, that it could not be correct to call
> platform_driver_register() from the platform core instead of module
> init. I will check tomorrow. Still, this would be a bug independent of
> my series. Although I'd need to respin it if platform_driver_probe()
> needed a fix.
Right, this seems to be a preexisting bug. platform_create_bundle
and platform_driver_probe will both overwrite the .owner field with
NULL since they live in builtin code. They need to be replaced with
__platform_driver_probe and __platform_driver_register that both
take an extra owner argument passed down from the caller in the driver
module.
Arnd
next prev parent reply other threads:[~2014-10-10 19:42 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 7:24 [Cocci] [RFC] drop owner assignment from platform_drivers Wolfram Sang
2014-10-10 7:24 ` Wolfram Sang
2014-10-10 7:24 ` Wolfram Sang
2014-10-10 7:24 ` Wolfram Sang
2014-10-10 7:54 ` [Cocci] " Julia Lawall
2014-10-10 7:54 ` Julia Lawall
2014-10-10 7:54 ` Julia Lawall
2014-10-10 7:54 ` Julia Lawall
2014-10-10 18:04 ` Wolfram Sang
2014-10-10 18:04 ` Wolfram Sang
2014-10-10 18:04 ` Wolfram Sang
2014-10-10 18:04 ` Wolfram Sang
2014-10-10 8:30 ` Arnd Bergmann
2014-10-10 8:30 ` Arnd Bergmann
2014-10-10 8:30 ` Arnd Bergmann
2014-10-10 8:30 ` Arnd Bergmann
2014-10-10 18:12 ` [Cocci] " Wolfram Sang
2014-10-10 18:12 ` Wolfram Sang
2014-10-10 18:12 ` Wolfram Sang
2014-10-10 18:12 ` Wolfram Sang
2014-10-10 19:39 ` [Cocci] " Arnd Bergmann
2014-10-10 19:39 ` Arnd Bergmann
2014-10-10 19:39 ` Arnd Bergmann
2014-10-10 19:39 ` Arnd Bergmann
2014-10-10 8:36 ` [Cocci] " Russell King - ARM Linux
2014-10-10 8:36 ` Russell King - ARM Linux
2014-10-10 8:36 ` Russell King - ARM Linux
2014-10-10 8:36 ` Russell King - ARM Linux
2014-10-10 18:26 ` [Cocci] " Wolfram Sang
2014-10-10 18:26 ` Wolfram Sang
2014-10-10 18:26 ` Wolfram Sang
2014-10-10 18:26 ` Wolfram Sang
2014-10-10 19:42 ` Arnd Bergmann [this message]
2014-10-10 19:42 ` Arnd Bergmann
2014-10-10 19:42 ` Arnd Bergmann
2014-10-10 19:42 ` Arnd Bergmann
2014-10-11 16:56 ` [Cocci] " Wolfram Sang
2014-10-11 16:56 ` Wolfram Sang
2014-10-11 16:56 ` Wolfram Sang
2014-10-11 16:56 ` Wolfram Sang
2014-10-11 17:15 ` [Cocci] " Russell King - ARM Linux
2014-10-11 17:15 ` Russell King - ARM Linux
2014-10-11 17:15 ` Russell King - ARM Linux
2014-10-11 17:15 ` Russell King - ARM Linux
2014-10-11 20:55 ` [Cocci] " Greg KH
2014-10-11 20:55 ` Greg KH
2014-10-11 20:55 ` Greg KH
2014-10-11 20:55 ` Greg KH
2014-10-12 5:51 ` [Cocci] " Wolfram Sang
2014-10-12 5:51 ` Wolfram Sang
2014-10-12 5:51 ` Wolfram Sang
2014-10-12 5:51 ` Wolfram Sang
2014-10-12 14:24 ` [Cocci] " Greg KH
2014-10-12 14:24 ` Greg KH
2014-10-12 14:24 ` Greg KH
2014-10-12 14:24 ` Greg KH
2014-10-12 17:01 ` [Cocci] " Wolfram Sang
2014-10-12 17:01 ` Wolfram Sang
2014-10-12 17:01 ` Wolfram Sang
2014-10-12 17:01 ` Wolfram Sang
2014-10-10 21:34 ` [Cocci] " Russell King - ARM Linux
2014-10-10 21:34 ` Russell King - ARM Linux
2014-10-10 21:34 ` Russell King - ARM Linux
2014-10-10 21:34 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2769473.KEN6DZKnT7@wuerfel \
--to=arnd@arndb.de \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.