From: Sam Ravnborg <sam@ravnborg.org>
To: David Miller <davem@davemloft.net>
Cc: mroos@linux.ee, iamjoonsoo.kim@lge.com,
linux-kernel@vger.kernel.org, cl@linux.com, penberg@kernel.org,
rientjes@google.com, akpm@linux-foundation.org,
linux-mm@kvack.org, sparclinux@vger.kernel.org
Subject: Re: unaligned accesses in SLAB etc.
Date: Sun, 19 Oct 2014 15:32:20 +0000 [thread overview]
Message-ID: <20141019153219.GA10644@ravnborg.org> (raw)
In-Reply-To: <20141018.142335.1935310766779155342.davem@davemloft.net>
On Sat, Oct 18, 2014 at 02:23:35PM -0400, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Sat, 18 Oct 2014 13:59:07 -0400 (EDT)
>
> > I don't want to define the array size of the fpregs save area
> > explicitly and thereby placing an artificial limit there.
>
> Nevermind, it seems we have a hard limit of 7 FPU save areas anyways.
>
> Meelis, please try this patch:
>
> diff --git a/arch/sparc/include/asm/thread_info_64.h b/arch/sparc/include/asm/thread_info_64.h
> index f85dc85..cc6275c 100644
> --- a/arch/sparc/include/asm/thread_info_64.h
> +++ b/arch/sparc/include/asm/thread_info_64.h
> @@ -63,7 +63,8 @@ struct thread_info {
> struct pt_regs *kern_una_regs;
> unsigned int kern_una_insn;
>
> - unsigned long fpregs[0] __attribute__ ((aligned(64)));
> + unsigned long fpregs[(7 * 256) / sizeof(unsigned long)]
This part:
> + __attribute__ ((aligned(64)));
Could be written as __aligned(64)
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: David Miller <davem@davemloft.net>
Cc: mroos@linux.ee, iamjoonsoo.kim@lge.com,
linux-kernel@vger.kernel.org, cl@linux.com, penberg@kernel.org,
rientjes@google.com, akpm@linux-foundation.org,
linux-mm@kvack.org, sparclinux@vger.kernel.org
Subject: Re: unaligned accesses in SLAB etc.
Date: Sun, 19 Oct 2014 17:32:20 +0200 [thread overview]
Message-ID: <20141019153219.GA10644@ravnborg.org> (raw)
In-Reply-To: <20141018.142335.1935310766779155342.davem@davemloft.net>
On Sat, Oct 18, 2014 at 02:23:35PM -0400, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Sat, 18 Oct 2014 13:59:07 -0400 (EDT)
>
> > I don't want to define the array size of the fpregs save area
> > explicitly and thereby placing an artificial limit there.
>
> Nevermind, it seems we have a hard limit of 7 FPU save areas anyways.
>
> Meelis, please try this patch:
>
> diff --git a/arch/sparc/include/asm/thread_info_64.h b/arch/sparc/include/asm/thread_info_64.h
> index f85dc85..cc6275c 100644
> --- a/arch/sparc/include/asm/thread_info_64.h
> +++ b/arch/sparc/include/asm/thread_info_64.h
> @@ -63,7 +63,8 @@ struct thread_info {
> struct pt_regs *kern_una_regs;
> unsigned int kern_una_insn;
>
> - unsigned long fpregs[0] __attribute__ ((aligned(64)));
> + unsigned long fpregs[(7 * 256) / sizeof(unsigned long)]
This part:
> + __attribute__ ((aligned(64)));
Could be written as __aligned(64)
Sam
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: David Miller <davem@davemloft.net>
Cc: mroos@linux.ee, iamjoonsoo.kim@lge.com,
linux-kernel@vger.kernel.org, cl@linux.com, penberg@kernel.org,
rientjes@google.com, akpm@linux-foundation.org,
linux-mm@kvack.org, sparclinux@vger.kernel.org
Subject: Re: unaligned accesses in SLAB etc.
Date: Sun, 19 Oct 2014 17:32:20 +0200 [thread overview]
Message-ID: <20141019153219.GA10644@ravnborg.org> (raw)
In-Reply-To: <20141018.142335.1935310766779155342.davem@davemloft.net>
On Sat, Oct 18, 2014 at 02:23:35PM -0400, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Sat, 18 Oct 2014 13:59:07 -0400 (EDT)
>
> > I don't want to define the array size of the fpregs save area
> > explicitly and thereby placing an artificial limit there.
>
> Nevermind, it seems we have a hard limit of 7 FPU save areas anyways.
>
> Meelis, please try this patch:
>
> diff --git a/arch/sparc/include/asm/thread_info_64.h b/arch/sparc/include/asm/thread_info_64.h
> index f85dc85..cc6275c 100644
> --- a/arch/sparc/include/asm/thread_info_64.h
> +++ b/arch/sparc/include/asm/thread_info_64.h
> @@ -63,7 +63,8 @@ struct thread_info {
> struct pt_regs *kern_una_regs;
> unsigned int kern_una_insn;
>
> - unsigned long fpregs[0] __attribute__ ((aligned(64)));
> + unsigned long fpregs[(7 * 256) / sizeof(unsigned long)]
This part:
> + __attribute__ ((aligned(64)));
Could be written as __aligned(64)
Sam
next prev parent reply other threads:[~2014-10-19 15:32 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 2:15 unaligned accesses in SLAB etc David Miller
2014-10-12 2:15 ` David Miller
2014-10-12 17:20 ` David Miller
2014-10-12 17:20 ` David Miller
2014-10-12 17:20 ` David Miller
2014-10-13 20:22 ` mroos
2014-10-13 20:22 ` mroos
2014-10-13 20:22 ` mroos
2014-10-13 23:52 ` Joonsoo Kim
2014-10-13 23:52 ` Joonsoo Kim
2014-10-13 23:52 ` Joonsoo Kim
2014-10-14 0:04 ` David Miller
2014-10-14 0:04 ` David Miller
2014-10-14 0:04 ` David Miller
2014-10-14 0:14 ` Joonsoo Kim
2014-10-14 0:14 ` Joonsoo Kim
2014-10-14 0:14 ` Joonsoo Kim
2014-10-14 21:19 ` mroos
2014-10-14 21:19 ` mroos
2014-10-14 21:19 ` mroos
2014-10-14 21:32 ` David Miller
2014-10-14 21:32 ` David Miller
2014-10-14 21:32 ` David Miller
2014-10-15 8:04 ` Meelis Roos
2014-10-15 8:04 ` Meelis Roos
2014-10-15 8:04 ` Meelis Roos
2014-10-15 18:36 ` David Miller
2014-10-15 18:36 ` David Miller
2014-10-15 18:36 ` David Miller
2014-10-15 20:11 ` Meelis Roos
2014-10-15 20:11 ` Meelis Roos
2014-10-15 20:11 ` Meelis Roos
2014-10-16 3:11 ` David Miller
2014-10-16 3:11 ` David Miller
2014-10-16 3:11 ` David Miller
2014-10-16 7:22 ` Meelis Roos
2014-10-16 7:22 ` Meelis Roos
2014-10-16 7:22 ` Meelis Roos
2014-10-16 20:11 ` Meelis Roos
2014-10-16 20:11 ` Meelis Roos
2014-10-16 20:11 ` Meelis Roos
2014-10-16 20:18 ` David Miller
2014-10-16 20:18 ` David Miller
2014-10-16 20:18 ` David Miller
2014-10-16 21:38 ` Meelis Roos
2014-10-16 21:38 ` Meelis Roos
2014-10-19 4:32 ` David Miller
2014-10-19 4:32 ` David Miller
2014-10-19 7:07 ` Meelis Roos
2014-10-19 7:07 ` Meelis Roos
2014-10-20 18:57 ` David Miller
2014-10-20 18:57 ` David Miller
2014-10-22 20:39 ` David Miller
2014-10-22 20:39 ` David Miller
2014-10-22 23:22 ` Meelis Roos
2014-10-22 23:22 ` Meelis Roos
2014-10-23 17:02 ` David Miller
2014-10-23 17:02 ` David Miller
2014-10-23 21:22 ` David Miller
2014-10-23 21:22 ` David Miller
2014-10-24 4:54 ` Sam Ravnborg
2014-10-24 4:54 ` Sam Ravnborg
2014-10-24 16:53 ` David Miller
2014-10-24 16:53 ` David Miller
2014-10-24 7:49 ` Meelis Roos
2014-10-24 7:49 ` Meelis Roos
2014-10-24 16:45 ` David Miller
2014-10-24 16:45 ` David Miller
2014-10-16 7:02 ` Meelis Roos
2014-10-16 7:02 ` Meelis Roos
2014-10-16 7:02 ` Meelis Roos
2014-10-16 20:07 ` David Miller
2014-10-16 20:07 ` David Miller
2014-10-16 20:07 ` David Miller
2014-10-16 20:16 ` Meelis Roos
2014-10-16 20:16 ` Meelis Roos
2014-10-16 20:16 ` Meelis Roos
2014-10-16 20:20 ` David Miller
2014-10-16 20:20 ` David Miller
2014-10-16 20:20 ` David Miller
2014-10-16 20:50 ` David Miller
2014-10-16 20:50 ` David Miller
2014-10-16 20:50 ` David Miller
2014-10-17 11:12 ` Meelis Roos
2014-10-17 11:12 ` Meelis Roos
2014-10-17 11:12 ` Meelis Roos
2014-10-18 17:59 ` David Miller
2014-10-18 17:59 ` David Miller
2014-10-18 17:59 ` David Miller
2014-10-18 18:23 ` David Miller
2014-10-18 18:23 ` David Miller
2014-10-18 18:23 ` David Miller
2014-10-19 12:31 ` Meelis Roos
2014-10-19 12:31 ` Meelis Roos
2014-10-19 12:31 ` Meelis Roos
2014-10-19 17:12 ` Meelis Roos
2014-10-19 17:12 ` Meelis Roos
2014-10-19 17:12 ` Meelis Roos
2014-10-19 17:18 ` David Miller
2014-10-19 17:18 ` David Miller
2014-10-19 17:18 ` David Miller
2014-10-19 15:32 ` Sam Ravnborg [this message]
2014-10-19 15:32 ` Sam Ravnborg
2014-10-19 15:32 ` Sam Ravnborg
2014-10-19 17:27 ` David Miller
2014-10-19 17:27 ` David Miller
2014-10-19 17:27 ` David Miller
2014-10-19 19:55 ` Sam Ravnborg
2014-10-19 19:55 ` Sam Ravnborg
2014-10-19 19:55 ` Sam Ravnborg
2014-10-16 20:20 ` Meelis Roos
2014-10-16 20:20 ` Meelis Roos
2014-10-16 20:20 ` Meelis Roos
2014-10-16 20:40 ` Meelis Roos
2014-10-16 20:40 ` Meelis Roos
2014-10-16 20:40 ` Meelis Roos
2014-10-12 17:22 ` Joonsoo Kim
2014-10-12 17:22 ` Joonsoo Kim
2014-10-12 17:30 ` David Miller
2014-10-12 17:30 ` David Miller
2014-10-12 17:43 ` Joonsoo Kim
2014-10-12 17:43 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141019153219.GA10644@ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=davem@davemloft.net \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mroos@linux.ee \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.