From: Sam Ravnborg <sam@ravnborg.org>
To: David Miller <davem@davemloft.net>
Cc: mroos@linux.ee, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: unaligned accesses in SLAB etc.
Date: Fri, 24 Oct 2014 04:54:55 +0000 [thread overview]
Message-ID: <20141024045454.GA8138@ravnborg.org> (raw)
In-Reply-To: <20141023.172258.1371479087269518956.davem@davemloft.net>
A minor detail.
> [PATCH] sparc64: Fix register corruption in top-most kernel stack frame during boot.
>
> - call start_kernel
> + call start_early_boot
Maybe add a comment about stack use - as per your nice patch description.
> +void __init start_early_boot(void)
This will likely result in sparse complaining about:
fuction not declared - should it be static?
A prototype in include/asm/setup.h would be nice.
Other than this - very nice detective work!
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: David Miller <davem@davemloft.net>
Cc: mroos@linux.ee, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: unaligned accesses in SLAB etc.
Date: Fri, 24 Oct 2014 06:54:55 +0200 [thread overview]
Message-ID: <20141024045454.GA8138@ravnborg.org> (raw)
In-Reply-To: <20141023.172258.1371479087269518956.davem@davemloft.net>
A minor detail.
> [PATCH] sparc64: Fix register corruption in top-most kernel stack frame during boot.
>
> - call start_kernel
> + call start_early_boot
Maybe add a comment about stack use - as per your nice patch description.
> +void __init start_early_boot(void)
This will likely result in sparse complaining about:
fuction not declared - should it be static?
A prototype in include/asm/setup.h would be nice.
Other than this - very nice detective work!
Sam
next prev parent reply other threads:[~2014-10-24 4:54 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 2:15 unaligned accesses in SLAB etc David Miller
2014-10-12 2:15 ` David Miller
2014-10-12 17:20 ` David Miller
2014-10-12 17:20 ` David Miller
2014-10-12 17:20 ` David Miller
2014-10-13 20:22 ` mroos
2014-10-13 20:22 ` mroos
2014-10-13 20:22 ` mroos
2014-10-13 23:52 ` Joonsoo Kim
2014-10-13 23:52 ` Joonsoo Kim
2014-10-13 23:52 ` Joonsoo Kim
2014-10-14 0:04 ` David Miller
2014-10-14 0:04 ` David Miller
2014-10-14 0:04 ` David Miller
2014-10-14 0:14 ` Joonsoo Kim
2014-10-14 0:14 ` Joonsoo Kim
2014-10-14 0:14 ` Joonsoo Kim
2014-10-14 21:19 ` mroos
2014-10-14 21:19 ` mroos
2014-10-14 21:19 ` mroos
2014-10-14 21:32 ` David Miller
2014-10-14 21:32 ` David Miller
2014-10-14 21:32 ` David Miller
2014-10-15 8:04 ` Meelis Roos
2014-10-15 8:04 ` Meelis Roos
2014-10-15 8:04 ` Meelis Roos
2014-10-15 18:36 ` David Miller
2014-10-15 18:36 ` David Miller
2014-10-15 18:36 ` David Miller
2014-10-15 20:11 ` Meelis Roos
2014-10-15 20:11 ` Meelis Roos
2014-10-15 20:11 ` Meelis Roos
2014-10-16 3:11 ` David Miller
2014-10-16 3:11 ` David Miller
2014-10-16 3:11 ` David Miller
2014-10-16 7:22 ` Meelis Roos
2014-10-16 7:22 ` Meelis Roos
2014-10-16 7:22 ` Meelis Roos
2014-10-16 20:11 ` Meelis Roos
2014-10-16 20:11 ` Meelis Roos
2014-10-16 20:11 ` Meelis Roos
2014-10-16 20:18 ` David Miller
2014-10-16 20:18 ` David Miller
2014-10-16 20:18 ` David Miller
2014-10-16 21:38 ` Meelis Roos
2014-10-16 21:38 ` Meelis Roos
2014-10-19 4:32 ` David Miller
2014-10-19 4:32 ` David Miller
2014-10-19 7:07 ` Meelis Roos
2014-10-19 7:07 ` Meelis Roos
2014-10-20 18:57 ` David Miller
2014-10-20 18:57 ` David Miller
2014-10-22 20:39 ` David Miller
2014-10-22 20:39 ` David Miller
2014-10-22 23:22 ` Meelis Roos
2014-10-22 23:22 ` Meelis Roos
2014-10-23 17:02 ` David Miller
2014-10-23 17:02 ` David Miller
2014-10-23 21:22 ` David Miller
2014-10-23 21:22 ` David Miller
2014-10-24 4:54 ` Sam Ravnborg [this message]
2014-10-24 4:54 ` Sam Ravnborg
2014-10-24 16:53 ` David Miller
2014-10-24 16:53 ` David Miller
2014-10-24 7:49 ` Meelis Roos
2014-10-24 7:49 ` Meelis Roos
2014-10-24 16:45 ` David Miller
2014-10-24 16:45 ` David Miller
2014-10-16 7:02 ` Meelis Roos
2014-10-16 7:02 ` Meelis Roos
2014-10-16 7:02 ` Meelis Roos
2014-10-16 20:07 ` David Miller
2014-10-16 20:07 ` David Miller
2014-10-16 20:07 ` David Miller
2014-10-16 20:16 ` Meelis Roos
2014-10-16 20:16 ` Meelis Roos
2014-10-16 20:16 ` Meelis Roos
2014-10-16 20:20 ` David Miller
2014-10-16 20:20 ` David Miller
2014-10-16 20:20 ` David Miller
2014-10-16 20:50 ` David Miller
2014-10-16 20:50 ` David Miller
2014-10-16 20:50 ` David Miller
2014-10-17 11:12 ` Meelis Roos
2014-10-17 11:12 ` Meelis Roos
2014-10-17 11:12 ` Meelis Roos
2014-10-18 17:59 ` David Miller
2014-10-18 17:59 ` David Miller
2014-10-18 17:59 ` David Miller
2014-10-18 18:23 ` David Miller
2014-10-18 18:23 ` David Miller
2014-10-18 18:23 ` David Miller
2014-10-19 12:31 ` Meelis Roos
2014-10-19 12:31 ` Meelis Roos
2014-10-19 12:31 ` Meelis Roos
2014-10-19 17:12 ` Meelis Roos
2014-10-19 17:12 ` Meelis Roos
2014-10-19 17:12 ` Meelis Roos
2014-10-19 17:18 ` David Miller
2014-10-19 17:18 ` David Miller
2014-10-19 17:18 ` David Miller
2014-10-19 15:32 ` Sam Ravnborg
2014-10-19 15:32 ` Sam Ravnborg
2014-10-19 15:32 ` Sam Ravnborg
2014-10-19 17:27 ` David Miller
2014-10-19 17:27 ` David Miller
2014-10-19 17:27 ` David Miller
2014-10-19 19:55 ` Sam Ravnborg
2014-10-19 19:55 ` Sam Ravnborg
2014-10-19 19:55 ` Sam Ravnborg
2014-10-16 20:20 ` Meelis Roos
2014-10-16 20:20 ` Meelis Roos
2014-10-16 20:20 ` Meelis Roos
2014-10-16 20:40 ` Meelis Roos
2014-10-16 20:40 ` Meelis Roos
2014-10-16 20:40 ` Meelis Roos
2014-10-12 17:22 ` Joonsoo Kim
2014-10-12 17:22 ` Joonsoo Kim
2014-10-12 17:30 ` David Miller
2014-10-12 17:30 ` David Miller
2014-10-12 17:43 ` Joonsoo Kim
2014-10-12 17:43 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024045454.GA8138@ravnborg.org \
--to=sam@ravnborg.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.