From: Sam Ravnborg <sam@ravnborg.org>
To: David Miller <davem@davemloft.net>
Cc: mroos@linux.ee, iamjoonsoo.kim@lge.com,
linux-kernel@vger.kernel.org, cl@linux.com, penberg@kernel.org,
rientjes@google.com, akpm@linux-foundation.org,
linux-mm@kvack.org, sparclinux@vger.kernel.org
Subject: Re: unaligned accesses in SLAB etc.
Date: Sun, 19 Oct 2014 19:55:53 +0000 [thread overview]
Message-ID: <20141019195553.GA11365@ravnborg.org> (raw)
In-Reply-To: <20141019.132737.1392053813844289431.davem@davemloft.net>
On Sun, Oct 19, 2014 at 01:27:37PM -0400, David Miller wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
> Date: Sun, 19 Oct 2014 17:32:20 +0200
>
> > This part:
> >
> >> + __attribute__ ((aligned(64)));
> >
> > Could be written as __aligned(64)
>
> I'll try to remember to sweep this up in sparc-next, thanks Sam.
>
> We probably use this long-hand form in a lot of other places in
> the sparc code too, so I'll try to do a full sweep.
Another related one would be a full sweep of "__asm__ __volatile__"
to the shorter version "asm volatile".
The latter is used in a few places in sparc already - so toolchain supports it.
I got hits in:
include/asm/irqflags_32.h: asm volatile("rd %%psr, %0" : "=r" (flags));
include/asm/processor_64.h:#define cpu_relax() asm volatile("\n99:\n\t" \
kernel/kprobes.c: asm volatile(".global kretprobe_trampoline\n"
But this would touch 93 files. Thats too much crunch :-(
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: David Miller <davem@davemloft.net>
Cc: mroos@linux.ee, iamjoonsoo.kim@lge.com,
linux-kernel@vger.kernel.org, cl@linux.com, penberg@kernel.org,
rientjes@google.com, akpm@linux-foundation.org,
linux-mm@kvack.org, sparclinux@vger.kernel.org
Subject: Re: unaligned accesses in SLAB etc.
Date: Sun, 19 Oct 2014 21:55:53 +0200 [thread overview]
Message-ID: <20141019195553.GA11365@ravnborg.org> (raw)
In-Reply-To: <20141019.132737.1392053813844289431.davem@davemloft.net>
On Sun, Oct 19, 2014 at 01:27:37PM -0400, David Miller wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
> Date: Sun, 19 Oct 2014 17:32:20 +0200
>
> > This part:
> >
> >> + __attribute__ ((aligned(64)));
> >
> > Could be written as __aligned(64)
>
> I'll try to remember to sweep this up in sparc-next, thanks Sam.
>
> We probably use this long-hand form in a lot of other places in
> the sparc code too, so I'll try to do a full sweep.
Another related one would be a full sweep of "__asm__ __volatile__"
to the shorter version "asm volatile".
The latter is used in a few places in sparc already - so toolchain supports it.
I got hits in:
include/asm/irqflags_32.h: asm volatile("rd %%psr, %0" : "=r" (flags));
include/asm/processor_64.h:#define cpu_relax() asm volatile("\n99:\n\t" \
kernel/kprobes.c: asm volatile(".global kretprobe_trampoline\n"
But this would touch 93 files. Thats too much crunch :-(
Sam
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: David Miller <davem@davemloft.net>
Cc: mroos@linux.ee, iamjoonsoo.kim@lge.com,
linux-kernel@vger.kernel.org, cl@linux.com, penberg@kernel.org,
rientjes@google.com, akpm@linux-foundation.org,
linux-mm@kvack.org, sparclinux@vger.kernel.org
Subject: Re: unaligned accesses in SLAB etc.
Date: Sun, 19 Oct 2014 21:55:53 +0200 [thread overview]
Message-ID: <20141019195553.GA11365@ravnborg.org> (raw)
In-Reply-To: <20141019.132737.1392053813844289431.davem@davemloft.net>
On Sun, Oct 19, 2014 at 01:27:37PM -0400, David Miller wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
> Date: Sun, 19 Oct 2014 17:32:20 +0200
>
> > This part:
> >
> >> + __attribute__ ((aligned(64)));
> >
> > Could be written as __aligned(64)
>
> I'll try to remember to sweep this up in sparc-next, thanks Sam.
>
> We probably use this long-hand form in a lot of other places in
> the sparc code too, so I'll try to do a full sweep.
Another related one would be a full sweep of "__asm__ __volatile__"
to the shorter version "asm volatile".
The latter is used in a few places in sparc already - so toolchain supports it.
I got hits in:
include/asm/irqflags_32.h: asm volatile("rd %%psr, %0" : "=r" (flags));
include/asm/processor_64.h:#define cpu_relax() asm volatile("\n99:\n\t" \
kernel/kprobes.c: asm volatile(".global kretprobe_trampoline\n"
But this would touch 93 files. Thats too much crunch :-(
Sam
next prev parent reply other threads:[~2014-10-19 19:55 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 2:15 unaligned accesses in SLAB etc David Miller
2014-10-12 2:15 ` David Miller
2014-10-12 17:20 ` David Miller
2014-10-12 17:20 ` David Miller
2014-10-12 17:20 ` David Miller
2014-10-13 20:22 ` mroos
2014-10-13 20:22 ` mroos
2014-10-13 20:22 ` mroos
2014-10-13 23:52 ` Joonsoo Kim
2014-10-13 23:52 ` Joonsoo Kim
2014-10-13 23:52 ` Joonsoo Kim
2014-10-14 0:04 ` David Miller
2014-10-14 0:04 ` David Miller
2014-10-14 0:04 ` David Miller
2014-10-14 0:14 ` Joonsoo Kim
2014-10-14 0:14 ` Joonsoo Kim
2014-10-14 0:14 ` Joonsoo Kim
2014-10-14 21:19 ` mroos
2014-10-14 21:19 ` mroos
2014-10-14 21:19 ` mroos
2014-10-14 21:32 ` David Miller
2014-10-14 21:32 ` David Miller
2014-10-14 21:32 ` David Miller
2014-10-15 8:04 ` Meelis Roos
2014-10-15 8:04 ` Meelis Roos
2014-10-15 8:04 ` Meelis Roos
2014-10-15 18:36 ` David Miller
2014-10-15 18:36 ` David Miller
2014-10-15 18:36 ` David Miller
2014-10-15 20:11 ` Meelis Roos
2014-10-15 20:11 ` Meelis Roos
2014-10-15 20:11 ` Meelis Roos
2014-10-16 3:11 ` David Miller
2014-10-16 3:11 ` David Miller
2014-10-16 3:11 ` David Miller
2014-10-16 7:22 ` Meelis Roos
2014-10-16 7:22 ` Meelis Roos
2014-10-16 7:22 ` Meelis Roos
2014-10-16 20:11 ` Meelis Roos
2014-10-16 20:11 ` Meelis Roos
2014-10-16 20:11 ` Meelis Roos
2014-10-16 20:18 ` David Miller
2014-10-16 20:18 ` David Miller
2014-10-16 20:18 ` David Miller
2014-10-16 21:38 ` Meelis Roos
2014-10-16 21:38 ` Meelis Roos
2014-10-19 4:32 ` David Miller
2014-10-19 4:32 ` David Miller
2014-10-19 7:07 ` Meelis Roos
2014-10-19 7:07 ` Meelis Roos
2014-10-20 18:57 ` David Miller
2014-10-20 18:57 ` David Miller
2014-10-22 20:39 ` David Miller
2014-10-22 20:39 ` David Miller
2014-10-22 23:22 ` Meelis Roos
2014-10-22 23:22 ` Meelis Roos
2014-10-23 17:02 ` David Miller
2014-10-23 17:02 ` David Miller
2014-10-23 21:22 ` David Miller
2014-10-23 21:22 ` David Miller
2014-10-24 4:54 ` Sam Ravnborg
2014-10-24 4:54 ` Sam Ravnborg
2014-10-24 16:53 ` David Miller
2014-10-24 16:53 ` David Miller
2014-10-24 7:49 ` Meelis Roos
2014-10-24 7:49 ` Meelis Roos
2014-10-24 16:45 ` David Miller
2014-10-24 16:45 ` David Miller
2014-10-16 7:02 ` Meelis Roos
2014-10-16 7:02 ` Meelis Roos
2014-10-16 7:02 ` Meelis Roos
2014-10-16 20:07 ` David Miller
2014-10-16 20:07 ` David Miller
2014-10-16 20:07 ` David Miller
2014-10-16 20:16 ` Meelis Roos
2014-10-16 20:16 ` Meelis Roos
2014-10-16 20:16 ` Meelis Roos
2014-10-16 20:20 ` David Miller
2014-10-16 20:20 ` David Miller
2014-10-16 20:20 ` David Miller
2014-10-16 20:50 ` David Miller
2014-10-16 20:50 ` David Miller
2014-10-16 20:50 ` David Miller
2014-10-17 11:12 ` Meelis Roos
2014-10-17 11:12 ` Meelis Roos
2014-10-17 11:12 ` Meelis Roos
2014-10-18 17:59 ` David Miller
2014-10-18 17:59 ` David Miller
2014-10-18 17:59 ` David Miller
2014-10-18 18:23 ` David Miller
2014-10-18 18:23 ` David Miller
2014-10-18 18:23 ` David Miller
2014-10-19 12:31 ` Meelis Roos
2014-10-19 12:31 ` Meelis Roos
2014-10-19 12:31 ` Meelis Roos
2014-10-19 17:12 ` Meelis Roos
2014-10-19 17:12 ` Meelis Roos
2014-10-19 17:12 ` Meelis Roos
2014-10-19 17:18 ` David Miller
2014-10-19 17:18 ` David Miller
2014-10-19 17:18 ` David Miller
2014-10-19 15:32 ` Sam Ravnborg
2014-10-19 15:32 ` Sam Ravnborg
2014-10-19 15:32 ` Sam Ravnborg
2014-10-19 17:27 ` David Miller
2014-10-19 17:27 ` David Miller
2014-10-19 17:27 ` David Miller
2014-10-19 19:55 ` Sam Ravnborg [this message]
2014-10-19 19:55 ` Sam Ravnborg
2014-10-19 19:55 ` Sam Ravnborg
2014-10-16 20:20 ` Meelis Roos
2014-10-16 20:20 ` Meelis Roos
2014-10-16 20:20 ` Meelis Roos
2014-10-16 20:40 ` Meelis Roos
2014-10-16 20:40 ` Meelis Roos
2014-10-16 20:40 ` Meelis Roos
2014-10-12 17:22 ` Joonsoo Kim
2014-10-12 17:22 ` Joonsoo Kim
2014-10-12 17:30 ` David Miller
2014-10-12 17:30 ` David Miller
2014-10-12 17:43 ` Joonsoo Kim
2014-10-12 17:43 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141019195553.GA11365@ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=davem@davemloft.net \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mroos@linux.ee \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.