All of lore.kernel.org
 help / color / mirror / Atom feed
From: bp@alien8.de (Borislav Petkov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework
Date: Mon, 27 Oct 2014 21:43:07 +0100	[thread overview]
Message-ID: <20141027204307.GB4741@pd.tnic> (raw)
In-Reply-To: <544E93F0.3030409@opensource.altera.com>

On Mon, Oct 27, 2014 at 01:50:24PM -0500, Thor Thayer wrote:
> Do you have any comments about this driver?

Just a question: why do you have three .c files for something which
does only error injection and nothing else AFAICT? Why isn't this part
of altera_edac.c?

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Thor Thayer <tthayer@opensource.altera.com>
Cc: dougthompson@xmission.com, m.chehab@samsung.com,
	robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	linux@arm.linux.org.uk, dinguyen@altera.com,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, tthayer.linux@gmail.com,
	tthayer@altera.com
Subject: Re: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework
Date: Mon, 27 Oct 2014 21:43:07 +0100	[thread overview]
Message-ID: <20141027204307.GB4741@pd.tnic> (raw)
In-Reply-To: <544E93F0.3030409@opensource.altera.com>

On Mon, Oct 27, 2014 at 01:50:24PM -0500, Thor Thayer wrote:
> Do you have any comments about this driver?

Just a question: why do you have three .c files for something which
does only error injection and nothing else AFAICT? Why isn't this part
of altera_edac.c?

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

  reply	other threads:[~2014-10-27 20:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-17 20:33 [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework tthayer at opensource.altera.com
2014-10-17 20:33 ` tthayer
2014-10-17 20:33 ` tthayer
2014-10-17 20:33 ` [PATCHv2 1/4] arm: socfpga: Enable L2 Cache ECC on startup tthayer at opensource.altera.com
2014-10-17 20:33   ` tthayer
2014-10-17 20:33   ` tthayer
2014-10-17 20:33 ` [PATCHv2 2/4] arm: socfpga: Enable OCRAM " tthayer at opensource.altera.com
2014-10-17 20:33   ` tthayer
2014-10-17 20:33   ` tthayer
2014-10-17 20:33 ` [PATCHv2 3/4] edac: altera: Add Altera L2 and OCRAM EDAC support tthayer at opensource.altera.com
2014-10-17 20:33   ` tthayer
2014-10-17 20:33   ` tthayer
2014-10-17 20:33 ` [PATCHv2 4/4] arm: dts: Add Altera L2 Cache and OCRAM EDAC tthayer at opensource.altera.com
2014-10-17 20:33   ` tthayer
2014-10-17 20:33   ` tthayer
2014-10-27 18:50 ` [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework Thor Thayer
2014-10-27 18:50   ` Thor Thayer
2014-10-27 18:50   ` Thor Thayer
2014-10-27 20:43   ` Borislav Petkov [this message]
2014-10-27 20:43     ` Borislav Petkov
2014-10-27 21:35     ` Thor Thayer
2014-10-27 21:35       ` Thor Thayer
2014-10-27 21:35       ` Thor Thayer
2014-10-27 21:59       ` Borislav Petkov
2014-10-27 21:59         ` Borislav Petkov
2014-10-27 22:48         ` Thor Thayer
2014-10-27 22:48           ` Thor Thayer
2014-10-27 22:48           ` Thor Thayer
2014-10-30 15:22           ` Borislav Petkov
2014-10-30 15:22             ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141027204307.GB4741@pd.tnic \
    --to=bp@alien8.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.