All of lore.kernel.org
 help / color / mirror / Atom feed
From: tthayer@opensource.altera.com (Thor Thayer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework
Date: Mon, 27 Oct 2014 17:48:17 -0500	[thread overview]
Message-ID: <544ECBB1.2040600@opensource.altera.com> (raw)
In-Reply-To: <20141027215908.GC4741@pd.tnic>


On 10/27/2014 04:59 PM, Borislav Petkov wrote:
> On Mon, Oct 27, 2014 at 04:35:00PM -0500, Thor Thayer wrote:
>> Should I move the EDAC Device probe and error handling from
>> altera_edac_mgr.c to altera_edac.c? Can I mix the MC and Device models
>> in the same file?
> Right, for basic practical reasons, I'd like to keep all functionality
> pertaining to one hw flavour in one compilation unit/one driver. We can
> always split them later if a compelling reason emerges.
>
> Thanks.
>
OK. I will make the changes.

Would the L2 cache and OCRAM specific functions also be in 
altera_edac.c? Each of these EDAC pieces is independent and can be 
compiled in without the others. I've read that the use of #ifdef's is 
discouraged and having separate files in the Makefile solves that.

Thanks for the clarification.

Thor

WARNING: multiple messages have this Message-ID (diff)
From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
To: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
Cc: dougthompson-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
	m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	tthayer-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework
Date: Mon, 27 Oct 2014 17:48:17 -0500	[thread overview]
Message-ID: <544ECBB1.2040600@opensource.altera.com> (raw)
In-Reply-To: <20141027215908.GC4741-fF5Pk5pvG8Y@public.gmane.org>


On 10/27/2014 04:59 PM, Borislav Petkov wrote:
> On Mon, Oct 27, 2014 at 04:35:00PM -0500, Thor Thayer wrote:
>> Should I move the EDAC Device probe and error handling from
>> altera_edac_mgr.c to altera_edac.c? Can I mix the MC and Device models
>> in the same file?
> Right, for basic practical reasons, I'd like to keep all functionality
> pertaining to one hw flavour in one compilation unit/one driver. We can
> always split them later if a compelling reason emerges.
>
> Thanks.
>
OK. I will make the changes.

Would the L2 cache and OCRAM specific functions also be in 
altera_edac.c? Each of these EDAC pieces is independent and can be 
compiled in without the others. I've read that the use of #ifdef's is 
discouraged and having separate files in the Makefile solves that.

Thanks for the clarification.

Thor
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Thor Thayer <tthayer@opensource.altera.com>
To: Borislav Petkov <bp@alien8.de>
Cc: <dougthompson@xmission.com>, <m.chehab@samsung.com>,
	<robh+dt@kernel.org>, <pawel.moll@arm.com>,
	<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
	<galak@codeaurora.org>, <linux@arm.linux.org.uk>,
	<dinguyen@opensource.altera.com>, <devicetree@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, <linux-edac@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <tthayer.linux@gmail.com>,
	<tthayer@altera.com>
Subject: Re: [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework
Date: Mon, 27 Oct 2014 17:48:17 -0500	[thread overview]
Message-ID: <544ECBB1.2040600@opensource.altera.com> (raw)
In-Reply-To: <20141027215908.GC4741@pd.tnic>


On 10/27/2014 04:59 PM, Borislav Petkov wrote:
> On Mon, Oct 27, 2014 at 04:35:00PM -0500, Thor Thayer wrote:
>> Should I move the EDAC Device probe and error handling from
>> altera_edac_mgr.c to altera_edac.c? Can I mix the MC and Device models
>> in the same file?
> Right, for basic practical reasons, I'd like to keep all functionality
> pertaining to one hw flavour in one compilation unit/one driver. We can
> always split them later if a compelling reason emerges.
>
> Thanks.
>
OK. I will make the changes.

Would the L2 cache and OCRAM specific functions also be in 
altera_edac.c? Each of these EDAC pieces is independent and can be 
compiled in without the others. I've read that the use of #ifdef's is 
discouraged and having separate files in the Makefile solves that.

Thanks for the clarification.

Thor

  reply	other threads:[~2014-10-27 22:48 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-17 20:33 [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework tthayer at opensource.altera.com
2014-10-17 20:33 ` tthayer
2014-10-17 20:33 ` tthayer
2014-10-17 20:33 ` [PATCHv2 1/4] arm: socfpga: Enable L2 Cache ECC on startup tthayer at opensource.altera.com
2014-10-17 20:33   ` tthayer
2014-10-17 20:33   ` tthayer
2014-10-17 20:33 ` [PATCHv2 2/4] arm: socfpga: Enable OCRAM " tthayer at opensource.altera.com
2014-10-17 20:33   ` tthayer
2014-10-17 20:33   ` tthayer
2014-10-17 20:33 ` [PATCHv2 3/4] edac: altera: Add Altera L2 and OCRAM EDAC support tthayer at opensource.altera.com
2014-10-17 20:33   ` tthayer
2014-10-17 20:33   ` tthayer
2014-10-17 20:33 ` [PATCHv2 4/4] arm: dts: Add Altera L2 Cache and OCRAM EDAC tthayer at opensource.altera.com
2014-10-17 20:33   ` tthayer
2014-10-17 20:33   ` tthayer
2014-10-27 18:50 ` [PATCHv2 0/4] Add Altera peripheral memories to EDAC framework Thor Thayer
2014-10-27 18:50   ` Thor Thayer
2014-10-27 18:50   ` Thor Thayer
2014-10-27 20:43   ` Borislav Petkov
2014-10-27 20:43     ` Borislav Petkov
2014-10-27 21:35     ` Thor Thayer
2014-10-27 21:35       ` Thor Thayer
2014-10-27 21:35       ` Thor Thayer
2014-10-27 21:59       ` Borislav Petkov
2014-10-27 21:59         ` Borislav Petkov
2014-10-27 22:48         ` Thor Thayer [this message]
2014-10-27 22:48           ` Thor Thayer
2014-10-27 22:48           ` Thor Thayer
2014-10-30 15:22           ` Borislav Petkov
2014-10-30 15:22             ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=544ECBB1.2040600@opensource.altera.com \
    --to=tthayer@opensource.altera.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.