From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver
Date: Thu, 27 Nov 2014 20:15:52 +0100 [thread overview]
Message-ID: <20141127191552.GS25249@lukather> (raw)
In-Reply-To: <20141127174056.6697cde3@bbrezillon>
On Thu, Nov 27, 2014 at 05:40:56PM +0100, Boris Brezillon wrote:
> Hi,
>
> On Wed, 26 Nov 2014 22:13:18 +0100
> Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
>
> [...]
>
> >
> > I remember someone (Chen-Yu? Boris?) saying that the 1wire clock was
> > not really a mod0 clk. From what I could gather from the source code,
> > it seems to have a wider m divider, so we could argue that it should
> > need a new compatible.
>
> Wasn't me :-).
>
> Regarding the rest of the discussion I miss some context, but here's
> what I remember decided us to choose the MFD approach for the PRCM
> block:
>
> 1) it's embedding several unrelated functional blocks (reset, clk, and
> some other things I don't remember).
> 2) none of the functionalities provided by the PRCM were required in
> the early boot stage
> 3) We wanted to represent the HW blocks as they are really described in
> the memory mapping instead of splitting small register chunks over the
> DT.
>
> Can someone sum-up the current issue you're trying to solve ?
There's (at least) one module0 clock exposed in the PRCM block. We
have a disagreement on whether all module0 clocks should be platform
drivers to support probing that one clock or just to introduce a new
compatible for that one clock in the PRCM alone.
> IMHO, if you really want to split those functionalities over the DT
> (some nodes under clks and other under reset controller), then I
> suggest to use..............
> (Maxime, please stop smiling :P)
> ..............
>
> SYSCON
We don't really need to share anything, these components are isolated
in separate registers, so syscon doesn't really bring anything here.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141127/fd9fdb79/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Boris Brezillon
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Boris Brezillon
<boris-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Emilio Lopez <emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>,
Linux Media Mailing List
<linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver
Date: Thu, 27 Nov 2014 20:15:52 +0100 [thread overview]
Message-ID: <20141127191552.GS25249@lukather> (raw)
In-Reply-To: <20141127174056.6697cde3@bbrezillon>
[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]
On Thu, Nov 27, 2014 at 05:40:56PM +0100, Boris Brezillon wrote:
> Hi,
>
> On Wed, 26 Nov 2014 22:13:18 +0100
> Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
>
> [...]
>
> >
> > I remember someone (Chen-Yu? Boris?) saying that the 1wire clock was
> > not really a mod0 clk. From what I could gather from the source code,
> > it seems to have a wider m divider, so we could argue that it should
> > need a new compatible.
>
> Wasn't me :-).
>
> Regarding the rest of the discussion I miss some context, but here's
> what I remember decided us to choose the MFD approach for the PRCM
> block:
>
> 1) it's embedding several unrelated functional blocks (reset, clk, and
> some other things I don't remember).
> 2) none of the functionalities provided by the PRCM were required in
> the early boot stage
> 3) We wanted to represent the HW blocks as they are really described in
> the memory mapping instead of splitting small register chunks over the
> DT.
>
> Can someone sum-up the current issue you're trying to solve ?
There's (at least) one module0 clock exposed in the PRCM block. We
have a disagreement on whether all module0 clocks should be platform
drivers to support probing that one clock or just to introduce a new
compatible for that one clock in the PRCM alone.
> IMHO, if you really want to split those functionalities over the DT
> (some nodes under clks and other under reset controller), then I
> suggest to use..............
> (Maxime, please stop smiling :P)
> ..............
>
> SYSCON
We don't really need to share anything, these components are isolated
in separate registers, so syscon doesn't really bring anything here.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Boris Brezillon <boris@free-electrons.com>,
Mike Turquette <mturquette@linaro.org>,
Chen-Yu Tsai <wens@csie.org>, Emilio Lopez <emilio@elopez.com.ar>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
devicetree <devicetree@vger.kernel.org>,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver
Date: Thu, 27 Nov 2014 20:15:52 +0100 [thread overview]
Message-ID: <20141127191552.GS25249@lukather> (raw)
In-Reply-To: <20141127174056.6697cde3@bbrezillon>
[-- Attachment #1: Type: text/plain, Size: 1832 bytes --]
On Thu, Nov 27, 2014 at 05:40:56PM +0100, Boris Brezillon wrote:
> Hi,
>
> On Wed, 26 Nov 2014 22:13:18 +0100
> Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
>
> [...]
>
> >
> > I remember someone (Chen-Yu? Boris?) saying that the 1wire clock was
> > not really a mod0 clk. From what I could gather from the source code,
> > it seems to have a wider m divider, so we could argue that it should
> > need a new compatible.
>
> Wasn't me :-).
>
> Regarding the rest of the discussion I miss some context, but here's
> what I remember decided us to choose the MFD approach for the PRCM
> block:
>
> 1) it's embedding several unrelated functional blocks (reset, clk, and
> some other things I don't remember).
> 2) none of the functionalities provided by the PRCM were required in
> the early boot stage
> 3) We wanted to represent the HW blocks as they are really described in
> the memory mapping instead of splitting small register chunks over the
> DT.
>
> Can someone sum-up the current issue you're trying to solve ?
There's (at least) one module0 clock exposed in the PRCM block. We
have a disagreement on whether all module0 clocks should be platform
drivers to support probing that one clock or just to introduce a new
compatible for that one clock in the PRCM alone.
> IMHO, if you really want to split those functionalities over the DT
> (some nodes under clks and other under reset controller), then I
> suggest to use..............
> (Maxime, please stop smiling :P)
> ..............
>
> SYSCON
We don't really need to share anything, these components are isolated
in separate registers, so syscon doesn't really bring anything here.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-27 19:15 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 15:55 [PATCH 0/9] sun6i / A31 ir receiver support Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 15:55 ` [PATCH 1/9] clk: sunxi: Give sunxi_factors_register a registers parameter Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-21 8:35 ` Maxime Ripard
2014-11-21 8:35 ` Maxime Ripard
2014-11-21 8:44 ` Hans de Goede
2014-11-21 8:44 ` Hans de Goede
2014-11-21 8:44 ` Hans de Goede
2014-11-21 11:15 ` Maxime Ripard
2014-11-21 11:15 ` Maxime Ripard
2014-11-21 11:15 ` Maxime Ripard
2014-11-20 15:55 ` [PATCH 2/9] clk: sunxi: Make sun4i_a10_mod0_data available outside of clk-mod0.c Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 15:55 ` [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 18:24 ` [linux-sunxi] " Chen-Yu Tsai
2014-11-20 18:24 ` Chen-Yu Tsai
2014-11-20 18:24 ` Chen-Yu Tsai
2014-11-20 19:32 ` [linux-sunxi] " Hans de Goede
2014-11-20 19:32 ` Hans de Goede
2014-11-20 19:32 ` Hans de Goede
2014-11-21 8:49 ` Maxime Ripard
2014-11-21 8:49 ` Maxime Ripard
2014-11-21 8:49 ` Maxime Ripard
2014-11-21 9:13 ` Hans de Goede
2014-11-21 9:13 ` Hans de Goede
2014-11-21 9:13 ` Hans de Goede
2014-11-24 22:03 ` Maxime Ripard
2014-11-24 22:03 ` Maxime Ripard
2014-11-24 22:03 ` Maxime Ripard
2014-11-25 8:29 ` Hans de Goede
2014-11-25 8:29 ` Hans de Goede
2014-11-25 8:29 ` Hans de Goede
2014-11-25 8:37 ` Hans de Goede
2014-11-25 8:37 ` Hans de Goede
2014-11-25 8:37 ` Hans de Goede
2014-11-26 21:13 ` Maxime Ripard
2014-11-26 21:13 ` Maxime Ripard
2014-11-26 21:13 ` Maxime Ripard
2014-11-27 8:41 ` Hans de Goede
2014-11-27 8:41 ` Hans de Goede
2014-11-27 8:41 ` Hans de Goede
2014-11-27 9:28 ` Chen-Yu Tsai
2014-11-27 9:28 ` Chen-Yu Tsai
2014-11-27 9:28 ` Chen-Yu Tsai
2014-11-27 10:10 ` Hans de Goede
2014-11-27 10:10 ` Hans de Goede
2014-11-27 10:10 ` Hans de Goede
2014-11-27 19:05 ` Maxime Ripard
2014-11-27 19:05 ` Maxime Ripard
2014-11-27 19:05 ` Maxime Ripard
2014-11-28 13:37 ` Hans de Goede
2014-11-28 13:37 ` Hans de Goede
2014-11-28 13:37 ` Hans de Goede
2014-12-02 15:45 ` Maxime Ripard
2014-12-02 15:45 ` Maxime Ripard
2014-12-02 15:45 ` Maxime Ripard
2014-12-03 9:49 ` Hans de Goede
2014-12-03 9:49 ` Hans de Goede
2014-12-03 9:49 ` Hans de Goede
2014-12-07 18:08 ` Maxime Ripard
2014-12-07 18:08 ` Maxime Ripard
2014-12-07 18:08 ` Maxime Ripard
2014-12-08 8:19 ` Hans de Goede
2014-12-08 8:19 ` Hans de Goede
2014-12-08 8:19 ` Hans de Goede
2014-12-09 8:51 ` Maxime Ripard
2014-12-09 8:51 ` Maxime Ripard
2014-12-09 8:51 ` Maxime Ripard
2014-11-27 18:51 ` Maxime Ripard
2014-11-27 18:51 ` Maxime Ripard
2014-11-27 18:51 ` Maxime Ripard
2014-11-27 16:40 ` Boris Brezillon
2014-11-27 16:40 ` Boris Brezillon
2014-11-27 16:40 ` Boris Brezillon
2014-11-27 19:15 ` Maxime Ripard [this message]
2014-11-27 19:15 ` Maxime Ripard
2014-11-27 19:15 ` Maxime Ripard
2014-11-20 15:55 ` [PATCH 4/9] rc: sunxi-cir: Add support for an optional reset controller Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 16:28 ` Mauro Carvalho Chehab
2014-11-20 16:28 ` Mauro Carvalho Chehab
2014-11-21 8:51 ` Maxime Ripard
2014-11-21 8:51 ` Maxime Ripard
2014-11-21 8:51 ` Maxime Ripard
2014-11-20 23:05 ` [linux-sunxi] " Julian Calaby
2014-11-20 23:05 ` Julian Calaby
2014-11-20 23:05 ` Julian Calaby
2014-11-20 15:55 ` [PATCH 5/9] rc: sunxi-cir: Add support for the larger fifo found on sun5i and sun6i Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 16:28 ` Mauro Carvalho Chehab
2014-11-20 16:28 ` Mauro Carvalho Chehab
2014-11-21 8:26 ` Maxime Ripard
2014-11-21 8:26 ` Maxime Ripard
2014-11-21 8:42 ` Hans de Goede
2014-11-21 8:42 ` Hans de Goede
2014-11-21 8:42 ` Hans de Goede
2014-11-21 9:59 ` Maxime Ripard
2014-11-21 9:59 ` Maxime Ripard
2014-11-21 9:59 ` Maxime Ripard
2014-11-21 10:13 ` Hans de Goede
2014-11-21 10:13 ` Hans de Goede
2014-11-21 10:13 ` Hans de Goede
2014-11-23 15:47 ` Maxime Ripard
2014-11-23 15:47 ` Maxime Ripard
2014-11-23 15:47 ` Maxime Ripard
2014-11-20 15:55 ` [PATCH 6/9] ARM: dts: sun6i: Add ir_clk node Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 15:55 ` [PATCH 7/9] ARM: dts: sun6i: Add ir node Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 15:55 ` [PATCH 8/9] ARM: dts: sun6i: Add pinmux settings for the ir pins Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 15:55 ` [PATCH 9/9] ARM: dts: sun6i: Enable ir receiver on the Mele M9 Hans de Goede
2014-11-20 15:55 ` Hans de Goede
2014-11-20 15:55 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141127191552.GS25249@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.