All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Mason <mpeg.blue@free.fr>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
	cpufreq <cpufreq@vger.kernel.org>,
	Linux PM <linux-pm@vger.kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	John Stultz <john.stultz@linaro.org>,
	Stefan Agner <stefan@agner.ch>, Shawn Guo <shawn.guo@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: Delays, clocks, timers, hrtimers, etc
Date: Wed, 11 Feb 2015 15:26:31 -0800	[thread overview]
Message-ID: <20150211232631.GE11190@codeaurora.org> (raw)
In-Reply-To: <54DBD095.3040800@free.fr>

On 02/11, Mason wrote:
> 
> Looking at the difference between OF and !OF registration functions
> in smp_twd.c
> 
> !OF
>   if (twd_base || twd_evt) return -EBUSY;
>   assign twd_ppi and twd_base
>   twd_local_timer_common_register(NULL)
> 
> OF
>   if (!is_smp() || !setup_max_cpus) return; // TO BE DELETED
>   assign twd_ppi and twd_base
>   twd_local_timer_common_register(np)
> 
> I suppose OF guarantees that the init code is called only once?

It's called as many times as there's a match with the
corresponding CLOCKSOURCE_OF_DECLARE. In practice that's once.

> (Hence the !OF guard code would be unnecessary.)
> 

The other difference is that OF based registration needs to use
OF functions for irqs and ioremap whereas the non-OF code relies
on the irqs being provided before hand and the ioremap done
without OF functions.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: Delays, clocks, timers, hrtimers, etc
Date: Wed, 11 Feb 2015 15:26:31 -0800	[thread overview]
Message-ID: <20150211232631.GE11190@codeaurora.org> (raw)
In-Reply-To: <54DBD095.3040800@free.fr>

On 02/11, Mason wrote:
> 
> Looking at the difference between OF and !OF registration functions
> in smp_twd.c
> 
> !OF
>   if (twd_base || twd_evt) return -EBUSY;
>   assign twd_ppi and twd_base
>   twd_local_timer_common_register(NULL)
> 
> OF
>   if (!is_smp() || !setup_max_cpus) return; // TO BE DELETED
>   assign twd_ppi and twd_base
>   twd_local_timer_common_register(np)
> 
> I suppose OF guarantees that the init code is called only once?

It's called as many times as there's a match with the
corresponding CLOCKSOURCE_OF_DECLARE. In practice that's once.

> (Hence the !OF guard code would be unnecessary.)
> 

The other difference is that OF based registration needs to use
OF functions for irqs and ioremap whereas the non-OF code relies
on the irqs being provided before hand and the ioremap done
without OF functions.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2015-02-11 23:26 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 13:16 Delays, clocks, timers, hrtimers, etc Mason
2015-01-28 13:16 ` Mason
2015-01-29 13:57 ` Mason
2015-01-29 13:57   ` Mason
2015-02-03 12:09 ` Russell King - ARM Linux
2015-02-03 12:09   ` Russell King - ARM Linux
2015-02-06 18:37   ` Mason
2015-02-06 18:37     ` Mason
2015-02-06 19:14     ` Russell King - ARM Linux
2015-02-06 19:14       ` Russell King - ARM Linux
2015-02-06 21:03       ` Mason
2015-02-06 21:03         ` Mason
2015-02-07 10:42         ` Russell King - ARM Linux
2015-02-07 10:42           ` Russell King - ARM Linux
2015-02-09  7:45       ` Michal Simek
2015-02-09  7:45         ` Michal Simek
2015-02-09 16:10         ` Sören Brinkmann
2015-02-09 16:10           ` Sören Brinkmann
2015-02-09 23:27   ` Mason
2015-02-09 23:27     ` Mason
2015-02-06 20:25 ` Stefan Agner
2015-02-06 20:25   ` Stefan Agner
2015-02-06 21:17   ` Mason
2015-02-06 21:17     ` Mason
2015-02-06 21:31     ` Stefan Agner
2015-02-06 21:31       ` Stefan Agner
2015-02-07  2:21       ` Mason
2015-02-07  2:21         ` Mason
2015-02-07  9:51         ` Russell King - ARM Linux
2015-02-07  9:51           ` Russell King - ARM Linux
2015-02-09 19:01         ` Stephen Boyd
2015-02-09 19:01           ` Stephen Boyd
2015-02-09 22:31           ` Mason
2015-02-09 22:31             ` Mason
2015-02-09 23:17             ` Stephen Boyd
2015-02-09 23:17               ` Stephen Boyd
2015-02-09 23:50               ` Mason
2015-02-09 23:50                 ` Mason
2015-02-11 17:43                 ` Mason
2015-02-11 17:43                   ` Mason
2015-02-11 18:45                   ` Stephen Boyd
2015-02-11 18:45                     ` Stephen Boyd
2015-02-11 21:58                     ` Mason
2015-02-11 21:58                       ` Mason
2015-02-11 23:26                       ` Stephen Boyd [this message]
2015-02-11 23:26                         ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150211232631.GE11190@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=cpufreq@vger.kernel.org \
    --cc=john.stultz@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=mpeg.blue@free.fr \
    --cc=peterz@infradead.org \
    --cc=robh@kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=stefan@agner.ch \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.