All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <fengguang.wu@intel.com>
To: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
Cc: kbuild-all@01.org, Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Andy Shevchenko <andy.schevchenko@gmail.com>,
	"Ong, Boon Leong" <boon.leong.ong@intel.com>,
	Darren Hart <dvhart@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] x86/intel/quark: fix simple_return.cocci warnings
Date: Thu, 19 Feb 2015 16:14:32 +0800	[thread overview]
Message-ID: <20150219081432.GA21996@waimea> (raw)
In-Reply-To: <201502191606.pTcFEBOs%fengguang.wu@intel.com>

arch/x86/platform/intel-quark/imr.c:129:1-4: WARNING: end returns can be simpified

 Simplify a trivial if-return sequence.  Possibly combine with a
 preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci

CC: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 imr.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

--- a/arch/x86/platform/intel-quark/imr.c
+++ b/arch/x86/platform/intel-quark/imr.c
@@ -126,12 +126,8 @@ static int imr_read(struct imr_device *i
 	if (ret)
 		return ret;
 
-	ret = iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
+	return iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
 				reg++, &imr->wmask);
-	if (ret)
-		return ret;
-
-	return 0;
 }
 
 /**

  parent reply	other threads:[~2015-02-19  8:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201502191606.pTcFEBOs%fengguang.wu@intel.com>
2015-02-19  8:14 ` [PATCH] x86/intel/quark: fix ptr_ret.cocci warnings kbuild test robot
2015-02-19 10:12   ` Bryan O'Donoghue
2015-02-19 11:31   ` [tip:x86/platform] x86/intel/quark: Fix " tip-bot for Fengguang Wu
2015-02-19  8:14 ` kbuild test robot [this message]
2015-02-19 10:11   ` [PATCH] x86/intel/quark: fix simple_return.cocci warnings Bryan O'Donoghue
2015-02-19 10:25     ` Ingo Molnar
2015-02-19 10:31       ` Bryan O'Donoghue
2015-02-19 10:33         ` Ingo Molnar
2015-02-19 11:01           ` Bryan O'Donoghue
2015-02-19 11:31   ` [tip:x86/platform] x86/intel/quark: Fix " tip-bot for Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150219081432.GA21996@waimea \
    --to=fengguang.wu@intel.com \
    --cc=andy.schevchenko@gmail.com \
    --cc=boon.leong.ong@intel.com \
    --cc=dvhart@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pure.logic@nexus-software.ie \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.