From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
To: Ingo Molnar <mingo@kernel.org>
Cc: kbuild test robot <fengguang.wu@intel.com>,
kbuild-all@01.org, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Andy Shevchenko <andy.schevchenko@gmail.com>,
"Ong, Boon Leong" <boon.leong.ong@intel.com>,
Darren Hart <dvhart@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/intel/quark: fix simple_return.cocci warnings
Date: Thu, 19 Feb 2015 11:01:59 +0000 [thread overview]
Message-ID: <54E5C2A7.3060405@nexus-software.ie> (raw)
In-Reply-To: <20150219103344.GD2819@gmail.com>
On 19/02/15 10:33, Ingo Molnar wrote:
>> Feedback at review was that it's more consistent with the
>> code that comes before.
>
> But that feedback makes very little sense. In C we don't
> ever want to write:
>
> if (ret)
> return ret;
>
> return 0;
>
> Because we can return the fine value straight away:
>
> return ret;
>
> regardless of what comes before.
:)
Just trying to accommodate as much feedback from people as possible.
I'm fine with the change and I'll let Andy argue the counter-point if he
wants to.
--
Bryan
next prev parent reply other threads:[~2015-02-19 11:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201502191606.pTcFEBOs%fengguang.wu@intel.com>
2015-02-19 8:14 ` [PATCH] x86/intel/quark: fix ptr_ret.cocci warnings kbuild test robot
2015-02-19 10:12 ` Bryan O'Donoghue
2015-02-19 11:31 ` [tip:x86/platform] x86/intel/quark: Fix " tip-bot for Fengguang Wu
2015-02-19 8:14 ` [PATCH] x86/intel/quark: fix simple_return.cocci warnings kbuild test robot
2015-02-19 10:11 ` Bryan O'Donoghue
2015-02-19 10:25 ` Ingo Molnar
2015-02-19 10:31 ` Bryan O'Donoghue
2015-02-19 10:33 ` Ingo Molnar
2015-02-19 11:01 ` Bryan O'Donoghue [this message]
2015-02-19 11:31 ` [tip:x86/platform] x86/intel/quark: Fix " tip-bot for Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E5C2A7.3060405@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=andy.schevchenko@gmail.com \
--cc=boon.leong.ong@intel.com \
--cc=dvhart@linux.intel.com \
--cc=fengguang.wu@intel.com \
--cc=hpa@zytor.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.