From: tip-bot for Fengguang Wu <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
dvhart@linux.intel.com, tglx@linutronix.de, hpa@zytor.com,
andy.schevchenko@gmail.com, fengguang.wu@intel.com,
pure.logic@nexus-software.ie, boon.leong.ong@intel.com
Subject: [tip:x86/platform] x86/intel/quark: Fix simple_return.cocci warnings
Date: Thu, 19 Feb 2015 03:31:49 -0800 [thread overview]
Message-ID: <tip-c11a25f443e9bee06fe302b6a78ff44dac554036@git.kernel.org> (raw)
In-Reply-To: <20150219081432.GA21996@waimea>
Commit-ID: c11a25f443e9bee06fe302b6a78ff44dac554036
Gitweb: http://git.kernel.org/tip/c11a25f443e9bee06fe302b6a78ff44dac554036
Author: Fengguang Wu <fengguang.wu@intel.com>
AuthorDate: Thu, 19 Feb 2015 16:14:32 +0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 19 Feb 2015 10:00:55 +0100
x86/intel/quark: Fix simple_return.cocci warnings
arch/x86/platform/intel-quark/imr.c:129:1-4: WARNING: end returns can be simpified
Simplify a trivial if-return sequence. Possibly combine with a preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Andy Shevchenko <andy.schevchenko@gmail.com>
Cc: Ong, Boon Leong <boon.leong.ong@intel.com>
Cc: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Cc: Darren Hart <dvhart@linux.intel.com>
Cc: kbuild-all@01.org
Link: http://lkml.kernel.org/r/20150219081432.GA21996@waimea
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/platform/intel-quark/imr.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/arch/x86/platform/intel-quark/imr.c b/arch/x86/platform/intel-quark/imr.c
index 60c01eb..0ee619f 100644
--- a/arch/x86/platform/intel-quark/imr.c
+++ b/arch/x86/platform/intel-quark/imr.c
@@ -126,12 +126,8 @@ static int imr_read(struct imr_device *idev, u32 imr_id, struct imr_regs *imr)
if (ret)
return ret;
- ret = iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
+ return iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
reg++, &imr->wmask);
- if (ret)
- return ret;
-
- return 0;
}
/**
next prev parent reply other threads:[~2015-02-19 11:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201502191606.pTcFEBOs%fengguang.wu@intel.com>
2015-02-19 8:14 ` [PATCH] x86/intel/quark: fix simple_return.cocci warnings kbuild test robot
2015-02-19 10:11 ` Bryan O'Donoghue
2015-02-19 10:25 ` Ingo Molnar
2015-02-19 10:31 ` Bryan O'Donoghue
2015-02-19 10:33 ` Ingo Molnar
2015-02-19 11:01 ` Bryan O'Donoghue
2015-02-19 11:31 ` tip-bot for Fengguang Wu [this message]
2015-02-19 8:14 ` [PATCH] x86/intel/quark: fix ptr_ret.cocci warnings kbuild test robot
2015-02-19 10:12 ` Bryan O'Donoghue
2015-02-19 11:31 ` [tip:x86/platform] x86/intel/quark: Fix " tip-bot for Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-c11a25f443e9bee06fe302b6a78ff44dac554036@git.kernel.org \
--to=tipbot@zytor.com \
--cc=andy.schevchenko@gmail.com \
--cc=boon.leong.ong@intel.com \
--cc=dvhart@linux.intel.com \
--cc=fengguang.wu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pure.logic@nexus-software.ie \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.