From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] ahci: st: Update the DT example for how to obtain the PHY.
Date: Wed, 25 Feb 2015 15:08:53 +0000 [thread overview]
Message-ID: <20150225150853.GC5132@x1> (raw)
In-Reply-To: <CAL_JsqLbQWK-iZ+bH7SJzUjUZzYkdPVoDFSjaFd9TS29YOVQkA@mail.gmail.com>
On Wed, 25 Feb 2015, Rob Herring wrote:
> On Wed, Feb 25, 2015 at 7:36 AM, Peter Griffin <peter.griffin@linaro.org> wrote:
> > The example is wrong in that the phys property should take a
> > phandle to the phy port.
> >
> > Also with the changing over to generic PHY type constants we also
> > update this as well.
> >
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
>
> We seem to have a variety of ways to describe phy's with SATA
> controllers. Some consistency would have been nice.
This way is the correct way. I worked closely with Kishon to get it
right. He even used this code as an example at ELC, Dusseldorf.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Peter Griffin
<peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Srinivas Kandagatla
<srinivas.kandagatla-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Maxime Coquelin <maxime.coquelin-qxv4g6HH51o@public.gmane.org>,
patrice.chotard-qxv4g6HH51o@public.gmane.org,
Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/6] ahci: st: Update the DT example for how to obtain the PHY.
Date: Wed, 25 Feb 2015 15:08:53 +0000 [thread overview]
Message-ID: <20150225150853.GC5132@x1> (raw)
In-Reply-To: <CAL_JsqLbQWK-iZ+bH7SJzUjUZzYkdPVoDFSjaFd9TS29YOVQkA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wed, 25 Feb 2015, Rob Herring wrote:
> On Wed, Feb 25, 2015 at 7:36 AM, Peter Griffin <peter.griffin@linaro.org> wrote:
> > The example is wrong in that the phys property should take a
> > phandle to the phy port.
> >
> > Also with the changing over to generic PHY type constants we also
> > update this as well.
> >
> > Signed-off-by: Peter Griffin <peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> We seem to have a variety of ways to describe phy's with SATA
> controllers. Some consistency would have been nice.
This way is the correct way. I worked closely with Kishon to get it
right. He even used this code as an example at ELC, Dusseldorf.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Rob Herring <robherring2@gmail.com>
Cc: Peter Griffin <peter.griffin@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
Maxime Coquelin <maxime.coquelin@st.com>,
patrice.chotard@st.com, Kishon Vijay Abraham I <kishon@ti.com>,
Felipe Balbi <balbi@ti.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/6] ahci: st: Update the DT example for how to obtain the PHY.
Date: Wed, 25 Feb 2015 15:08:53 +0000 [thread overview]
Message-ID: <20150225150853.GC5132@x1> (raw)
In-Reply-To: <CAL_JsqLbQWK-iZ+bH7SJzUjUZzYkdPVoDFSjaFd9TS29YOVQkA@mail.gmail.com>
On Wed, 25 Feb 2015, Rob Herring wrote:
> On Wed, Feb 25, 2015 at 7:36 AM, Peter Griffin <peter.griffin@linaro.org> wrote:
> > The example is wrong in that the phys property should take a
> > phandle to the phy port.
> >
> > Also with the changing over to generic PHY type constants we also
> > update this as well.
> >
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
>
> We seem to have a variety of ways to describe phy's with SATA
> controllers. Some consistency would have been nice.
This way is the correct way. I worked closely with Kishon to get it
right. He even used this code as an example at ELC, Dusseldorf.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-02-25 15:08 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 13:36 [PATCH 0/6] Add dwc3 usb3 DT node and various phy cleanup Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 13:36 ` [PATCH 1/6] phy: miphy365x: Use the generic phy type constants in dt-bindings/phy/phy.h Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 14:36 ` Rob Herring
2015-02-25 14:36 ` Rob Herring
2015-02-27 10:41 ` Peter Griffin
2015-02-27 10:41 ` Peter Griffin
2015-02-25 15:15 ` Lee Jones
2015-02-25 15:15 ` Lee Jones
2015-02-25 13:36 ` [PATCH 2/6] ahci: st: Update the DT example for how to obtain the PHY Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 14:33 ` Rob Herring
2015-02-25 14:33 ` Rob Herring
2015-02-25 15:08 ` Lee Jones [this message]
2015-02-25 15:08 ` Lee Jones
2015-02-25 15:08 ` Lee Jones
2015-02-25 15:13 ` Lee Jones
2015-02-25 15:13 ` Lee Jones
2015-02-25 13:36 ` [PATCH 3/6] ARM: DT: STi: STiH407: Update picophyreset for the usb3 controllers usb2 phy Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 15:13 ` Lee Jones
2015-02-25 15:13 ` Lee Jones
2015-02-25 13:36 ` [PATCH 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 15:12 ` Lee Jones
2015-02-25 15:12 ` Lee Jones
2015-02-25 15:22 ` Peter Griffin
2015-02-25 15:22 ` Peter Griffin
2015-02-25 15:22 ` Peter Griffin
2015-02-25 15:50 ` Lee Jones
2015-02-25 15:50 ` Lee Jones
2015-02-27 10:43 ` Peter Griffin
2015-02-27 10:43 ` Peter Griffin
2015-03-03 10:16 ` Maxime Coquelin
2015-03-03 10:16 ` Maxime Coquelin
2015-03-03 10:16 ` Maxime Coquelin
2015-03-04 14:29 ` Maxime Coquelin
2015-03-04 14:29 ` Maxime Coquelin
2015-03-04 14:29 ` Maxime Coquelin
2015-02-25 13:36 ` [PATCH 5/6] usb: dwc3: dwc3-st: Update the DT example Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 14:34 ` Rob Herring
2015-02-25 14:34 ` Rob Herring
2015-02-25 14:34 ` Rob Herring
2015-02-25 13:36 ` [PATCH 6/6] MAINTAINERS: Add phy-miphy28lp.c to ARCH/STI architecture Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 15:10 ` Lee Jones
2015-02-25 15:10 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225150853.GC5132@x1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.