All of lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node.
Date: Wed, 25 Feb 2015 15:12:29 +0000	[thread overview]
Message-ID: <20150225151229.GE5132@x1> (raw)
In-Reply-To: <1424871377-1795-5-git-send-email-peter.griffin@linaro.org>

On Wed, 25 Feb 2015, Peter Griffin wrote:

> Now that both usb2 and usb3 phy drivers, and also the ST dwc3 glue code
> are all present upstream, we can add the dwc3 DT node and have a working
> usb3 controller on stih407-b2120 and stih410-b2020.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
>  arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> index 186412d..18ff5a5 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> @@ -7,6 +7,7 @@
>   * publishhed by the Free Software Foundation.
>   */
>  #include "stih407-pinctrl.dtsi"
> +#include <dt-bindings/phy/phy.h>
>  #include <dt-bindings/reset-controller/stih407-resets.h>
>  / {
>  	#address-cells = <1>;
> @@ -336,5 +337,30 @@
>  				resets = <&softreset STIH407_MIPHY2_SOFTRESET>;
>  			};
>  		};
> +
> +		st_dwc3: dwc3 at 8f94000 {
> +			compatible	= "st,stih407-dwc3";
> +			reg		= <0x08f94000 0x1000>, <0x110 0x4>;
> +			reg-names	= "reg-glue", "syscfg-reg";
> +			st,syscfg	= <&syscfg_core>;
> +			resets		= <&powerdown STIH407_USB3_POWERDOWN>,
> +					  <&softreset STIH407_MIPHY2_SOFTRESET>;
> +			reset-names	= "powerdown",
> +					  "softreset";

Nit: What's the purpose of having these on separate lines?

Apart from that, it looks good:

Acked-by: Lee Jones <lee.jones@linaro.org>

> +			#address-cells	= <1>;
> +			#size-cells	= <1>;
> +			pinctrl-names	= "default";
> +			pinctrl-0	= <&pinctrl_usb3>;
> +			ranges;
> +
> +			dwc3: dwc3 at 9900000 {
> +				compatible	= "snps,dwc3";
> +				reg		= <0x09900000 0x100000>;
> +				interrupts	= <GIC_SPI 155 IRQ_TYPE_NONE>;
> +				dr_mode		= "host";
> +				phy-names	= "usb2-phy", "usb3-phy";
> +				phys		= <&usb2_picophy0>, <&phy_port2 PHY_TYPE_USB3>;
> +			};
> +		};
>  	};
>  };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com,
	maxime.coquelin@st.com, patrice.chotard@st.com, kishon@ti.com,
	balbi@ti.com, devicetree@vger.kernel.org
Subject: Re: [PATCH 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node.
Date: Wed, 25 Feb 2015 15:12:29 +0000	[thread overview]
Message-ID: <20150225151229.GE5132@x1> (raw)
In-Reply-To: <1424871377-1795-5-git-send-email-peter.griffin@linaro.org>

On Wed, 25 Feb 2015, Peter Griffin wrote:

> Now that both usb2 and usb3 phy drivers, and also the ST dwc3 glue code
> are all present upstream, we can add the dwc3 DT node and have a working
> usb3 controller on stih407-b2120 and stih410-b2020.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
>  arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> index 186412d..18ff5a5 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> @@ -7,6 +7,7 @@
>   * publishhed by the Free Software Foundation.
>   */
>  #include "stih407-pinctrl.dtsi"
> +#include <dt-bindings/phy/phy.h>
>  #include <dt-bindings/reset-controller/stih407-resets.h>
>  / {
>  	#address-cells = <1>;
> @@ -336,5 +337,30 @@
>  				resets = <&softreset STIH407_MIPHY2_SOFTRESET>;
>  			};
>  		};
> +
> +		st_dwc3: dwc3@8f94000 {
> +			compatible	= "st,stih407-dwc3";
> +			reg		= <0x08f94000 0x1000>, <0x110 0x4>;
> +			reg-names	= "reg-glue", "syscfg-reg";
> +			st,syscfg	= <&syscfg_core>;
> +			resets		= <&powerdown STIH407_USB3_POWERDOWN>,
> +					  <&softreset STIH407_MIPHY2_SOFTRESET>;
> +			reset-names	= "powerdown",
> +					  "softreset";

Nit: What's the purpose of having these on separate lines?

Apart from that, it looks good:

Acked-by: Lee Jones <lee.jones@linaro.org>

> +			#address-cells	= <1>;
> +			#size-cells	= <1>;
> +			pinctrl-names	= "default";
> +			pinctrl-0	= <&pinctrl_usb3>;
> +			ranges;
> +
> +			dwc3: dwc3@9900000 {
> +				compatible	= "snps,dwc3";
> +				reg		= <0x09900000 0x100000>;
> +				interrupts	= <GIC_SPI 155 IRQ_TYPE_NONE>;
> +				dr_mode		= "host";
> +				phy-names	= "usb2-phy", "usb3-phy";
> +				phys		= <&usb2_picophy0>, <&phy_port2 PHY_TYPE_USB3>;
> +			};
> +		};
>  	};
>  };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2015-02-25 15:12 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25 13:36 [PATCH 0/6] Add dwc3 usb3 DT node and various phy cleanup Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 13:36 ` [PATCH 1/6] phy: miphy365x: Use the generic phy type constants in dt-bindings/phy/phy.h Peter Griffin
2015-02-25 13:36   ` Peter Griffin
2015-02-25 14:36   ` Rob Herring
2015-02-25 14:36     ` Rob Herring
2015-02-27 10:41     ` Peter Griffin
2015-02-27 10:41       ` Peter Griffin
2015-02-25 15:15   ` Lee Jones
2015-02-25 15:15     ` Lee Jones
2015-02-25 13:36 ` [PATCH 2/6] ahci: st: Update the DT example for how to obtain the PHY Peter Griffin
2015-02-25 13:36   ` Peter Griffin
2015-02-25 13:36   ` Peter Griffin
2015-02-25 14:33   ` Rob Herring
2015-02-25 14:33     ` Rob Herring
2015-02-25 15:08     ` Lee Jones
2015-02-25 15:08       ` Lee Jones
2015-02-25 15:08       ` Lee Jones
2015-02-25 15:13   ` Lee Jones
2015-02-25 15:13     ` Lee Jones
2015-02-25 13:36 ` [PATCH 3/6] ARM: DT: STi: STiH407: Update picophyreset for the usb3 controllers usb2 phy Peter Griffin
2015-02-25 13:36   ` Peter Griffin
2015-02-25 15:13   ` Lee Jones
2015-02-25 15:13     ` Lee Jones
2015-02-25 13:36 ` [PATCH 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node Peter Griffin
2015-02-25 13:36   ` Peter Griffin
2015-02-25 15:12   ` Lee Jones [this message]
2015-02-25 15:12     ` Lee Jones
2015-02-25 15:22     ` Peter Griffin
2015-02-25 15:22       ` Peter Griffin
2015-02-25 15:22       ` Peter Griffin
2015-02-25 15:50       ` Lee Jones
2015-02-25 15:50         ` Lee Jones
2015-02-27 10:43         ` Peter Griffin
2015-02-27 10:43           ` Peter Griffin
2015-03-03 10:16           ` Maxime Coquelin
2015-03-03 10:16             ` Maxime Coquelin
2015-03-03 10:16             ` Maxime Coquelin
2015-03-04 14:29   ` Maxime Coquelin
2015-03-04 14:29     ` Maxime Coquelin
2015-03-04 14:29     ` Maxime Coquelin
2015-02-25 13:36 ` [PATCH 5/6] usb: dwc3: dwc3-st: Update the DT example Peter Griffin
2015-02-25 13:36   ` Peter Griffin
2015-02-25 14:34   ` Rob Herring
2015-02-25 14:34     ` Rob Herring
2015-02-25 14:34     ` Rob Herring
2015-02-25 13:36 ` [PATCH 6/6] MAINTAINERS: Add phy-miphy28lp.c to ARCH/STI architecture Peter Griffin
2015-02-25 13:36   ` Peter Griffin
2015-02-25 15:10   ` Lee Jones
2015-02-25 15:10     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150225151229.GE5132@x1 \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.