From: maxime.coquelin@st.com (Maxime Coquelin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node.
Date: Tue, 3 Mar 2015 11:16:33 +0100 [thread overview]
Message-ID: <54F58A01.7090806@st.com> (raw)
In-Reply-To: <20150227104353.GB9094@griffinp-ThinkPad-X1-Carbon-2nd>
Hi Peter,
On 02/27/2015 11:43 AM, Peter Griffin wrote:
> Hi Lee,
>
> On Wed, 25 Feb 2015, Lee Jones wrote:
>
>>>>> + reset-names = "powerdown",
>>>>> + "softreset";
>>>> Nit: What's the purpose of having these on separate lines?
>>> The only reason was to stay aligned with the example in
>>> Documentation/devicetree/bindings/usb/dwc3-st.txt.
>> But didn't you author that too? :)
> Yep
>
>> I would change them both. No need to force a line wrap if it's not required.
> Ok, I'll remove it from both in v2, whilst adding the acks.
Thanks. Once fixed, you can add my:
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
BR,
Maxime
>
> regards,
>
> Peter.
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Coquelin <maxime.coquelin@st.com>
To: Peter Griffin <peter.griffin@linaro.org>,
Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com,
patrice.chotard@st.com, kishon@ti.com, balbi@ti.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node.
Date: Tue, 3 Mar 2015 11:16:33 +0100 [thread overview]
Message-ID: <54F58A01.7090806@st.com> (raw)
In-Reply-To: <20150227104353.GB9094@griffinp-ThinkPad-X1-Carbon-2nd>
Hi Peter,
On 02/27/2015 11:43 AM, Peter Griffin wrote:
> Hi Lee,
>
> On Wed, 25 Feb 2015, Lee Jones wrote:
>
>>>>> + reset-names = "powerdown",
>>>>> + "softreset";
>>>> Nit: What's the purpose of having these on separate lines?
>>> The only reason was to stay aligned with the example in
>>> Documentation/devicetree/bindings/usb/dwc3-st.txt.
>> But didn't you author that too? :)
> Yep
>
>> I would change them both. No need to force a line wrap if it's not required.
> Ok, I'll remove it from both in v2, whilst adding the acks.
Thanks. Once fixed, you can add my:
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
BR,
Maxime
>
> regards,
>
> Peter.
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Coquelin <maxime.coquelin@st.com>
To: Peter Griffin <peter.griffin@linaro.org>,
Lee Jones <lee.jones@linaro.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <srinivas.kandagatla@gmail.com>,
<patrice.chotard@st.com>, <kishon@ti.com>, <balbi@ti.com>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node.
Date: Tue, 3 Mar 2015 11:16:33 +0100 [thread overview]
Message-ID: <54F58A01.7090806@st.com> (raw)
In-Reply-To: <20150227104353.GB9094@griffinp-ThinkPad-X1-Carbon-2nd>
Hi Peter,
On 02/27/2015 11:43 AM, Peter Griffin wrote:
> Hi Lee,
>
> On Wed, 25 Feb 2015, Lee Jones wrote:
>
>>>>> + reset-names = "powerdown",
>>>>> + "softreset";
>>>> Nit: What's the purpose of having these on separate lines?
>>> The only reason was to stay aligned with the example in
>>> Documentation/devicetree/bindings/usb/dwc3-st.txt.
>> But didn't you author that too? :)
> Yep
>
>> I would change them both. No need to force a line wrap if it's not required.
> Ok, I'll remove it from both in v2, whilst adding the acks.
Thanks. Once fixed, you can add my:
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
BR,
Maxime
>
> regards,
>
> Peter.
next prev parent reply other threads:[~2015-03-03 10:16 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 13:36 [PATCH 0/6] Add dwc3 usb3 DT node and various phy cleanup Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 13:36 ` [PATCH 1/6] phy: miphy365x: Use the generic phy type constants in dt-bindings/phy/phy.h Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 14:36 ` Rob Herring
2015-02-25 14:36 ` Rob Herring
2015-02-27 10:41 ` Peter Griffin
2015-02-27 10:41 ` Peter Griffin
2015-02-25 15:15 ` Lee Jones
2015-02-25 15:15 ` Lee Jones
2015-02-25 13:36 ` [PATCH 2/6] ahci: st: Update the DT example for how to obtain the PHY Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 14:33 ` Rob Herring
2015-02-25 14:33 ` Rob Herring
2015-02-25 15:08 ` Lee Jones
2015-02-25 15:08 ` Lee Jones
2015-02-25 15:08 ` Lee Jones
2015-02-25 15:13 ` Lee Jones
2015-02-25 15:13 ` Lee Jones
2015-02-25 13:36 ` [PATCH 3/6] ARM: DT: STi: STiH407: Update picophyreset for the usb3 controllers usb2 phy Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 15:13 ` Lee Jones
2015-02-25 15:13 ` Lee Jones
2015-02-25 13:36 ` [PATCH 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 15:12 ` Lee Jones
2015-02-25 15:12 ` Lee Jones
2015-02-25 15:22 ` Peter Griffin
2015-02-25 15:22 ` Peter Griffin
2015-02-25 15:22 ` Peter Griffin
2015-02-25 15:50 ` Lee Jones
2015-02-25 15:50 ` Lee Jones
2015-02-27 10:43 ` Peter Griffin
2015-02-27 10:43 ` Peter Griffin
2015-03-03 10:16 ` Maxime Coquelin [this message]
2015-03-03 10:16 ` Maxime Coquelin
2015-03-03 10:16 ` Maxime Coquelin
2015-03-04 14:29 ` Maxime Coquelin
2015-03-04 14:29 ` Maxime Coquelin
2015-03-04 14:29 ` Maxime Coquelin
2015-02-25 13:36 ` [PATCH 5/6] usb: dwc3: dwc3-st: Update the DT example Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 14:34 ` Rob Herring
2015-02-25 14:34 ` Rob Herring
2015-02-25 14:34 ` Rob Herring
2015-02-25 13:36 ` [PATCH 6/6] MAINTAINERS: Add phy-miphy28lp.c to ARCH/STI architecture Peter Griffin
2015-02-25 13:36 ` Peter Griffin
2015-02-25 15:10 ` Lee Jones
2015-02-25 15:10 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F58A01.7090806@st.com \
--to=maxime.coquelin@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.