Re: [Outreachy kernel] [PATCH v5 1/6] Staging: emxx_udc: Fix do not add new typedefs

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Feb 24, 2015 at 05:23:30PM +0300, Haneen Mohammed wrote:
> This patch fixes the following checkpatch.pl warning:"do not add new
> typedefs".
> Remove typedefs keyword and rename identifiers appropriately.
> Update related  files.
> 
> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> ---
> v5: Nothing
> v4: Replace struct with volatile union for usb_reg_access.
> v3: Remove all typedefs and create patchset from emxx_udc.
> v2: Remove typedefs appropriately and change related file.
> 
>  drivers/staging/emxx_udc/emxx_udc.c | 60 ++++++++++++++++++-------------------
>  drivers/staging/emxx_udc/emxx_udc.h | 26 ++++++++--------
>  2 files changed, 43 insertions(+), 43 deletions(-)
> 
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index 82c492f..e33ccc4 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -201,7 +201,7 @@ static u32 _nbu2ss_get_begin_ram_address(struct nbu2ss_udc *udc)
>  	u32		num, buf_type;
>  	u32		data, last_ram_adr, use_ram_size;
>  
> -	PT_EP_REGS	p_ep_regs;
> +	struct ep_regs *p_ep_regs;
>  
>  	last_ram_adr = (D_RAM_SIZE_CTRL / sizeof(u32)) * 2;
>  	use_ram_size = 0;
> @@ -394,7 +394,7 @@ static void _nbu2ss_ep_dma_exit(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep)
>  {
>  	u32		num;
>  	u32		data;
> -	PT_FC_REGS	preg = udc->p_regs;
> +	struct fc_regs	*preg = udc->p_regs;
>  
>  	if (udc->vbus_active == 0)
>  		return;		/* VBUS OFF */
> @@ -425,7 +425,7 @@ static void _nbu2ss_ep_dma_exit(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep)
>  /* Abort DMA */
>  static void _nbu2ss_ep_dma_abort(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep)
>  {
> -	PT_FC_REGS	preg = udc->p_regs;
> +	struct fc_regs	*preg = udc->p_regs;
>  
>  	_nbu2ss_bitclr(&preg->EP_DCR[ep->epnum-1].EP_DCR1, DCR1_EPn_REQEN);
>  	mdelay(DMA_DISABLE_TIME);	/* DCR1_EPn_REQEN Clear */
> @@ -443,7 +443,7 @@ static void _nbu2ss_ep_in_end(
>  {
>  	u32		data;
>  	u32		num;
> -	PT_FC_REGS	preg = udc->p_regs;
> +	struct fc_regs	*preg = udc->p_regs;
>  
>  	if (length >= sizeof(u32))
>  		return;
> @@ -567,7 +567,7 @@ static int EP0_out_PIO(struct nbu2ss_udc *udc, u8 *pBuf, u32 length)
>  	u32		i;
>  	int		nret   = 0;
>  	u32		iWordLength = 0;
> -	USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf;
> +	volatile union usb_reg_access *pBuf32 = (volatile union usb_reg_access *)pBuf;
>  
>  	/*------------------------------------------------------------*/
>  	/* Read Length */
> @@ -592,8 +592,8 @@ static int EP0_out_OverBytes(struct nbu2ss_udc *udc, u8 *pBuf, u32 length)
>  {
>  	u32		i;
>  	u32		iReadSize = 0;
> -	USB_REG_ACCESS  Temp32;
> -	USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf;
> +	volatile union usb_reg_access  Temp32;
> +	volatile union usb_reg_access  *pBuf32 = (volatile union usb_reg_access *)pBuf;

volatile is almost never needed in the kernel, and in these places it's
wrong, so please don't add it here, or in any of these cases.

thanks,

greg k-h