Re: [Outreachy kernel] [PATCH v5 2/6] Staging: emxx_udc: Remove volatile from union usb_regs_access

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Feb 24, 2015 at 05:31:07PM +0300, Haneen Mohammed wrote:
> volatile applies to a concrete variable definition, else it is useless.
> This patch removes volatile from union usb_regs_access:
> - to address compiler warning: "useless type qualifier"
> - and fix checkpatch.pl warning about using volatiles:
> "WARNING: Use of volatile is usually wrong"
> 
> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> ---
> v5: Justify the removal of volatile 
> 
>  drivers/staging/emxx_udc/emxx_udc.c | 24 ++++++++++++------------
>  drivers/staging/emxx_udc/emxx_udc.h |  2 +-
>  2 files changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index e33ccc4..c9f5e5d 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -567,7 +567,7 @@ static int EP0_out_PIO(struct nbu2ss_udc *udc, u8 *pBuf, u32 length)
>  	u32		i;
>  	int		nret   = 0;
>  	u32		iWordLength = 0;
> -	volatile union usb_reg_access *pBuf32 = (volatile union usb_reg_access *)pBuf;
> +	union usb_reg_access *pBuf32 = (union usb_reg_access *)pBuf;

Just merge this with the previous patch please.

thanks,

greg k-h