Re: [Outreachy kernel] [PATCH v5 3/6] Staging: emxx_udc: Replace custom printk macro ERR with pr_err

[Haneen Mohammed <hamohammed.sa@gmail.com>]

On Thu, Feb 26, 2015 at 03:22:12PM -0800, Greg KH wrote:
> On Tue, Feb 24, 2015 at 05:33:49PM +0300, Haneen Mohammed wrote:
> > This patch removes half custom printk macros ERR and replace it with
> > pr_err. Issue addressed by checkpathc.pl.
> > 
> > Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> > ---
> > v5: Fix spelling mistakes
> > 
> >  drivers/staging/emxx_udc/emxx_udc.c | 56 ++++++++++++++++++-------------------
> >  1 file changed, 28 insertions(+), 28 deletions(-)
> > 
> > diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> > index c9f5e5d..f33980c 100644
> > --- a/drivers/staging/emxx_udc/emxx_udc.c
> > +++ b/drivers/staging/emxx_udc/emxx_udc.c
> > @@ -115,7 +115,7 @@ static void _nbu2ss_dump_register(struct nbu2ss_udc *udc)
> >  	pr_info("=== %s()\n", __func__);
> >  
> >  	if (udc == NULL) {
> > -		ERR("%s udc == NULL\n", __func__);
> > +		pr_err("udc: %s udc == NULL\n", __func__);
> 
> As this is a driver, you should be able to use dev_err() for all of
> these statements.  Please do that instead.
> 
> thanks,
> 
> greg k-h

I did my best to look for a struct device *dev to use it in dev_err()
but in these cases I couldn't. It was either not present or uninitialized yet, so I used pr_err instead. Would that be correct or is there another way of doing it?

And thank you for reviewing the patches!
Haneen