All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Haneen Mohammed <hamohammed.sa@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v5 4/6] Staging: emxx_udc: Replace custom printk macro ERR with dev_err
Date: Thu, 26 Feb 2015 15:23:05 -0800	[thread overview]
Message-ID: <20150226232305.GA21476@kroah.com> (raw)
In-Reply-To: <dec707b02efd14b1357872334da1d0134f315aa4.1424786861.git.hamohammed.sa@gmail.com>

On Tue, Feb 24, 2015 at 05:36:18PM +0300, Haneen Mohammed wrote:
> This patch removes the other half of ERR macros that uses "printk(KERN_ERR"
> and replace them with dev_err, to fix issue addressed by checkpatch.pl.
> 
> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> ---
> v5: Fix spelling mistakes
> 
>  drivers/staging/emxx_udc/emxx_udc.c | 34 +++++++++++++++++-----------------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index f33980c..ed1d044 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -808,7 +808,7 @@ static int _nbu2ss_ep0_out_transfer(
>  		return 0;		/* Short Packet Transfer End */
>  
>  	if (req->req.actual > req->req.length) {
> -		ERR(" *** Overrun Error\n");
> +		dev_err(udc->dev, " *** Overrun Error\n");
>  		return -EOVERFLOW;
>  	}

As I didn't take your previous patches, this one doesn't apply.  Please
redo the whole series and resend.

thanks,

greg k-h


  reply	other threads:[~2015-02-26 23:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 14:18 [PATCH v5 0/6] Staging: emxx_udc: Fix checkpatch.pl warnings Haneen Mohammed
2015-02-24 14:23 ` [PATCH v5 1/6] Staging: emxx_udc: Fix do not add new typedefs Haneen Mohammed
2015-02-26 23:20   ` [Outreachy kernel] " Greg KH
2015-02-24 14:31 ` [PATCH v5 2/6] Staging: emxx_udc: Remove volatile from union usb_regs_access Haneen Mohammed
2015-02-26 23:21   ` [Outreachy kernel] " Greg KH
2015-02-24 14:33 ` [PATCH v5 3/6] Staging: emxx_udc: Replace custom printk macro ERR with pr_err Haneen Mohammed
     [not found]   ` <20150226232212.GB21368@kroah.com>
2015-02-27  0:27     ` [Outreachy kernel] " Haneen Mohammed
2015-02-27  0:51       ` Greg KH
2015-02-24 14:36 ` [PATCH v5 4/6] Staging: emxx_udc: Replace custom printk macro ERR with dev_err Haneen Mohammed
2015-02-26 23:23   ` Greg KH [this message]
2015-02-24 14:39 ` [PATCH v5 5/6] Staging: emxx_udc: Remove custom printk macro ERR Haneen Mohammed
2015-02-24 14:41 ` [PATCH v5 6/6] Staging: emxx_udc: Clean dev_err() logging Haneen Mohammed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150226232305.GA21476@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.