* [PATCH] dmaengine: qcom_bam_dma: fix wrong register offsets
@ 2015-02-19 16:45 Stanimir Varbanov
2015-02-20 8:36 ` Archit Taneja
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stanimir Varbanov @ 2015-02-19 16:45 UTC (permalink / raw)
To: Vinod Koul
Cc: linux-kernel, dmaengine, linux-arm-msm, Andy Gross, Stephen Boyd,
Stanimir Varbanov
The commit fb93f520e (dmaengine: qcom_bam_dma: Generalize BAM
register offset calculations) wrongly populated base offsets
for event registers for bam v1.4.
Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com>
---
drivers/dma/qcom_bam_dma.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/qcom_bam_dma.c b/drivers/dma/qcom_bam_dma.c
index debe106..95b7668 100644
--- a/drivers/dma/qcom_bam_dma.c
+++ b/drivers/dma/qcom_bam_dma.c
@@ -162,9 +162,9 @@ static const struct reg_offset_data bam_v1_4_reg_info[] = {
[BAM_P_IRQ_STTS] = { 0x1010, 0x1000, 0x00, 0x00 },
[BAM_P_IRQ_CLR] = { 0x1014, 0x1000, 0x00, 0x00 },
[BAM_P_IRQ_EN] = { 0x1018, 0x1000, 0x00, 0x00 },
- [BAM_P_EVNT_DEST_ADDR] = { 0x102C, 0x00, 0x1000, 0x00 },
- [BAM_P_EVNT_REG] = { 0x1018, 0x00, 0x1000, 0x00 },
- [BAM_P_SW_OFSTS] = { 0x1000, 0x00, 0x1000, 0x00 },
+ [BAM_P_EVNT_DEST_ADDR] = { 0x182C, 0x00, 0x1000, 0x00 },
+ [BAM_P_EVNT_REG] = { 0x1818, 0x00, 0x1000, 0x00 },
+ [BAM_P_SW_OFSTS] = { 0x1800, 0x00, 0x1000, 0x00 },
[BAM_P_DATA_FIFO_ADDR] = { 0x1824, 0x00, 0x1000, 0x00 },
[BAM_P_DESC_FIFO_ADDR] = { 0x181C, 0x00, 0x1000, 0x00 },
[BAM_P_EVNT_GEN_TRSHLD] = { 0x1828, 0x00, 0x1000, 0x00 },
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dmaengine: qcom_bam_dma: fix wrong register offsets
2015-02-19 16:45 [PATCH] dmaengine: qcom_bam_dma: fix wrong register offsets Stanimir Varbanov
@ 2015-02-20 8:36 ` Archit Taneja
2015-02-20 22:33 ` Andy Gross
2015-03-05 16:37 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Archit Taneja @ 2015-02-20 8:36 UTC (permalink / raw)
To: Stanimir Varbanov, Vinod Koul
Cc: linux-kernel, dmaengine, linux-arm-msm, Andy Gross, Stephen Boyd
On 02/19/2015 10:15 PM, Stanimir Varbanov wrote:
> The commit fb93f520e (dmaengine: qcom_bam_dma: Generalize BAM
> register offset calculations) wrongly populated base offsets
> for event registers for bam v1.4.
>
> Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com>
> ---
> drivers/dma/qcom_bam_dma.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/qcom_bam_dma.c b/drivers/dma/qcom_bam_dma.c
> index debe106..95b7668 100644
> --- a/drivers/dma/qcom_bam_dma.c
> +++ b/drivers/dma/qcom_bam_dma.c
> @@ -162,9 +162,9 @@ static const struct reg_offset_data bam_v1_4_reg_info[] = {
> [BAM_P_IRQ_STTS] = { 0x1010, 0x1000, 0x00, 0x00 },
> [BAM_P_IRQ_CLR] = { 0x1014, 0x1000, 0x00, 0x00 },
> [BAM_P_IRQ_EN] = { 0x1018, 0x1000, 0x00, 0x00 },
> - [BAM_P_EVNT_DEST_ADDR] = { 0x102C, 0x00, 0x1000, 0x00 },
> - [BAM_P_EVNT_REG] = { 0x1018, 0x00, 0x1000, 0x00 },
> - [BAM_P_SW_OFSTS] = { 0x1000, 0x00, 0x1000, 0x00 },
> + [BAM_P_EVNT_DEST_ADDR] = { 0x182C, 0x00, 0x1000, 0x00 },
> + [BAM_P_EVNT_REG] = { 0x1818, 0x00, 0x1000, 0x00 },
> + [BAM_P_SW_OFSTS] = { 0x1800, 0x00, 0x1000, 0x00 },
> [BAM_P_DATA_FIFO_ADDR] = { 0x1824, 0x00, 0x1000, 0x00 },
> [BAM_P_DESC_FIFO_ADDR] = { 0x181C, 0x00, 0x1000, 0x00 },
> [BAM_P_EVNT_GEN_TRSHLD] = { 0x1828, 0x00, 0x1000, 0x00 },
>
Didn't know how this crept in. Apologies for the inconvenience!
Reviewed-by: Archit Taneja <architt@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dmaengine: qcom_bam_dma: fix wrong register offsets
2015-02-19 16:45 [PATCH] dmaengine: qcom_bam_dma: fix wrong register offsets Stanimir Varbanov
2015-02-20 8:36 ` Archit Taneja
@ 2015-02-20 22:33 ` Andy Gross
2015-03-05 16:37 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Andy Gross @ 2015-02-20 22:33 UTC (permalink / raw)
To: Stanimir Varbanov
Cc: Vinod Koul, linux-kernel, dmaengine, linux-arm-msm, Stephen Boyd
On Thu, Feb 19, 2015 at 06:45:50PM +0200, Stanimir Varbanov wrote:
> The commit fb93f520e (dmaengine: qcom_bam_dma: Generalize BAM
> register offset calculations) wrongly populated base offsets
> for event registers for bam v1.4.
>
> Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com>
Reviewed-by: Andy Gross <agross@codeaurora.org>
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dmaengine: qcom_bam_dma: fix wrong register offsets
2015-02-19 16:45 [PATCH] dmaengine: qcom_bam_dma: fix wrong register offsets Stanimir Varbanov
2015-02-20 8:36 ` Archit Taneja
2015-02-20 22:33 ` Andy Gross
@ 2015-03-05 16:37 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2015-03-05 16:37 UTC (permalink / raw)
To: Stanimir Varbanov
Cc: linux-kernel, dmaengine, linux-arm-msm, Andy Gross, Stephen Boyd
On Thu, Feb 19, 2015 at 06:45:50PM +0200, Stanimir Varbanov wrote:
> The commit fb93f520e (dmaengine: qcom_bam_dma: Generalize BAM
> register offset calculations) wrongly populated base offsets
> for event registers for bam v1.4.
>
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-05 16:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-19 16:45 [PATCH] dmaengine: qcom_bam_dma: fix wrong register offsets Stanimir Varbanov
2015-02-20 8:36 ` Archit Taneja
2015-02-20 22:33 ` Andy Gross
2015-03-05 16:37 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.