From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [UPDATED] [PATCH 3/5] arm-cci: Get rid of secure transactions for PMU driver
Date: Thu, 19 Mar 2015 17:32:52 +0000 [thread overview]
Message-ID: <20150319173252.GC10153@leverpostej> (raw)
In-Reply-To: <1426585901-19137-1-git-send-email-suzuki.poulose@arm.com>
One more thing:
> @@ -883,7 +894,11 @@ static inline const struct cci_pmu_model *get_cci_model(struct platform_device *
> pdev->dev.of_node);
> if (!match)
> return NULL;
> + if (match->data)
> + return match->data;
>
> + dev_warn(&pdev->dev, "DEPRECATED compatible property,"
> + "requires secure access to CCI registers");
> return probe_cci_model(pdev);
> }
Before the probe, could we please have:
if (!IS_ENABLED(CONFIG_ARM))
return -EINVAL;
On arm64 we require a model-specific string, and we shouldn't go
touching secure-only registers.
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: "Suzuki K. Poulose" <suzuki.poulose-5wv7dgnIgG8@public.gmane.org>
Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Nicolas Pitre <nico-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Bartlomiej Zolnierkiewicz
<b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Abhilash Kesavan
<a.kesavan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Liviu Dudau <Liviu.Dudau-5wv7dgnIgG8@public.gmane.org>,
Lorenzo Pieralisi
<Lorenzo.Pieralisi-5wv7dgnIgG8@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
Punit Agrawal <Punit.Agrawal-5wv7dgnIgG8@public.gmane.org>,
Sudeep Holla <Sudeep.Holla-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <Will.Deacon-5wv7dgnIgG8@public.gmane.org>,
Catalin Marinas <Catalin.Marinas-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [UPDATED] [PATCH 3/5] arm-cci: Get rid of secure transactions for PMU driver
Date: Thu, 19 Mar 2015 17:32:52 +0000 [thread overview]
Message-ID: <20150319173252.GC10153@leverpostej> (raw)
In-Reply-To: <1426585901-19137-1-git-send-email-suzuki.poulose-5wv7dgnIgG8@public.gmane.org>
One more thing:
> @@ -883,7 +894,11 @@ static inline const struct cci_pmu_model *get_cci_model(struct platform_device *
> pdev->dev.of_node);
> if (!match)
> return NULL;
> + if (match->data)
> + return match->data;
>
> + dev_warn(&pdev->dev, "DEPRECATED compatible property,"
> + "requires secure access to CCI registers");
> return probe_cci_model(pdev);
> }
Before the probe, could we please have:
if (!IS_ENABLED(CONFIG_ARM))
return -EINVAL;
On arm64 we require a model-specific string, and we shouldn't go
touching secure-only registers.
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Nicolas Pitre <nico@linaro.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Abhilash Kesavan <a.kesavan@samsung.com>,
Arnd Bergmann <arnd@arndb.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Olof Johansson <olof@lixom.net>, Pawel Moll <Pawel.Moll@arm.com>,
Punit Agrawal <Punit.Agrawal@arm.com>,
Sudeep Holla <Sudeep.Holla@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>
Subject: Re: [UPDATED] [PATCH 3/5] arm-cci: Get rid of secure transactions for PMU driver
Date: Thu, 19 Mar 2015 17:32:52 +0000 [thread overview]
Message-ID: <20150319173252.GC10153@leverpostej> (raw)
In-Reply-To: <1426585901-19137-1-git-send-email-suzuki.poulose@arm.com>
One more thing:
> @@ -883,7 +894,11 @@ static inline const struct cci_pmu_model *get_cci_model(struct platform_device *
> pdev->dev.of_node);
> if (!match)
> return NULL;
> + if (match->data)
> + return match->data;
>
> + dev_warn(&pdev->dev, "DEPRECATED compatible property,"
> + "requires secure access to CCI registers");
> return probe_cci_model(pdev);
> }
Before the probe, could we please have:
if (!IS_ENABLED(CONFIG_ARM))
return -EINVAL;
On arm64 we require a model-specific string, and we shouldn't go
touching secure-only registers.
Mark.
next prev parent reply other threads:[~2015-03-19 17:32 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 15:18 [PATCHv3 0/5] arm-cci400: PMU monitoring support on ARM64 Suzuki K. Poulose
2015-03-10 15:18 ` Suzuki K. Poulose
2015-03-10 15:18 ` Suzuki K. Poulose
2015-03-10 15:18 ` [PATCH 1/5] arm-cci: Rearrange code for splitting PMU vs driver code Suzuki K. Poulose
2015-03-10 15:18 ` Suzuki K. Poulose
2015-03-10 15:18 ` [PATCH 2/5] arm-cci: Abstract the CCI400 PMU speicific definitions Suzuki K. Poulose
2015-03-10 15:18 ` Suzuki K. Poulose
2015-03-10 15:18 ` Suzuki K. Poulose
2015-03-17 18:49 ` Will Deacon
2015-03-17 18:49 ` Will Deacon
2015-03-17 18:49 ` Will Deacon
2015-03-10 15:18 ` [PATCH 3/5] arm-cci: Get rid of secure transactions for PMU driver Suzuki K. Poulose
2015-03-10 15:18 ` Suzuki K. Poulose
2015-03-10 15:18 ` Suzuki K. Poulose
2015-03-17 9:51 ` [UPDATED] " Suzuki K. Poulose
2015-03-17 9:51 ` Suzuki K. Poulose
2015-03-19 17:25 ` Mark Rutland
2015-03-19 17:25 ` Mark Rutland
2015-03-19 17:32 ` Mark Rutland [this message]
2015-03-19 17:32 ` Mark Rutland
2015-03-19 17:32 ` Mark Rutland
2015-03-19 17:38 ` Sudeep Holla
2015-03-19 17:38 ` Sudeep Holla
2015-03-19 17:52 ` Suzuki K. Poulose
2015-03-19 17:52 ` Suzuki K. Poulose
2015-03-19 17:54 ` Mark Rutland
2015-03-19 17:54 ` Mark Rutland
2015-03-19 17:54 ` Mark Rutland
2015-03-10 15:18 ` [PATCH 4/5] arm-cci: Split the code for PMU vs driver support Suzuki K. Poulose
2015-03-10 15:18 ` Suzuki K. Poulose
2015-03-10 16:24 ` Sudeep Holla
2015-03-10 16:24 ` Sudeep Holla
2015-03-10 16:24 ` Sudeep Holla
2015-03-10 15:18 ` [PATCH 5/5] arm-cci: Fix CCI PMU event validation Suzuki K. Poulose
2015-03-10 15:18 ` Suzuki K. Poulose
2015-03-17 18:52 ` Will Deacon
2015-03-17 18:52 ` Will Deacon
2015-03-17 18:52 ` Will Deacon
2015-03-10 16:09 ` [PATCHv3 0/5] arm-cci400: PMU monitoring support on ARM64 Nicolas Pitre
2015-03-10 16:09 ` Nicolas Pitre
2015-03-10 16:09 ` Nicolas Pitre
2015-03-10 16:11 ` Suzuki K. Poulose
2015-03-10 16:11 ` Suzuki K. Poulose
2015-03-10 16:21 ` Sudeep Holla
2015-03-10 16:21 ` Sudeep Holla
2015-03-10 16:24 ` Suzuki K. Poulose
2015-03-10 16:24 ` Suzuki K. Poulose
2015-03-11 11:40 ` Punit Agrawal
2015-03-11 11:40 ` Punit Agrawal
2015-03-11 11:40 ` Punit Agrawal
2015-03-17 18:54 ` Will Deacon
2015-03-17 18:54 ` Will Deacon
2015-03-18 10:09 ` Suzuki K. Poulose
2015-03-18 10:09 ` Suzuki K. Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319173252.GC10153@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.