From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] eeprom: at24: Add support for large EEPROMs connected to SMBus adapters
Date: Wed, 25 Mar 2015 17:15:04 +0100 [thread overview]
Message-ID: <20150325161504.GA29838@katana> (raw)
In-Reply-To: <5512C213.7030705-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
Guenter,
thanks for the update
> Ultimately, the real problem is how i2c-dev accesses a client, not how
> i2c client drivers (who assume they have exclusive access to a chip)
> handle multi-command sequences. Forcing extensive locking on all drivers
> because of i2c-dev just doesn't seem to be the right thing to do.
I agree. i2c-dev is too much of a special case.
And since at24 has its own lock (I missed that), your patch might as
well be good enough to be applied, I'd think.
Thanks for this work!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eeprom: at24: Add support for large EEPROMs connected to SMBus adapters
Date: Wed, 25 Mar 2015 17:15:04 +0100 [thread overview]
Message-ID: <20150325161504.GA29838@katana> (raw)
In-Reply-To: <5512C213.7030705@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
Guenter,
thanks for the update
> Ultimately, the real problem is how i2c-dev accesses a client, not how
> i2c client drivers (who assume they have exclusive access to a chip)
> handle multi-command sequences. Forcing extensive locking on all drivers
> because of i2c-dev just doesn't seem to be the right thing to do.
I agree. i2c-dev is too much of a special case.
And since at24 has its own lock (I missed that), your patch might as
well be good enough to be applied, I'd think.
Thanks for this work!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-25 16:15 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 16:23 [PATCH] eeprom: at24: Add support for large EEPROMs connected to SMBus adapters Guenter Roeck
2015-02-04 16:23 ` Guenter Roeck
2015-02-04 17:47 ` Wolfram Sang
2015-02-04 19:08 ` Guenter Roeck
2015-02-04 19:08 ` Guenter Roeck
2015-02-04 23:35 ` Wolfram Sang
2015-02-05 0:26 ` Guenter Roeck
2015-02-05 0:26 ` Guenter Roeck
2015-02-05 14:40 ` Wolfram Sang
2015-02-05 17:53 ` Guenter Roeck
[not found] ` <20150205175326.GA26691-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-02-12 4:01 ` Guenter Roeck
2015-02-12 4:01 ` Guenter Roeck
2015-02-16 12:09 ` Wolfram Sang
2015-02-16 15:37 ` Guenter Roeck
2015-03-17 4:20 ` Guenter Roeck
2015-03-17 4:20 ` Guenter Roeck
2015-03-18 13:27 ` Wolfram Sang
2015-03-19 3:24 ` Guenter Roeck
[not found] ` <550A4162.8000009-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-03-19 8:16 ` Wolfram Sang
2015-03-19 8:16 ` Wolfram Sang
2015-03-19 13:30 ` Guenter Roeck
2015-03-19 13:30 ` Guenter Roeck
2015-03-19 17:43 ` Guenter Roeck
2015-03-19 17:43 ` Guenter Roeck
2015-03-19 21:39 ` Wolfram Sang
2015-03-25 14:11 ` Guenter Roeck
[not found] ` <5512C213.7030705-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-03-25 16:15 ` Wolfram Sang [this message]
2015-03-25 16:15 ` Wolfram Sang
2015-03-25 16:37 ` Guenter Roeck
2015-03-25 16:37 ` Guenter Roeck
2015-03-27 8:09 ` Wolfram Sang
2015-03-27 12:51 ` Guenter Roeck
2015-03-27 13:01 ` Wolfram Sang
2015-03-27 13:14 ` Guenter Roeck
2015-03-27 15:27 ` Wolfram Sang
2015-03-27 15:42 ` Guenter Roeck
2015-03-27 15:42 ` Guenter Roeck
2015-02-04 20:33 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325161504.GA29838@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.