[PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200

[mamlinav@gmail.com (Aleksei Mamlin)]

On Thu, 2 Apr 2015 20:50:08 +0200
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:

> On Tue, Mar 31, 2015 at 10:31:20PM +0300, Aleksei Mamlin wrote:
> > > > +		compatible = "goodix,gt911";
> > > > +		reg = <0x5d>;
> > > > +		interrupt-parent = <&pio>;
> > > > +		interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */
> > > 
> > > Unfortunately, IRQ_TYPE_NONE is not a valid value for the GIC
> > > bindings.
> > > 
> >
> > Hmm. Which value I must use in this case? IRQ type is set by the
> > touchscreen controller driver, so I think that value must be 0.
> 
> Whatever the hardware is using. Presumably the same value than the
> driver sets.
> 
> > >
> > > You're also not adding a pinctrl group for that pin?
> >
> > No, because it works fine with this DT nodes. It seems that I should
> > first configure pin to work in interrupt mode. Correct?
> 
> You don't have to, since the pio driver will already take care of
> muxing it to the right function, but that will prevent any driver to
> call pinctrl_request on the same pin.
> 
It is still necessary?
I see that you have accepted Hans de Goede's patches: http://www.spinics.net/lists/arm-kernel/msg411142.html
>
> Maxime
> 
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com


-- 
Thanks and regards,
Aleksei Mamlin