All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200
Date: Mon, 13 Apr 2015 18:09:51 +0200	[thread overview]
Message-ID: <20150413160951.GJ29832@lukather> (raw)
In-Reply-To: <20150411191816.cdc5ec802b01028eb2913906@gmail.com>

On Sat, Apr 11, 2015 at 07:18:16PM +0300, Aleksei Mamlin wrote:
> On Thu, 2 Apr 2015 11:22:59 +0200
> Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
> 
> > On Tue, Mar 31, 2015 at 10:14:20PM +0300, Aleksei Mamlin wrote:
> > > On Tue, 31 Mar 2015 07:43:38 -0700
> > > Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
> > > 
> > > > Hi,
> > > > 
> > > > On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote:
> > > > > This patch adds nodes for the Goodix GT911 touchscreen controller found
> > > > > on the Wexler TAB7200 tablet. Controller uses one of following I2C
> > > > > addresses: 0x5d or 0x14, so just add two nodes.
> > > > 
> > > > In which case are these different addresses encountered? Different
> > > > revisions of the same board?
> > >
> > > According to the datasheet it is a feature of the controller. 
> > > The address(0x5d or 0x14) can be configured using a reset sequence,
> > > which has not yet been implemented in the driver.
> > 
> > Which address is set up by the bootloader then?
>
> I assume that bootloader(u-boot) didn't sets up any address, but touchscreen
> controller usually uses 0x5d. Sometimes, after hard reset, it uses 0x14.
> For this we need nodes on both adresses.

I'm confused, who changes that address then?

The controller itself?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150413/94a5ec53/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200
Date: Mon, 13 Apr 2015 18:09:51 +0200	[thread overview]
Message-ID: <20150413160951.GJ29832@lukather> (raw)
In-Reply-To: <20150411191816.cdc5ec802b01028eb2913906-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]

On Sat, Apr 11, 2015 at 07:18:16PM +0300, Aleksei Mamlin wrote:
> On Thu, 2 Apr 2015 11:22:59 +0200
> Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> 
> > On Tue, Mar 31, 2015 at 10:14:20PM +0300, Aleksei Mamlin wrote:
> > > On Tue, 31 Mar 2015 07:43:38 -0700
> > > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > > 
> > > > Hi,
> > > > 
> > > > On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote:
> > > > > This patch adds nodes for the Goodix GT911 touchscreen controller found
> > > > > on the Wexler TAB7200 tablet. Controller uses one of following I2C
> > > > > addresses: 0x5d or 0x14, so just add two nodes.
> > > > 
> > > > In which case are these different addresses encountered? Different
> > > > revisions of the same board?
> > >
> > > According to the datasheet it is a feature of the controller. 
> > > The address(0x5d or 0x14) can be configured using a reset sequence,
> > > which has not yet been implemented in the driver.
> > 
> > Which address is set up by the bootloader then?
>
> I assume that bootloader(u-boot) didn't sets up any address, but touchscreen
> controller usually uses 0x5d. Sometimes, after hard reset, it uses 0x14.
> For this we need nodes on both adresses.

I'm confused, who changes that address then?

The controller itself?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-04-13 16:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-31  8:18 [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200 Aleksei Mamlin
2015-03-31  8:18 ` Aleksei Mamlin
2015-03-31 14:43 ` Maxime Ripard
2015-03-31 14:43   ` Maxime Ripard
2015-03-31 19:14   ` Aleksei Mamlin
2015-03-31 19:14     ` Aleksei Mamlin
2015-04-02  9:22     ` Maxime Ripard
2015-04-02  9:22       ` Maxime Ripard
2015-04-11 16:18       ` Aleksei Mamlin
2015-04-11 16:18         ` Aleksei Mamlin
2015-04-13 16:09         ` Maxime Ripard [this message]
2015-04-13 16:09           ` Maxime Ripard
2015-04-13 19:01           ` Aleksei Mamlin
2015-04-13 19:01             ` Aleksei Mamlin
2015-04-14 16:32             ` Maxime Ripard
2015-04-14 16:32               ` Maxime Ripard
2015-03-31 19:31   ` Aleksei Mamlin
2015-03-31 19:31     ` Aleksei Mamlin
2015-04-02 18:50     ` Maxime Ripard
2015-04-02 18:50       ` Maxime Ripard
2015-04-11 16:36       ` Aleksei Mamlin
2015-04-11 16:36         ` Aleksei Mamlin
2015-04-13 15:59         ` Maxime Ripard
2015-04-13 15:59           ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150413160951.GJ29832@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.