[PATCH] Do not assume mtu the mtu of xnb and mtu interfaces on FreeBSD.

[PATCH] Do not assume mtu the mtu of xnb and mtu interfaces on FreeBSD.

[Gustau Perez]

On creation time, tap and xnb interfaces are created with an mtu of
1500 bytes, assuming the bridge will have the same value.
Instead, check the bridge mtu and configure the new xnb or
tap interface with the same value.

The tools used are sed and ifconfig, both included on base. No need
to install additional ports (no new dependences).

Signed-off-by: Gustau Perez <gustau.perez@gmail.com>
---
 tools/hotplug/FreeBSD/vif-bridge | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/hotplug/FreeBSD/vif-bridge b/tools/hotplug/FreeBSD/vif-bridge
index d350df4..062b20a 100644
--- a/tools/hotplug/FreeBSD/vif-bridge
+++ b/tools/hotplug/FreeBSD/vif-bridge
@@ -22,6 +22,8 @@ action=$2
 case $action in
 add)
 	bridge=$(xenstore-read "$path/bridge")
+	mtu=$(ifconfig $bridge | sed -n 's/.*mtu \([0-9]*\)$/\1/p')
+	ifconfig $iface_dev mtu $mtu
 	ifconfig $bridge addm $iface_dev
 	ifconfig $iface_dev up
 	exit 0
-- 
2.3.5

Re: [PATCH] Do not assume mtu the mtu of xnb and mtu interfaces on FreeBSD.

[Roger Pau Monné]

El 20/04/15 a les 9.12, Gustau Perez ha escrit:
> On creation time, tap and xnb interfaces are created with an mtu of
> 1500 bytes, assuming the bridge will have the same value.
> Instead, check the bridge mtu and configure the new xnb or
> tap interface with the same value.
> 
> The tools used are sed and ifconfig, both included on base. No need
> to install additional ports (no new dependences).
> 
> Signed-off-by: Gustau Perez <gustau.perez@gmail.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

+CCing the tools maintainers.

Roger.

Re: [PATCH] Do not assume mtu the mtu of xnb and mtu interfaces on FreeBSD.

[Wei Liu]

On Mon, Apr 20, 2015 at 11:25:36AM +0200, Roger Pau Monné wrote:
> El 20/04/15 a les 9.12, Gustau Perez ha escrit:
> > On creation time, tap and xnb interfaces are created with an mtu of
> > 1500 bytes, assuming the bridge will have the same value.
> > Instead, check the bridge mtu and configure the new xnb or
> > tap interface with the same value.
> > 
> > The tools used are sed and ifconfig, both included on base. No need
> > to install additional ports (no new dependences).
> > 
> > Signed-off-by: Gustau Perez <gustau.perez@gmail.com>
> 
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> +CCing the tools maintainers.
> 

The patch title is a bit cryptic. Maybe change it to:

  hotplug: set network interface MTU to bridge MTU on FreeBSD

?

In any case

Acked-by: Wei Liu <wei.liu2@citrix.com>

Wei.

> Roger.

Re: [PATCH] Do not assume mtu the mtu of xnb and mtu interfaces on FreeBSD.

[Gustau Pérez]

On 20/04/2015 12:01, Wei Liu wrote:
> On Mon, Apr 20, 2015 at 11:25:36AM +0200, Roger Pau Monné wrote:
>> El 20/04/15 a les 9.12, Gustau Perez ha escrit:
>>> On creation time, tap and xnb interfaces are created with an mtu of
>>> 1500 bytes, assuming the bridge will have the same value.
>>> Instead, check the bridge mtu and configure the new xnb or
>>> tap interface with the same value.
>>>
>>> The tools used are sed and ifconfig, both included on base. No need
>>> to install additional ports (no new dependences).
>>>
>>> Signed-off-by: Gustau Perez <gustau.perez@gmail.com>
>> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>>
>> +CCing the tools maintainers.
>>
> The patch title is a bit cryptic. Maybe change it to:
>
>   hotplug: set network interface MTU to bridge MTU on FreeBSD
>
> ?
>
> In any case
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> Wei.

   Seems fine to me.

   Best,

   G.

Re: [PATCH] Do not assume mtu the mtu of xnb and mtu interfaces on FreeBSD.

[Ian Campbell]

On Mon, 2015-04-20 at 12:21 +0200, Gustau Pérez wrote:
> 
> On 20/04/2015 12:01, Wei Liu wrote:
> > On Mon, Apr 20, 2015 at 11:25:36AM +0200, Roger Pau Monné wrote:
> >> El 20/04/15 a les 9.12, Gustau Perez ha escrit:
> >>> On creation time, tap and xnb interfaces are created with an mtu of
> >>> 1500 bytes, assuming the bridge will have the same value.
> >>> Instead, check the bridge mtu and configure the new xnb or
> >>> tap interface with the same value.
> >>>
> >>> The tools used are sed and ifconfig, both included on base. No need
> >>> to install additional ports (no new dependences).
> >>>
> >>> Signed-off-by: Gustau Perez <gustau.perez@gmail.com>
> >> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> >>
> >> +CCing the tools maintainers.
> >>
> > The patch title is a bit cryptic. Maybe change it to:
> >
> >   hotplug: set network interface MTU to bridge MTU on FreeBSD
> >
> > ?
> >
> > In any case
> >
> > Acked-by: Wei Liu <wei.liu2@citrix.com>
> >
> > Wei.
> 
>    Seems fine to me.

I went with "hotplug/FreeBSD: set network interface MTU to bridge MTU".
Acked + applied, thanks.

> 
>    Best,
> 
>    G.



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel