* libxl, flexarray_append_pair usage
@ 2015-04-24 9:16 Olaf Hering
2015-04-24 9:23 ` Wei Liu
2015-05-01 13:33 ` Ian Campbell
0 siblings, 2 replies; 3+ messages in thread
From: Olaf Hering @ 2015-04-24 9:16 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Ian Jackson, Ian Campbell, Stefano Stabellini
On Fri, Apr 24, Olaf Hering wrote:
> flexarray_append(back, "state");
> - flexarray_append(back, GCSPRINTF("%d", 1));
> + flexarray_append(back, GCSPRINTF("%d", XenbusStateInitialising));
Should all such code be converted to flexarray_append_pair?
To reduce line length a short macro should be added, like FLXAP or
FLXPAIR or something else.
Olaf
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: libxl, flexarray_append_pair usage
2015-04-24 9:16 libxl, flexarray_append_pair usage Olaf Hering
@ 2015-04-24 9:23 ` Wei Liu
2015-05-01 13:33 ` Ian Campbell
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2015-04-24 9:23 UTC (permalink / raw)
To: Olaf Hering
Cc: Wei Liu, Stefano Stabellini, Ian Jackson, Ian Campbell, xen-devel
On Fri, Apr 24, 2015 at 11:16:00AM +0200, Olaf Hering wrote:
> On Fri, Apr 24, Olaf Hering wrote:
>
> > flexarray_append(back, "state");
> > - flexarray_append(back, GCSPRINTF("%d", 1));
> > + flexarray_append(back, GCSPRINTF("%d", XenbusStateInitialising));
>
> Should all such code be converted to flexarray_append_pair?
> To reduce line length a short macro should be added, like FLXAP or
> FLXPAIR or something else.
I don't have very strong opinion on this.
Wei.
>
> Olaf
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: libxl, flexarray_append_pair usage
2015-04-24 9:16 libxl, flexarray_append_pair usage Olaf Hering
2015-04-24 9:23 ` Wei Liu
@ 2015-05-01 13:33 ` Ian Campbell
1 sibling, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2015-05-01 13:33 UTC (permalink / raw)
To: Olaf Hering; +Cc: Ian Jackson, Stefano Stabellini, Wei Liu, xen-devel
On Fri, 2015-04-24 at 11:16 +0200, Olaf Hering wrote:
> On Fri, Apr 24, Olaf Hering wrote:
>
> > flexarray_append(back, "state");
> > - flexarray_append(back, GCSPRINTF("%d", 1));
> > + flexarray_append(back, GCSPRINTF("%d", XenbusStateInitialising));
>
> Should all such code be converted to flexarray_append_pair?
If you are touching the line anyway then I suppose that would be a good
thing, although not mandatory.
I don't think it is worth going through and proactively changing things.
> To reduce line length a short macro should be added, like FLXAP or
> FLXPAIR or something else.
Not sure about this, the macro doesn't save very much and FLX is a bit
opaque, I'd be inclined to just do normal wrapping for now.
Ian.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-01 13:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-24 9:16 libxl, flexarray_append_pair usage Olaf Hering
2015-04-24 9:23 ` Wei Liu
2015-05-01 13:33 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.