From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: at91: dts: add isi & ov2640 dt nodes for at91sam9m10g45ek board
Date: Thu, 18 Jun 2015 17:45:37 +0200 [thread overview]
Message-ID: <20150618154537.GM27492@piout.net> (raw)
In-Reply-To: <1434449315-9243-1-git-send-email-josh.wu@atmel.com>
Hi,
Seems good to me, a small comment below:
On 16/06/2015 at 18:08:34 +0800, Josh Wu wrote :
> @@ -1068,8 +1076,12 @@
> clocks = <&isi_clk>;
> clock-names = "isi_clk";
> pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_isi>;
> + pinctrl-0 = <&pinctrl_isi_data_0_7>;
I would say that the pinctrl is board specific so both pinctrl-names and
pinctrl-0 should go to at91sam9m10g45ek.dts
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Josh Wu <josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Cc: Nicolas Ferre
<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Jean-Christophe Plagniol-Villard
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>,
Andrew Victor <linux-PelNFVqkFnVyf+4FbqDuWQ@public.gmane.org>
Subject: Re: [PATCH v2 1/2] ARM: at91: dts: add isi & ov2640 dt nodes for at91sam9m10g45ek board
Date: Thu, 18 Jun 2015 17:45:37 +0200 [thread overview]
Message-ID: <20150618154537.GM27492@piout.net> (raw)
In-Reply-To: <1434449315-9243-1-git-send-email-josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Hi,
Seems good to me, a small comment below:
On 16/06/2015 at 18:08:34 +0800, Josh Wu wrote :
> @@ -1068,8 +1076,12 @@
> clocks = <&isi_clk>;
> clock-names = "isi_clk";
> pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_isi>;
> + pinctrl-0 = <&pinctrl_isi_data_0_7>;
I would say that the pinctrl is board specific so both pinctrl-names and
pinctrl-0 should go to at91sam9m10g45ek.dts
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Josh Wu <josh.wu@atmel.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-arm-kernel@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Andrew Victor <linux@maxim.org.za>
Subject: Re: [PATCH v2 1/2] ARM: at91: dts: add isi & ov2640 dt nodes for at91sam9m10g45ek board
Date: Thu, 18 Jun 2015 17:45:37 +0200 [thread overview]
Message-ID: <20150618154537.GM27492@piout.net> (raw)
In-Reply-To: <1434449315-9243-1-git-send-email-josh.wu@atmel.com>
Hi,
Seems good to me, a small comment below:
On 16/06/2015 at 18:08:34 +0800, Josh Wu wrote :
> @@ -1068,8 +1076,12 @@
> clocks = <&isi_clk>;
> clock-names = "isi_clk";
> pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_isi>;
> + pinctrl-0 = <&pinctrl_isi_data_0_7>;
I would say that the pinctrl is board specific so both pinctrl-names and
pinctrl-0 should go to at91sam9m10g45ek.dts
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-06-18 15:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 10:08 [PATCH v2 1/2] ARM: at91: dts: add isi & ov2640 dt nodes for at91sam9m10g45ek board Josh Wu
2015-06-16 10:08 ` Josh Wu
2015-06-16 10:08 ` Josh Wu
2015-06-16 10:08 ` [PATCH v2 2/2] ARM: at91: at91_dt_defconfig: enable ISI and ov2640 support Josh Wu
2015-06-16 10:08 ` Josh Wu
2015-07-28 7:37 ` Nicolas Ferre
2015-07-28 7:37 ` Nicolas Ferre
2015-07-28 8:15 ` Josh Wu
2015-07-28 8:15 ` Josh Wu
2015-07-30 12:20 ` Nicolas Ferre
2015-07-30 12:20 ` Nicolas Ferre
2015-06-18 15:45 ` Alexandre Belloni [this message]
2015-06-18 15:45 ` [PATCH v2 1/2] ARM: at91: dts: add isi & ov2640 dt nodes for at91sam9m10g45ek board Alexandre Belloni
2015-06-18 15:45 ` Alexandre Belloni
2015-07-30 12:03 ` Nicolas Ferre
2015-07-30 12:03 ` Nicolas Ferre
2015-07-30 12:03 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150618154537.GM27492@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.