From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: at91: dts: add isi & ov2640 dt nodes for at91sam9m10g45ek board
Date: Thu, 30 Jul 2015 14:03:54 +0200 [thread overview]
Message-ID: <55BA12AA.3030102@atmel.com> (raw)
In-Reply-To: <20150618154537.GM27492@piout.net>
Le 18/06/2015 17:45, Alexandre Belloni a ?crit :
> Hi,
>
> Seems good to me, a small comment below:
>
> On 16/06/2015 at 18:08:34 +0800, Josh Wu wrote :
>> @@ -1068,8 +1076,12 @@
>> clocks = <&isi_clk>;
>> clock-names = "isi_clk";
>> pinctrl-names = "default";
>> - pinctrl-0 = <&pinctrl_isi>;
>> + pinctrl-0 = <&pinctrl_isi_data_0_7>;
>
> I would say that the pinctrl is board specific so both pinctrl-names and
> pinctrl-0 should go to at91sam9m10g45ek.dts
I move it in the board file.
Otherwise:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
and stacked on top of at91-4.3-dt.
Bye,
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Josh Wu <josh.wu@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Andrew Victor <linux@maxim.org.za>
Subject: Re: [PATCH v2 1/2] ARM: at91: dts: add isi & ov2640 dt nodes for at91sam9m10g45ek board
Date: Thu, 30 Jul 2015 14:03:54 +0200 [thread overview]
Message-ID: <55BA12AA.3030102@atmel.com> (raw)
In-Reply-To: <20150618154537.GM27492@piout.net>
Le 18/06/2015 17:45, Alexandre Belloni a écrit :
> Hi,
>
> Seems good to me, a small comment below:
>
> On 16/06/2015 at 18:08:34 +0800, Josh Wu wrote :
>> @@ -1068,8 +1076,12 @@
>> clocks = <&isi_clk>;
>> clock-names = "isi_clk";
>> pinctrl-names = "default";
>> - pinctrl-0 = <&pinctrl_isi>;
>> + pinctrl-0 = <&pinctrl_isi_data_0_7>;
>
> I would say that the pinctrl is board specific so both pinctrl-names and
> pinctrl-0 should go to at91sam9m10g45ek.dts
I move it in the board file.
Otherwise:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
and stacked on top of at91-4.3-dt.
Bye,
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Josh Wu <josh.wu@atmel.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
Mark Rutland <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
<linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
Andrew Victor <linux@maxim.org.za>
Subject: Re: [PATCH v2 1/2] ARM: at91: dts: add isi & ov2640 dt nodes for at91sam9m10g45ek board
Date: Thu, 30 Jul 2015 14:03:54 +0200 [thread overview]
Message-ID: <55BA12AA.3030102@atmel.com> (raw)
In-Reply-To: <20150618154537.GM27492@piout.net>
Le 18/06/2015 17:45, Alexandre Belloni a écrit :
> Hi,
>
> Seems good to me, a small comment below:
>
> On 16/06/2015 at 18:08:34 +0800, Josh Wu wrote :
>> @@ -1068,8 +1076,12 @@
>> clocks = <&isi_clk>;
>> clock-names = "isi_clk";
>> pinctrl-names = "default";
>> - pinctrl-0 = <&pinctrl_isi>;
>> + pinctrl-0 = <&pinctrl_isi_data_0_7>;
>
> I would say that the pinctrl is board specific so both pinctrl-names and
> pinctrl-0 should go to at91sam9m10g45ek.dts
I move it in the board file.
Otherwise:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
and stacked on top of at91-4.3-dt.
Bye,
--
Nicolas Ferre
next prev parent reply other threads:[~2015-07-30 12:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 10:08 [PATCH v2 1/2] ARM: at91: dts: add isi & ov2640 dt nodes for at91sam9m10g45ek board Josh Wu
2015-06-16 10:08 ` Josh Wu
2015-06-16 10:08 ` Josh Wu
2015-06-16 10:08 ` [PATCH v2 2/2] ARM: at91: at91_dt_defconfig: enable ISI and ov2640 support Josh Wu
2015-06-16 10:08 ` Josh Wu
2015-07-28 7:37 ` Nicolas Ferre
2015-07-28 7:37 ` Nicolas Ferre
2015-07-28 8:15 ` Josh Wu
2015-07-28 8:15 ` Josh Wu
2015-07-30 12:20 ` Nicolas Ferre
2015-07-30 12:20 ` Nicolas Ferre
2015-06-18 15:45 ` [PATCH v2 1/2] ARM: at91: dts: add isi & ov2640 dt nodes for at91sam9m10g45ek board Alexandre Belloni
2015-06-18 15:45 ` Alexandre Belloni
2015-06-18 15:45 ` Alexandre Belloni
2015-07-30 12:03 ` Nicolas Ferre [this message]
2015-07-30 12:03 ` Nicolas Ferre
2015-07-30 12:03 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BA12AA.3030102@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.