From: Vladimir Davydov <vdavydov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
kernel-team-b10kYP2dOMg@public.gmane.org
Subject: Re: [PATCH 1/2] memcg: flatten task_struct->memcg_oom
Date: Wed, 2 Sep 2015 14:45:18 +0300 [thread overview]
Message-ID: <20150902114518.GA1237@esperanza> (raw)
In-Reply-To: <20150828220158.GD11089-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
On Fri, Aug 28, 2015 at 06:01:58PM -0400, Tejun Heo wrote:
> task_struct->memcg_oom is a sub-struct containing fields which are
> used for async memcg oom handling. Most task_struct fields aren't
> packaged this way and it can lead to unnecessary alignment paddings.
> This patch flattens it.
>
> * task.memcg_oom.memcg -> task.memcg_in_oom
> * task.memcg_oom.gfp_mask -> task.memcg_oom_gfp_mask
> * task.memcg_oom.order -> task.memcg_oom_order
> * task.memcg_oom.may_oom -> task.memcg_may_oom
>
> In addition, task.memcg_may_oom is relocated to where other bitfields
> are which reduces the size of task_struct.
>
> Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Reviewed-by: Vladimir Davydov <vdavydov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Davydov <vdavydov@parallels.com>
To: Tejun Heo <tj@kernel.org>
Cc: hannes@cmpxchg.org, mhocko@kernel.org, akpm@linux-foundation.org,
cgroups@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com
Subject: Re: [PATCH 1/2] memcg: flatten task_struct->memcg_oom
Date: Wed, 2 Sep 2015 14:45:18 +0300 [thread overview]
Message-ID: <20150902114518.GA1237@esperanza> (raw)
In-Reply-To: <20150828220158.GD11089@htj.dyndns.org>
On Fri, Aug 28, 2015 at 06:01:58PM -0400, Tejun Heo wrote:
> task_struct->memcg_oom is a sub-struct containing fields which are
> used for async memcg oom handling. Most task_struct fields aren't
> packaged this way and it can lead to unnecessary alignment paddings.
> This patch flattens it.
>
> * task.memcg_oom.memcg -> task.memcg_in_oom
> * task.memcg_oom.gfp_mask -> task.memcg_oom_gfp_mask
> * task.memcg_oom.order -> task.memcg_oom_order
> * task.memcg_oom.may_oom -> task.memcg_may_oom
>
> In addition, task.memcg_may_oom is relocated to where other bitfields
> are which reduces the size of task_struct.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Vladimir Davydov <vdavydov@parallels.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-09-02 11:45 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 22:01 [PATCH 1/2] memcg: flatten task_struct->memcg_oom Tejun Heo
2015-08-28 22:01 ` Tejun Heo
[not found] ` <20150828220158.GD11089-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2015-08-28 22:02 ` [PATCH 2/2] memcg: always enable kmemcg on the default hierarchy Tejun Heo
2015-08-28 22:02 ` Tejun Heo
2015-08-31 22:54 ` Andrew Morton
2015-09-04 21:00 ` [PATCH v2 3/2] memcg: punt high overage reclaim to return-to-userland path Tejun Heo
[not found] ` <20150904210011.GH25329-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-09-07 9:23 ` Michal Hocko
2015-09-07 9:23 ` Michal Hocko
[not found] ` <20150907092346.GC6022-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-09-08 16:59 ` Tejun Heo
2015-09-08 16:59 ` Tejun Heo
2015-09-07 11:38 ` Vladimir Davydov
2015-09-07 11:38 ` Vladimir Davydov
2015-09-08 17:00 ` Tejun Heo
2015-09-08 17:00 ` Tejun Heo
[not found] ` <20150828220237.GE11089-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2015-09-15 9:20 ` [PATCH 2/2] memcg: always enable kmemcg on the default hierarchy Johannes Weiner
2015-09-15 9:20 ` Johannes Weiner
2015-09-01 15:25 ` [PATCH 1/2] memcg: flatten task_struct->memcg_oom Michal Hocko
2015-09-01 15:25 ` Michal Hocko
2015-09-02 11:45 ` Vladimir Davydov [this message]
2015-09-02 11:45 ` Vladimir Davydov
-- strict thread matches above, loose matches on Subject: below --
2015-09-13 18:59 Tejun Heo
2015-09-13 18:59 ` Tejun Heo
[not found] ` <20150913185940.GA25369-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-09-15 7:37 ` Johannes Weiner
2015-09-15 7:37 ` Johannes Weiner
2015-09-20 14:45 ` Sasha Levin
2015-09-20 14:45 ` Sasha Levin
[not found] ` <55FEC685.5010404-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-09-21 20:01 ` Tejun Heo
2015-09-21 20:01 ` Tejun Heo
[not found] ` <20150921200141.GH13263-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-09-30 18:54 ` Tejun Heo
2015-09-30 18:54 ` Tejun Heo
2015-11-25 14:43 ` Peter Zijlstra
2015-11-25 14:43 ` Peter Zijlstra
[not found] ` <20151125144354.GB17308-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2015-11-25 15:02 ` Peter Zijlstra
2015-11-25 15:02 ` Peter Zijlstra
2015-11-25 15:31 ` Andrey Ryabinin
[not found] ` <CAPAsAGwa9-7UBUnhysfek3kyWKMgaUJRwtDPEqas1rKwkeTtoA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-25 17:34 ` Dmitry Vyukov
2015-11-25 17:34 ` Dmitry Vyukov
2015-11-25 17:44 ` Peter Zijlstra
[not found] ` <20151125174449.GD17308-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2015-12-11 16:25 ` Tejun Heo
2015-12-11 16:25 ` Tejun Heo
2015-12-15 19:22 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902114518.GA1237@esperanza \
--to=vdavydov-bzqdu9zft3wakbo8gow8eq@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kernel-team-b10kYP2dOMg@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.