From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
vdavydov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org,
kernel-team-b10kYP2dOMg@public.gmane.org
Subject: Re: [PATCH 1/2] memcg: flatten task_struct->memcg_oom
Date: Tue, 15 Sep 2015 09:37:30 +0200 [thread overview]
Message-ID: <20150915073730.GD2858@cmpxchg.org> (raw)
In-Reply-To: <20150913185940.GA25369-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
On Sun, Sep 13, 2015 at 02:59:40PM -0400, Tejun Heo wrote:
> task_struct->memcg_oom is a sub-struct containing fields which are
> used for async memcg oom handling. Most task_struct fields aren't
> packaged this way and it can lead to unnecessary alignment paddings.
> This patch flattens it.
>
> * task.memcg_oom.memcg -> task.memcg_in_oom
> * task.memcg_oom.gfp_mask -> task.memcg_oom_gfp_mask
> * task.memcg_oom.order -> task.memcg_oom_order
> * task.memcg_oom.may_oom -> task.memcg_may_oom
>
> In addition, task.memcg_may_oom is relocated to where other bitfields
> are which reduces the size of task_struct.
>
> Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Acked-by: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>
> Reviewed-by: Vladimir Davydov <vdavydov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Looks good to me, thanks.
Acked-by: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Tejun Heo <tj@kernel.org>
Cc: akpm@linux-foundation.org, mhocko@kernel.org,
cgroups@vger.kernel.org, linux-mm@kvack.org,
vdavydov@parallels.com, kernel-team@fb.com
Subject: Re: [PATCH 1/2] memcg: flatten task_struct->memcg_oom
Date: Tue, 15 Sep 2015 09:37:30 +0200 [thread overview]
Message-ID: <20150915073730.GD2858@cmpxchg.org> (raw)
In-Reply-To: <20150913185940.GA25369@htj.duckdns.org>
On Sun, Sep 13, 2015 at 02:59:40PM -0400, Tejun Heo wrote:
> task_struct->memcg_oom is a sub-struct containing fields which are
> used for async memcg oom handling. Most task_struct fields aren't
> packaged this way and it can lead to unnecessary alignment paddings.
> This patch flattens it.
>
> * task.memcg_oom.memcg -> task.memcg_in_oom
> * task.memcg_oom.gfp_mask -> task.memcg_oom_gfp_mask
> * task.memcg_oom.order -> task.memcg_oom_order
> * task.memcg_oom.may_oom -> task.memcg_may_oom
>
> In addition, task.memcg_may_oom is relocated to where other bitfields
> are which reduces the size of task_struct.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Acked-by: Michal Hocko <mhocko@suse.com>
> Reviewed-by: Vladimir Davydov <vdavydov@parallels.com>
Looks good to me, thanks.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-09-15 7:37 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 18:59 [PATCH 1/2] memcg: flatten task_struct->memcg_oom Tejun Heo
2015-09-13 18:59 ` Tejun Heo
2015-09-13 19:00 ` [PATCH v3 2/2] memcg: punt high overage reclaim to return-to-userland path Tejun Heo
[not found] ` <20150913190008.GB25369-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-09-15 7:47 ` Johannes Weiner
2015-09-15 7:47 ` Johannes Weiner
2015-09-15 15:53 ` Tejun Heo
2015-09-15 16:12 ` Johannes Weiner
[not found] ` <20150915161218.GA12032-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-09-15 16:22 ` Tejun Heo
2015-09-15 16:22 ` Tejun Heo
[not found] ` <20150915162253.GI2905-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-09-15 16:33 ` Johannes Weiner
2015-09-15 16:33 ` Johannes Weiner
[not found] ` <20150913185940.GA25369-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-09-15 7:37 ` Johannes Weiner [this message]
2015-09-15 7:37 ` [PATCH 1/2] memcg: flatten task_struct->memcg_oom Johannes Weiner
2015-09-20 14:45 ` Sasha Levin
2015-09-20 14:45 ` Sasha Levin
[not found] ` <55FEC685.5010404-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-09-21 20:01 ` Tejun Heo
2015-09-21 20:01 ` Tejun Heo
[not found] ` <20150921200141.GH13263-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-09-30 18:54 ` Tejun Heo
2015-09-30 18:54 ` Tejun Heo
2015-11-25 14:43 ` Peter Zijlstra
2015-11-25 14:43 ` Peter Zijlstra
[not found] ` <20151125144354.GB17308-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2015-11-25 15:02 ` Peter Zijlstra
2015-11-25 15:02 ` Peter Zijlstra
2015-11-25 15:31 ` Andrey Ryabinin
[not found] ` <CAPAsAGwa9-7UBUnhysfek3kyWKMgaUJRwtDPEqas1rKwkeTtoA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-25 17:34 ` Dmitry Vyukov
2015-11-25 17:34 ` Dmitry Vyukov
2015-11-25 17:44 ` Peter Zijlstra
[not found] ` <20151125174449.GD17308-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2015-12-11 16:25 ` Tejun Heo
2015-12-11 16:25 ` Tejun Heo
2015-12-15 19:22 ` Peter Zijlstra
2015-12-30 9:23 ` [PATCH v4.4-rc7] sched: isolate task_struct bitfields according to synchronization domains Tejun Heo
[not found] ` <20151230092337.GD3873-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-12-30 20:10 ` Linus Torvalds
2015-12-30 20:10 ` Linus Torvalds
2015-12-30 20:17 ` Linus Torvalds
[not found] ` <CA+55aFx0WxoUPrOPaq3HxM+YUQQ0DPV-c3f8kE1ec7agERb_Lg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-30 20:41 ` Tejun Heo
2015-12-30 20:41 ` Tejun Heo
2015-12-30 20:43 ` Linus Torvalds
2016-01-01 2:56 ` [PATCH v4.4-rc7] sched: move sched lock synchronized bitfields in task_struct into ->atomic_flags Tejun Heo
2016-01-01 2:56 ` Tejun Heo
[not found] ` <20160101025628.GA3660-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-01-06 13:44 ` Tejun Heo
2016-01-06 13:44 ` Tejun Heo
2016-01-06 18:48 ` [tip:sched/core] sched/core: Fix unserialized r-m-w scribbling stuff tip-bot for Peter Zijlstra
2016-01-06 20:17 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2015-08-28 22:01 [PATCH 1/2] memcg: flatten task_struct->memcg_oom Tejun Heo
2015-08-28 22:01 ` Tejun Heo
[not found] ` <20150828220158.GD11089-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2015-09-01 15:25 ` Michal Hocko
2015-09-01 15:25 ` Michal Hocko
2015-09-02 11:45 ` Vladimir Davydov
2015-09-02 11:45 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150915073730.GD2858@cmpxchg.org \
--to=hannes-druugvl0lcnafugrpc6u6w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kernel-team-b10kYP2dOMg@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vdavydov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.