From: Stephen Boyd <sboyd@codeaurora.org>
To: Lina Iyer <lina.iyer@linaro.org>
Cc: ulf.hansson@linaro.org, khilman@linaro.org,
linux-pm@vger.kernel.org, rjw@rjwysocki.net,
geert@linux-m68k.org, k.kozlowski@samsung.com,
linux-arm-kernel@lists.infradead.org, msivasub@codeaurora.org,
agross@codeaurora.org, Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH v2 7/7] ARM: smp: Add runtime PM support for CPU hotplug
Date: Thu, 3 Sep 2015 20:59:10 -0700 [thread overview]
Message-ID: <20150904035910.GL15099@codeaurora.org> (raw)
In-Reply-To: <1441310314-8857-8-git-send-email-lina.iyer@linaro.org>
On 09/03, Lina Iyer wrote:
> @@ -137,7 +138,6 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle)
> pr_err("CPU%u: failed to boot: %d\n", cpu, ret);
> }
>
> -
Please remove noise.
> memset(&secondary_data, 0, sizeof(secondary_data));
> return ret;
> }
> @@ -271,6 +271,16 @@ void __cpu_die(unsigned int cpu)
> void __ref cpu_die(void)
> {
> unsigned int cpu = smp_processor_id();
> + struct device *cpu_dev;
> +
> + /*
> + * We dont need the CPU device anymore.
s/dont/don't/
> + * Lets do this before IRQs are disabled to allow
s/Lets/Let's/
> + * runtime PM to suspend the domain as well.
> + */
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/7] ARM: smp: Add runtime PM support for CPU hotplug
Date: Thu, 3 Sep 2015 20:59:10 -0700 [thread overview]
Message-ID: <20150904035910.GL15099@codeaurora.org> (raw)
In-Reply-To: <1441310314-8857-8-git-send-email-lina.iyer@linaro.org>
On 09/03, Lina Iyer wrote:
> @@ -137,7 +138,6 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle)
> pr_err("CPU%u: failed to boot: %d\n", cpu, ret);
> }
>
> -
Please remove noise.
> memset(&secondary_data, 0, sizeof(secondary_data));
> return ret;
> }
> @@ -271,6 +271,16 @@ void __cpu_die(unsigned int cpu)
> void __ref cpu_die(void)
> {
> unsigned int cpu = smp_processor_id();
> + struct device *cpu_dev;
> +
> + /*
> + * We dont need the CPU device anymore.
s/dont/don't/
> + * Lets do this before IRQs are disabled to allow
s/Lets/Let's/
> + * runtime PM to suspend the domain as well.
> + */
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-09-04 3:59 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 19:58 [PATCH v2 0/7] PM / Domains: Generic PM domains for CPUs/Clusters Lina Iyer
2015-09-03 19:58 ` Lina Iyer
2015-09-03 19:58 ` [PATCH v2 1/7] PM / Domains: Allocate memory outside domain locks Lina Iyer
2015-09-03 19:58 ` Lina Iyer
2015-09-03 19:58 ` [PATCH v2 2/7] PM / Domains: Support IRQ safe PM domains Lina Iyer
2015-09-03 19:58 ` Lina Iyer
2015-09-04 10:02 ` Ulf Hansson
2015-09-04 10:02 ` Ulf Hansson
2015-09-04 16:05 ` Lina Iyer
2015-09-04 16:05 ` Lina Iyer
2015-10-01 21:11 ` Geert Uytterhoeven
2015-10-01 21:11 ` Geert Uytterhoeven
2015-09-03 19:58 ` [PATCH v2 3/7] drivers: cpu: Define CPU devices as IRQ safe Lina Iyer
2015-09-03 19:58 ` Lina Iyer
2015-09-04 4:00 ` Stephen Boyd
2015-09-04 4:00 ` Stephen Boyd
2015-09-03 19:58 ` [PATCH v2 4/7] PM / Domains: Introduce PM domains for CPUs/clusters Lina Iyer
2015-09-03 19:58 ` Lina Iyer
2015-09-04 3:54 ` Stephen Boyd
2015-09-04 3:54 ` Stephen Boyd
2015-09-03 19:58 ` [PATCH v2 5/7] ARM: cpuidle: Add runtime PM support for CPU idle Lina Iyer
2015-09-03 19:58 ` Lina Iyer
2015-09-03 19:58 ` [PATCH v2 6/7] ARM64: smp: Add runtime PM support for CPU hotplug Lina Iyer
2015-09-03 19:58 ` Lina Iyer
2015-09-30 12:36 ` Geert Uytterhoeven
2015-09-30 12:36 ` Geert Uytterhoeven
2015-09-03 19:58 ` [PATCH v2 7/7] ARM: " Lina Iyer
2015-09-03 19:58 ` Lina Iyer
2015-09-04 3:59 ` Stephen Boyd [this message]
2015-09-04 3:59 ` Stephen Boyd
2015-09-04 15:13 ` Lina Iyer
2015-09-04 15:13 ` Lina Iyer
2015-09-04 7:39 ` Geert Uytterhoeven
2015-09-04 7:39 ` Geert Uytterhoeven
2015-09-04 9:17 ` Russell King - ARM Linux
2015-09-04 9:17 ` Russell King - ARM Linux
2015-09-04 9:27 ` Russell King - ARM Linux
2015-09-04 9:27 ` Russell King - ARM Linux
2015-09-04 15:12 ` Lina Iyer
2015-09-04 15:12 ` Lina Iyer
2015-09-04 16:23 ` Russell King - ARM Linux
2015-09-04 16:23 ` Russell King - ARM Linux
2015-09-04 17:02 ` Lina Iyer
2015-09-04 17:02 ` Lina Iyer
2015-09-04 17:46 ` Russell King - ARM Linux
2015-09-04 17:46 ` Russell King - ARM Linux
2015-09-04 17:57 ` Grygorii Strashko
2015-09-04 17:57 ` Grygorii Strashko
2015-09-04 18:45 ` Alan Stern
2015-09-04 18:45 ` Alan Stern
2015-09-04 21:46 ` Grygorii Strashko
2015-09-04 21:46 ` Grygorii Strashko
2015-09-05 15:39 ` Alan Stern
2015-09-05 15:39 ` Alan Stern
2015-09-07 13:04 ` Rafael J. Wysocki
2015-09-07 13:04 ` Rafael J. Wysocki
2015-09-07 13:37 ` Grygorii Strashko
2015-09-07 13:37 ` Grygorii Strashko
2015-09-07 20:42 ` Rafael J. Wysocki
2015-09-07 20:42 ` Rafael J. Wysocki
2015-09-08 8:21 ` Grygorii Strashko
2015-09-08 8:21 ` Grygorii Strashko
2015-09-08 22:03 ` Kevin Hilman
2015-09-08 22:03 ` Kevin Hilman
2015-09-10 11:01 ` Grygorii Strashko
2015-09-10 11:01 ` Grygorii Strashko
2015-09-22 17:32 ` Lina Iyer
2015-09-22 17:32 ` Lina Iyer
2015-09-22 20:53 ` Thomas Gleixner
2015-09-22 20:53 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150904035910.GL15099@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=geert@linux-m68k.org \
--cc=k.kozlowski@samsung.com \
--cc=khilman@linaro.org \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=msivasub@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.