All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@sr71.net>
To: dave@sr71.net
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH 08/26] x86, pkeys: store protection in high VMA flags
Date: Wed, 16 Sep 2015 10:49:06 -0700	[thread overview]
Message-ID: <20150916174906.889ACF20@viggo.jf.intel.com> (raw)
In-Reply-To: <20150916174903.E112E464@viggo.jf.intel.com>


vma->vm_flags is an 'unsigned long', so has space for 32 flags
on 32-bit architectures.  The high 32 bits are unused on 64-bit
platforms.  We've steered away from using the unused high VMA
bits for things because we would have difficulty supporting it
on 32-bit.

Protection Keys are not available in 32-bit mode, so there is
no concern about supporting this feature in 32-bit mode or on
32-bit CPUs.

This patch carves out 4 bits from the high half of
vma->vm_flags and allows architectures to set config option
to make them available.

Sparse complains about these constants unless we explicitly
call them "UL".

---

 b/arch/x86/Kconfig   |    1 +
 b/include/linux/mm.h |    7 +++++++
 b/mm/Kconfig         |    3 +++
 3 files changed, 11 insertions(+)

diff -puN arch/x86/Kconfig~pkeys-07-eat-high-vma-flags arch/x86/Kconfig
--- a/arch/x86/Kconfig~pkeys-07-eat-high-vma-flags	2015-09-16 10:48:14.638118972 -0700
+++ b/arch/x86/Kconfig	2015-09-16 10:48:14.646119334 -0700
@@ -152,6 +152,7 @@ config X86
 	select VIRT_TO_BUS
 	select X86_DEV_DMA_OPS			if X86_64
 	select X86_FEATURE_NAMES		if PROC_FS
+	select ARCH_USES_HIGH_VMA_FLAGS		if X86_INTEL_MEMORY_PROTECTION_KEYS
 
 config INSTRUCTION_DECODER
 	def_bool y
diff -puN include/linux/mm.h~pkeys-07-eat-high-vma-flags include/linux/mm.h
--- a/include/linux/mm.h~pkeys-07-eat-high-vma-flags	2015-09-16 10:48:14.640119062 -0700
+++ b/include/linux/mm.h	2015-09-16 10:48:14.647119380 -0700
@@ -157,6 +157,13 @@ extern unsigned int kobjsize(const void
 #define VM_NOHUGEPAGE	0x40000000	/* MADV_NOHUGEPAGE marked this vma */
 #define VM_MERGEABLE	0x80000000	/* KSM may merge identical pages */
 
+#ifdef CONFIG_ARCH_USES_HIGH_VMA_FLAGS
+#define VM_HIGH_ARCH_0  0x100000000UL	/* bit only usable on 64-bit architectures */
+#define VM_HIGH_ARCH_1  0x200000000UL	/* bit only usable on 64-bit architectures */
+#define VM_HIGH_ARCH_2  0x400000000UL	/* bit only usable on 64-bit architectures */
+#define VM_HIGH_ARCH_3  0x800000000UL	/* bit only usable on 64-bit architectures */
+#endif /* CONFIG_ARCH_USES_HIGH_VMA_FLAGS */
+
 #if defined(CONFIG_X86)
 # define VM_PAT		VM_ARCH_1	/* PAT reserves whole VMA at once (x86) */
 #elif defined(CONFIG_PPC)
diff -puN mm/Kconfig~pkeys-07-eat-high-vma-flags mm/Kconfig
--- a/mm/Kconfig~pkeys-07-eat-high-vma-flags	2015-09-16 10:48:14.642119153 -0700
+++ b/mm/Kconfig	2015-09-16 10:48:14.647119380 -0700
@@ -680,3 +680,6 @@ config ZONE_DEVICE
 
 config FRAME_VECTOR
 	bool
+
+config ARCH_USES_HIGH_VMA_FLAGS
+	bool
_

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@sr71.net>
To: dave@sr71.net
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH 08/26] x86, pkeys: store protection in high VMA flags
Date: Wed, 16 Sep 2015 10:49:06 -0700	[thread overview]
Message-ID: <20150916174906.889ACF20@viggo.jf.intel.com> (raw)
In-Reply-To: <20150916174903.E112E464@viggo.jf.intel.com>


vma->vm_flags is an 'unsigned long', so has space for 32 flags
on 32-bit architectures.  The high 32 bits are unused on 64-bit
platforms.  We've steered away from using the unused high VMA
bits for things because we would have difficulty supporting it
on 32-bit.

Protection Keys are not available in 32-bit mode, so there is
no concern about supporting this feature in 32-bit mode or on
32-bit CPUs.

This patch carves out 4 bits from the high half of
vma->vm_flags and allows architectures to set config option
to make them available.

Sparse complains about these constants unless we explicitly
call them "UL".

---

 b/arch/x86/Kconfig   |    1 +
 b/include/linux/mm.h |    7 +++++++
 b/mm/Kconfig         |    3 +++
 3 files changed, 11 insertions(+)

diff -puN arch/x86/Kconfig~pkeys-07-eat-high-vma-flags arch/x86/Kconfig
--- a/arch/x86/Kconfig~pkeys-07-eat-high-vma-flags	2015-09-16 10:48:14.638118972 -0700
+++ b/arch/x86/Kconfig	2015-09-16 10:48:14.646119334 -0700
@@ -152,6 +152,7 @@ config X86
 	select VIRT_TO_BUS
 	select X86_DEV_DMA_OPS			if X86_64
 	select X86_FEATURE_NAMES		if PROC_FS
+	select ARCH_USES_HIGH_VMA_FLAGS		if X86_INTEL_MEMORY_PROTECTION_KEYS
 
 config INSTRUCTION_DECODER
 	def_bool y
diff -puN include/linux/mm.h~pkeys-07-eat-high-vma-flags include/linux/mm.h
--- a/include/linux/mm.h~pkeys-07-eat-high-vma-flags	2015-09-16 10:48:14.640119062 -0700
+++ b/include/linux/mm.h	2015-09-16 10:48:14.647119380 -0700
@@ -157,6 +157,13 @@ extern unsigned int kobjsize(const void
 #define VM_NOHUGEPAGE	0x40000000	/* MADV_NOHUGEPAGE marked this vma */
 #define VM_MERGEABLE	0x80000000	/* KSM may merge identical pages */
 
+#ifdef CONFIG_ARCH_USES_HIGH_VMA_FLAGS
+#define VM_HIGH_ARCH_0  0x100000000UL	/* bit only usable on 64-bit architectures */
+#define VM_HIGH_ARCH_1  0x200000000UL	/* bit only usable on 64-bit architectures */
+#define VM_HIGH_ARCH_2  0x400000000UL	/* bit only usable on 64-bit architectures */
+#define VM_HIGH_ARCH_3  0x800000000UL	/* bit only usable on 64-bit architectures */
+#endif /* CONFIG_ARCH_USES_HIGH_VMA_FLAGS */
+
 #if defined(CONFIG_X86)
 # define VM_PAT		VM_ARCH_1	/* PAT reserves whole VMA at once (x86) */
 #elif defined(CONFIG_PPC)
diff -puN mm/Kconfig~pkeys-07-eat-high-vma-flags mm/Kconfig
--- a/mm/Kconfig~pkeys-07-eat-high-vma-flags	2015-09-16 10:48:14.642119153 -0700
+++ b/mm/Kconfig	2015-09-16 10:48:14.647119380 -0700
@@ -680,3 +680,6 @@ config ZONE_DEVICE
 
 config FRAME_VECTOR
 	bool
+
+config ARCH_USES_HIGH_VMA_FLAGS
+	bool
_

  parent reply	other threads:[~2015-09-16 17:49 UTC|newest]

Thread overview: 172+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16 17:49 [PATCH 00/26] [RFCv2] x86: Memory Protection Keys Dave Hansen
2015-09-16 17:49 ` Dave Hansen
2015-09-16 17:49 ` [PATCH 02/26] x86, pkeys: Add Kconfig option Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 04/26] x86, pku: define new CR4 bit Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 01/26] x86, fpu: add placeholder for Processor Trace XSAVE state Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 03/26] x86, pkeys: cpuid bit definition Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 06/26] x86, pkeys: PTE bits for storing protection key Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 05/26] x86, pkey: add PKRU xsave fields and data structure(s) Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-22 19:53   ` Thomas Gleixner
2015-09-22 19:53     ` Thomas Gleixner
2015-09-22 19:58     ` Dave Hansen
2015-09-22 19:58       ` Dave Hansen
2015-09-16 17:49 ` [PATCH 07/26] x86, pkeys: new page fault error code bit: PF_PK Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 10/26] x86, pkeys: notify userspace about protection key faults Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-22 20:03   ` Thomas Gleixner
2015-09-22 20:03     ` Thomas Gleixner
2015-09-22 20:21     ` Dave Hansen
2015-09-22 20:21       ` Dave Hansen
2015-09-22 20:27       ` Thomas Gleixner
2015-09-22 20:27         ` Thomas Gleixner
2015-09-22 20:29         ` Dave Hansen
2015-09-22 20:29           ` Dave Hansen
2015-09-23  8:05           ` Ingo Molnar
2015-09-23  8:05             ` Ingo Molnar
2015-09-24  9:23   ` Ingo Molnar
2015-09-24  9:23     ` Ingo Molnar
2015-09-24  9:30     ` Ingo Molnar
2015-09-24  9:30       ` Ingo Molnar
2015-09-24 17:41       ` Dave Hansen
2015-09-24 17:41         ` Dave Hansen
2015-09-25  7:11         ` Ingo Molnar
2015-09-25  7:11           ` Ingo Molnar
2015-09-25 23:18           ` Dave Hansen
2015-09-25 23:18             ` Dave Hansen
2015-09-26  6:20             ` Ingo Molnar
2015-09-26  6:20               ` Ingo Molnar
2015-09-27 22:39               ` Dave Hansen
2015-09-27 22:39                 ` Dave Hansen
2015-09-28  5:59                 ` Ingo Molnar
2015-09-28  5:59                   ` Ingo Molnar
2015-09-24 17:15     ` Dave Hansen
2015-09-24 17:15       ` Dave Hansen
2015-09-28 19:25       ` Christian Borntraeger
2015-09-28 19:25         ` Christian Borntraeger
2015-09-28 19:32         ` Dave Hansen
2015-09-28 19:32           ` Dave Hansen
2015-09-16 17:49 ` Dave Hansen [this message]
2015-09-16 17:49   ` [PATCH 08/26] x86, pkeys: store protection in high VMA flags Dave Hansen
2015-09-16 17:49 ` [PATCH 09/26] x86, pkeys: arch-specific protection bits Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 11/26] x86, pkeys: add functions for set/fetch PKRU Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-22 20:05   ` Thomas Gleixner
2015-09-22 20:05     ` Thomas Gleixner
2015-09-22 20:22     ` Dave Hansen
2015-09-22 20:22       ` Dave Hansen
2015-09-16 17:49 ` [PATCH 12/26] mm: factor out VMA fault permission checking Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 13/26] mm: simplify get_user_pages() PTE bit handling Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 14/26] x86, pkeys: check VMAs and PTEs for protection keys Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 15/26] x86, pkeys: optimize fault handling in access_error() Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 17/26] x86, pkeys: dump PTE pkey in /proc/pid/smaps Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 16/26] x86, pkeys: dump PKRU with other kernel registers Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 19/26] [NEWSYSCALL] mm, multi-arch: pass a protection key in to calc_vm_flag_bits() Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 18/26] x86, pkeys: add Kconfig prompt to existing config option Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 20/26] [NEWSYSCALL] mm: implement new mprotect_pkey() system call Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 21/26] [NEWSYSCALL] x86: wire up mprotect_key() " Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 22/26] [HIJACKPROT] mm: Pass the 4-bit protection key in via PROT_ bits to syscalls Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 24/26] [HIJACKPROT] x86, pkeys: mask off pkeys bits in mprotect() Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 25/26] x86, pkeys: actually enable Memory Protection Keys in CPU Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 23/26] [HIJACKPROT] x86, pkeys: add x86 version of arch_validate_prot() Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 26/26] x86, pkeys: Documentation Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-20  8:55   ` Ingo Molnar
2015-09-20  8:55     ` Ingo Molnar
2015-09-21  4:34     ` Dave Hansen
2015-09-21  4:34       ` Dave Hansen
2015-09-24  9:49       ` Ingo Molnar
2015-09-24  9:49         ` Ingo Molnar
2015-09-24 19:10         ` Dave Hansen
2015-09-24 19:10           ` Dave Hansen
2015-09-24 19:17           ` Andy Lutomirski
2015-09-24 19:17             ` Andy Lutomirski
2015-09-25  7:16             ` Ingo Molnar
2015-09-25  7:16               ` Ingo Molnar
2015-09-25  6:15           ` Ingo Molnar
2015-09-25  6:15             ` Ingo Molnar
2015-10-01 11:17           ` Ingo Molnar
2015-10-01 11:17             ` Ingo Molnar
2015-10-01 20:39             ` Kees Cook
2015-10-01 20:39               ` Kees Cook
2015-10-01 20:45               ` Andy Lutomirski
2015-10-01 20:45                 ` Andy Lutomirski
2015-10-02  6:23                 ` Ingo Molnar
2015-10-02  6:23                   ` Ingo Molnar
2015-10-02 17:50                   ` Dave Hansen
2015-10-02 17:50                     ` Dave Hansen
2015-10-03  7:27                     ` Ingo Molnar
2015-10-03  7:27                       ` Ingo Molnar
2015-10-06 23:28                       ` Dave Hansen
2015-10-06 23:28                         ` Dave Hansen
2015-10-07  7:11                         ` Ingo Molnar
2015-10-07  7:11                           ` Ingo Molnar
2015-10-16 15:12                       ` Dave Hansen
2015-10-16 15:12                         ` Dave Hansen
2015-10-21 18:55                         ` Andy Lutomirski
2015-10-21 18:55                           ` Andy Lutomirski
2015-10-21 19:11                           ` Dave Hansen
2015-10-21 19:11                             ` Dave Hansen
2015-10-21 23:22                             ` Andy Lutomirski
2015-10-21 23:22                               ` Andy Lutomirski
2015-10-01 20:58               ` Dave Hansen
2015-10-01 20:58                 ` Dave Hansen
2015-10-01 22:33               ` Dave Hansen
2015-10-01 22:35                 ` Kees Cook
2015-10-01 22:35                   ` Kees Cook
2015-10-01 22:39                   ` Dave Hansen
2015-10-01 22:39                     ` Dave Hansen
2015-10-01 22:48                 ` Linus Torvalds
2015-10-01 22:48                   ` Linus Torvalds
2015-10-01 22:56                   ` Dave Hansen
2015-10-01 22:56                     ` Dave Hansen
2015-10-02  1:38                     ` Linus Torvalds
2015-10-02  1:38                       ` Linus Torvalds
2015-10-02 18:08                       ` Dave Hansen
2015-10-02 18:08                         ` Dave Hansen
2015-10-02  7:09                   ` Ingo Molnar
2015-10-02  7:09                     ` Ingo Molnar
2015-10-03  6:59                     ` Ingo Molnar
2015-10-03  6:59                       ` Ingo Molnar
2015-10-02 11:49                   ` Paolo Bonzini
2015-10-02 11:49                     ` Paolo Bonzini
2015-10-02 11:58                     ` Linus Torvalds
2015-10-02 11:58                       ` Linus Torvalds
2015-10-02 12:14                       ` Paolo Bonzini
2015-10-02 12:14                         ` Paolo Bonzini
2015-10-03  6:46                         ` Ingo Molnar
2015-10-03  6:46                           ` Ingo Molnar
2015-10-01 22:57                 ` Andy Lutomirski
2015-10-01 22:57                   ` Andy Lutomirski
2015-10-02  6:09                 ` Ingo Molnar
2015-10-02  6:09                   ` Ingo Molnar
2015-10-03  8:17         ` Ingo Molnar
2015-10-03  8:17           ` Ingo Molnar
2015-10-07 20:24           ` Dave Hansen
2015-10-07 20:24             ` Dave Hansen
2015-10-07 20:39             ` Andy Lutomirski
2015-10-07 20:39               ` Andy Lutomirski
2015-10-07 20:47               ` Dave Hansen
2015-10-07 20:47                 ` Dave Hansen
2015-09-16 17:51 ` Fwd: [PATCH 00/26] [RFCv2] x86: Memory Protection Keys Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150916174906.889ACF20@viggo.jf.intel.com \
    --to=dave@sr71.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.