All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Dave Hansen <dave@sr71.net>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Kees Cook <keescook@google.com>, Brian Gerst <brgerst@gmail.com>
Subject: Re: [PATCH 26/26] x86, pkeys: Documentation
Date: Sat, 3 Oct 2015 10:17:10 +0200	[thread overview]
Message-ID: <20151003081710.GA26206@gmail.com> (raw)
In-Reply-To: <20150924094956.GA30349@gmail.com>


* Ingo Molnar <mingo@kernel.org> wrote:

> 
> * Dave Hansen <dave@sr71.net> wrote:
> 
> > > Another question, related to enumeration as well: I'm wondering whether 
> > > there's any way for the kernel to allocate a bit or two for its own purposes - 
> > > such as protecting crypto keys? Or is the facility fundamentally intended for 
> > > user-space use only?
> > 
> > No, that's not possible with the current setup.
> 
> Ok, then another question, have you considered the following usecase:

So, I'm wondering about the following additional usecase:

Right now the native x86 PTE format allows two protection related bits for 
user-space pages:

  _PAGE_BIT_RW:                   if 0 the page is read-only,  if 1 then it's read-write
  _PAGE_BIT_NX:                   if 0 the page is executable, if 1 then it's not executable

As discussed previously, pkeys allows 'true execute only (--x)' mappings.

Another possibility would be 'true write-only (-w-)' mappings.

This too could in theory be introduced 'transparently', via 'pure PROT_WRITE' 
mappings (i.e. no PROT_READ|PROT_EXEC bits set). Assuming the amount of user-space 
with implicit 'PROT_WRITE implies PROT_READ' assumptions is not unmanageble for a 
distro willing to try this.

Usage of this would be more limited than of pure PROT_EXEC mappings, but it's a 
nonzero set:

 - Write-only log buffers that are normally mmap()-ed from a file.

 - Write-only write() IO buffers that are only accessed via write().
   (kernel-space accesses ignore pkey values.)

   glibc's buffered IO might possibly make use of this, for write-only
   fopen()ed files.

 - Language runtimes could improve their security by eliminating W+X mappings of 
   JIT-ed code, instead they could use two alias mappings: one alias is a 
   true-exec (--x) mapping, the other (separately mapped, separately randomized)
   mapping is a true write-only (--x) mapping for generated code.

In addition to the security advantage, another advantage would be increased 
robustness: no accidental corruption of IO (or JIT) buffers via read-only 
codepaths.

Another advantage would be that it would utilize pkeys without having to teach 
applications to use new system calls.

Thanks,

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Dave Hansen <dave@sr71.net>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Kees Cook <keescook@google.com>, Brian Gerst <brgerst@gmail.com>
Subject: Re: [PATCH 26/26] x86, pkeys: Documentation
Date: Sat, 3 Oct 2015 10:17:10 +0200	[thread overview]
Message-ID: <20151003081710.GA26206@gmail.com> (raw)
In-Reply-To: <20150924094956.GA30349@gmail.com>


* Ingo Molnar <mingo@kernel.org> wrote:

> 
> * Dave Hansen <dave@sr71.net> wrote:
> 
> > > Another question, related to enumeration as well: I'm wondering whether 
> > > there's any way for the kernel to allocate a bit or two for its own purposes - 
> > > such as protecting crypto keys? Or is the facility fundamentally intended for 
> > > user-space use only?
> > 
> > No, that's not possible with the current setup.
> 
> Ok, then another question, have you considered the following usecase:

So, I'm wondering about the following additional usecase:

Right now the native x86 PTE format allows two protection related bits for 
user-space pages:

  _PAGE_BIT_RW:                   if 0 the page is read-only,  if 1 then it's read-write
  _PAGE_BIT_NX:                   if 0 the page is executable, if 1 then it's not executable

As discussed previously, pkeys allows 'true execute only (--x)' mappings.

Another possibility would be 'true write-only (-w-)' mappings.

This too could in theory be introduced 'transparently', via 'pure PROT_WRITE' 
mappings (i.e. no PROT_READ|PROT_EXEC bits set). Assuming the amount of user-space 
with implicit 'PROT_WRITE implies PROT_READ' assumptions is not unmanageble for a 
distro willing to try this.

Usage of this would be more limited than of pure PROT_EXEC mappings, but it's a 
nonzero set:

 - Write-only log buffers that are normally mmap()-ed from a file.

 - Write-only write() IO buffers that are only accessed via write().
   (kernel-space accesses ignore pkey values.)

   glibc's buffered IO might possibly make use of this, for write-only
   fopen()ed files.

 - Language runtimes could improve their security by eliminating W+X mappings of 
   JIT-ed code, instead they could use two alias mappings: one alias is a 
   true-exec (--x) mapping, the other (separately mapped, separately randomized)
   mapping is a true write-only (--x) mapping for generated code.

In addition to the security advantage, another advantage would be increased 
robustness: no accidental corruption of IO (or JIT) buffers via read-only 
codepaths.

Another advantage would be that it would utilize pkeys without having to teach 
applications to use new system calls.

Thanks,

	Ingo

  parent reply	other threads:[~2015-10-03  8:17 UTC|newest]

Thread overview: 172+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16 17:49 [PATCH 00/26] [RFCv2] x86: Memory Protection Keys Dave Hansen
2015-09-16 17:49 ` Dave Hansen
2015-09-16 17:49 ` [PATCH 02/26] x86, pkeys: Add Kconfig option Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 04/26] x86, pku: define new CR4 bit Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 03/26] x86, pkeys: cpuid bit definition Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 01/26] x86, fpu: add placeholder for Processor Trace XSAVE state Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 06/26] x86, pkeys: PTE bits for storing protection key Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 05/26] x86, pkey: add PKRU xsave fields and data structure(s) Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-22 19:53   ` Thomas Gleixner
2015-09-22 19:53     ` Thomas Gleixner
2015-09-22 19:58     ` Dave Hansen
2015-09-22 19:58       ` Dave Hansen
2015-09-16 17:49 ` [PATCH 07/26] x86, pkeys: new page fault error code bit: PF_PK Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 10/26] x86, pkeys: notify userspace about protection key faults Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-22 20:03   ` Thomas Gleixner
2015-09-22 20:03     ` Thomas Gleixner
2015-09-22 20:21     ` Dave Hansen
2015-09-22 20:21       ` Dave Hansen
2015-09-22 20:27       ` Thomas Gleixner
2015-09-22 20:27         ` Thomas Gleixner
2015-09-22 20:29         ` Dave Hansen
2015-09-22 20:29           ` Dave Hansen
2015-09-23  8:05           ` Ingo Molnar
2015-09-23  8:05             ` Ingo Molnar
2015-09-24  9:23   ` Ingo Molnar
2015-09-24  9:23     ` Ingo Molnar
2015-09-24  9:30     ` Ingo Molnar
2015-09-24  9:30       ` Ingo Molnar
2015-09-24 17:41       ` Dave Hansen
2015-09-24 17:41         ` Dave Hansen
2015-09-25  7:11         ` Ingo Molnar
2015-09-25  7:11           ` Ingo Molnar
2015-09-25 23:18           ` Dave Hansen
2015-09-25 23:18             ` Dave Hansen
2015-09-26  6:20             ` Ingo Molnar
2015-09-26  6:20               ` Ingo Molnar
2015-09-27 22:39               ` Dave Hansen
2015-09-27 22:39                 ` Dave Hansen
2015-09-28  5:59                 ` Ingo Molnar
2015-09-28  5:59                   ` Ingo Molnar
2015-09-24 17:15     ` Dave Hansen
2015-09-24 17:15       ` Dave Hansen
2015-09-28 19:25       ` Christian Borntraeger
2015-09-28 19:25         ` Christian Borntraeger
2015-09-28 19:32         ` Dave Hansen
2015-09-28 19:32           ` Dave Hansen
2015-09-16 17:49 ` [PATCH 08/26] x86, pkeys: store protection in high VMA flags Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 11/26] x86, pkeys: add functions for set/fetch PKRU Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-22 20:05   ` Thomas Gleixner
2015-09-22 20:05     ` Thomas Gleixner
2015-09-22 20:22     ` Dave Hansen
2015-09-22 20:22       ` Dave Hansen
2015-09-16 17:49 ` [PATCH 09/26] x86, pkeys: arch-specific protection bits Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 13/26] mm: simplify get_user_pages() PTE bit handling Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 12/26] mm: factor out VMA fault permission checking Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 14/26] x86, pkeys: check VMAs and PTEs for protection keys Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 15/26] x86, pkeys: optimize fault handling in access_error() Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 16/26] x86, pkeys: dump PKRU with other kernel registers Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 17/26] x86, pkeys: dump PTE pkey in /proc/pid/smaps Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 19/26] [NEWSYSCALL] mm, multi-arch: pass a protection key in to calc_vm_flag_bits() Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 18/26] x86, pkeys: add Kconfig prompt to existing config option Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 20/26] [NEWSYSCALL] mm: implement new mprotect_pkey() system call Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 21/26] [NEWSYSCALL] x86: wire up mprotect_key() " Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 22/26] [HIJACKPROT] mm: Pass the 4-bit protection key in via PROT_ bits to syscalls Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 24/26] [HIJACKPROT] x86, pkeys: mask off pkeys bits in mprotect() Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 25/26] x86, pkeys: actually enable Memory Protection Keys in CPU Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 23/26] [HIJACKPROT] x86, pkeys: add x86 version of arch_validate_prot() Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-16 17:49 ` [PATCH 26/26] x86, pkeys: Documentation Dave Hansen
2015-09-16 17:49   ` Dave Hansen
2015-09-20  8:55   ` Ingo Molnar
2015-09-20  8:55     ` Ingo Molnar
2015-09-21  4:34     ` Dave Hansen
2015-09-21  4:34       ` Dave Hansen
2015-09-24  9:49       ` Ingo Molnar
2015-09-24  9:49         ` Ingo Molnar
2015-09-24 19:10         ` Dave Hansen
2015-09-24 19:10           ` Dave Hansen
2015-09-24 19:17           ` Andy Lutomirski
2015-09-24 19:17             ` Andy Lutomirski
2015-09-25  7:16             ` Ingo Molnar
2015-09-25  7:16               ` Ingo Molnar
2015-09-25  6:15           ` Ingo Molnar
2015-09-25  6:15             ` Ingo Molnar
2015-10-01 11:17           ` Ingo Molnar
2015-10-01 11:17             ` Ingo Molnar
2015-10-01 20:39             ` Kees Cook
2015-10-01 20:39               ` Kees Cook
2015-10-01 20:45               ` Andy Lutomirski
2015-10-01 20:45                 ` Andy Lutomirski
2015-10-02  6:23                 ` Ingo Molnar
2015-10-02  6:23                   ` Ingo Molnar
2015-10-02 17:50                   ` Dave Hansen
2015-10-02 17:50                     ` Dave Hansen
2015-10-03  7:27                     ` Ingo Molnar
2015-10-03  7:27                       ` Ingo Molnar
2015-10-06 23:28                       ` Dave Hansen
2015-10-06 23:28                         ` Dave Hansen
2015-10-07  7:11                         ` Ingo Molnar
2015-10-07  7:11                           ` Ingo Molnar
2015-10-16 15:12                       ` Dave Hansen
2015-10-16 15:12                         ` Dave Hansen
2015-10-21 18:55                         ` Andy Lutomirski
2015-10-21 18:55                           ` Andy Lutomirski
2015-10-21 19:11                           ` Dave Hansen
2015-10-21 19:11                             ` Dave Hansen
2015-10-21 23:22                             ` Andy Lutomirski
2015-10-21 23:22                               ` Andy Lutomirski
2015-10-01 20:58               ` Dave Hansen
2015-10-01 20:58                 ` Dave Hansen
2015-10-01 22:33               ` Dave Hansen
2015-10-01 22:35                 ` Kees Cook
2015-10-01 22:35                   ` Kees Cook
2015-10-01 22:39                   ` Dave Hansen
2015-10-01 22:39                     ` Dave Hansen
2015-10-01 22:48                 ` Linus Torvalds
2015-10-01 22:48                   ` Linus Torvalds
2015-10-01 22:56                   ` Dave Hansen
2015-10-01 22:56                     ` Dave Hansen
2015-10-02  1:38                     ` Linus Torvalds
2015-10-02  1:38                       ` Linus Torvalds
2015-10-02 18:08                       ` Dave Hansen
2015-10-02 18:08                         ` Dave Hansen
2015-10-02  7:09                   ` Ingo Molnar
2015-10-02  7:09                     ` Ingo Molnar
2015-10-03  6:59                     ` Ingo Molnar
2015-10-03  6:59                       ` Ingo Molnar
2015-10-02 11:49                   ` Paolo Bonzini
2015-10-02 11:49                     ` Paolo Bonzini
2015-10-02 11:58                     ` Linus Torvalds
2015-10-02 11:58                       ` Linus Torvalds
2015-10-02 12:14                       ` Paolo Bonzini
2015-10-02 12:14                         ` Paolo Bonzini
2015-10-03  6:46                         ` Ingo Molnar
2015-10-03  6:46                           ` Ingo Molnar
2015-10-01 22:57                 ` Andy Lutomirski
2015-10-01 22:57                   ` Andy Lutomirski
2015-10-02  6:09                 ` Ingo Molnar
2015-10-02  6:09                   ` Ingo Molnar
2015-10-03  8:17         ` Ingo Molnar [this message]
2015-10-03  8:17           ` Ingo Molnar
2015-10-07 20:24           ` Dave Hansen
2015-10-07 20:24             ` Dave Hansen
2015-10-07 20:39             ` Andy Lutomirski
2015-10-07 20:39               ` Andy Lutomirski
2015-10-07 20:47               ` Dave Hansen
2015-10-07 20:47                 ` Dave Hansen
2015-09-16 17:51 ` Fwd: [PATCH 00/26] [RFCv2] x86: Memory Protection Keys Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151003081710.GA26206@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dave@sr71.net \
    --cc=keescook@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.