All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v4 3/4] arm64: fix a migrating irq bug when hotplug cpu
Date: Thu, 17 Sep 2015 17:01:07 +0100	[thread overview]
Message-ID: <20150917160107.GO25634@arm.com> (raw)
In-Reply-To: <1442467166-1460-4-git-send-email-yangyingliang@huawei.com>

On Thu, Sep 17, 2015 at 06:19:25AM +0100, Yang Yingliang wrote:
> When cpu is disabled, all irqs will be migratged to another cpu.
> In some cases, a new affinity is different, it needed to be coppied
> to irq's affinity. But if the type of irq is LPI, it's affinity will
> not be coppied because of irq_set_affinity's return value. Fix it by
> using irq_do_set_affinity.
> 
> And migrating interrupts is a core code matter, so use the generic
> function move_irqs() to migrate interrupts in kernel/irq/migration.c.
> 
> Cc: Jiang Liu <jiang.liu@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>
> Cc: Hanjun Guo <hanjun.guo@linaro.org>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  arch/arm64/Kconfig           |  1 +
>  arch/arm64/include/asm/irq.h |  1 -
>  arch/arm64/kernel/irq.c      | 62 --------------------------------------------
>  arch/arm64/kernel/smp.c      |  2 +-
>  4 files changed, 2 insertions(+), 64 deletions(-)

Removing code is always good, so:

  Acked-by: Will Deacon <will.deacon@arm.com>

but obviously this depends on the core stuff.

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jiang Liu <jiang.liu@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <Marc.Zyngier@arm.com>,
	Mark Rutland <Mark.Rutland@arm.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	"hanjun.guo@linaro.org" <hanjun.guo@linaro.org>
Subject: Re: [RFC PATCH v4 3/4] arm64: fix a migrating irq bug when hotplug cpu
Date: Thu, 17 Sep 2015 17:01:07 +0100	[thread overview]
Message-ID: <20150917160107.GO25634@arm.com> (raw)
In-Reply-To: <1442467166-1460-4-git-send-email-yangyingliang@huawei.com>

On Thu, Sep 17, 2015 at 06:19:25AM +0100, Yang Yingliang wrote:
> When cpu is disabled, all irqs will be migratged to another cpu.
> In some cases, a new affinity is different, it needed to be coppied
> to irq's affinity. But if the type of irq is LPI, it's affinity will
> not be coppied because of irq_set_affinity's return value. Fix it by
> using irq_do_set_affinity.
> 
> And migrating interrupts is a core code matter, so use the generic
> function move_irqs() to migrate interrupts in kernel/irq/migration.c.
> 
> Cc: Jiang Liu <jiang.liu@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>
> Cc: Hanjun Guo <hanjun.guo@linaro.org>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  arch/arm64/Kconfig           |  1 +
>  arch/arm64/include/asm/irq.h |  1 -
>  arch/arm64/kernel/irq.c      | 62 --------------------------------------------
>  arch/arm64/kernel/smp.c      |  2 +-
>  4 files changed, 2 insertions(+), 64 deletions(-)

Removing code is always good, so:

  Acked-by: Will Deacon <will.deacon@arm.com>

but obviously this depends on the core stuff.

Will

  reply	other threads:[~2015-09-17 16:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  5:19 [RFC PATCH v4 0/4] arm/arm64: fix a migrating irq bug when hotplug cpu Yang Yingliang
2015-09-17  5:19 ` Yang Yingliang
2015-09-17  5:19 ` [RFC PATCH v4 1/4] genirq: introduce CONFIG_GENERIC_IRQ_MIGRATION Yang Yingliang
2015-09-17  5:19   ` Yang Yingliang
2015-09-17  5:19 ` [RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug Yang Yingliang
2015-09-17  5:19   ` Yang Yingliang
2015-09-17 16:44   ` Marc Zyngier
2015-09-17 16:44     ` Marc Zyngier
2015-09-17 22:04     ` Thomas Gleixner
2015-09-17 22:04       ` Thomas Gleixner
2015-09-17 22:09       ` Russell King - ARM Linux
2015-09-17 22:09         ` Russell King - ARM Linux
2015-09-18  1:13         ` Yang Yingliang
2015-09-18  1:13           ` Yang Yingliang
2015-09-17  5:19 ` [RFC PATCH v4 3/4] arm64: fix a migrating irq bug when hotplug cpu Yang Yingliang
2015-09-17  5:19   ` Yang Yingliang
2015-09-17 16:01   ` Will Deacon [this message]
2015-09-17 16:01     ` Will Deacon
2015-09-17  5:19 ` [RFC PATCH v4 4/4] arm: " Yang Yingliang
2015-09-17  5:19   ` Yang Yingliang
2015-09-17 22:10 ` [RFC PATCH v4 0/4] arm/arm64: " Thomas Gleixner
2015-09-17 22:10   ` Thomas Gleixner
2015-09-18  1:14   ` Yang Yingliang
2015-09-18  1:14     ` Yang Yingliang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150917160107.GO25634@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.